)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"174bfdddaa3cb296e0373dc0029b779db9f9449d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove support for OVS versions \u003c\u003d 2.8.2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After OVS 2.8.2 is realeased all tables shoud have the external_ids"},{"line_number":10,"context_line":"column. Unit tests now expect external_ids parameters too."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f244be2a1991cb39f4df6f1a9f12b19ac7e1c61"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_250fec89","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":28},"updated":"2020-11-05 14:57:06.000000000","message":"nit: released :)","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"174bfdddaa3cb296e0373dc0029b779db9f9449d","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        # version contains the column (when OVS 2.8.2 is released)."},{"line_number":636,"context_line":"        if not self.is_col_present(\u0027NAT\u0027, \u0027external_ids\u0027):"},{"line_number":637,"context_line":"            return"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        fip \u003d self.db_find(\u0027NAT\u0027, (\u0027external_ids\u0027, \u0027\u003d\u0027,"},{"line_number":640,"context_line":"                                   {ovn_const.OVN_FIP_EXT_ID_KEY: fip_id}))"},{"line_number":641,"context_line":"        result \u003d fip.execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c509d895","side":"PARENT","line":638,"updated":"2020-11-05 14:57:06.000000000","message":"Single line removals may harm backports. I think you aimed to remove the whole condition and the comment right?","commit_id":"b207f05ba718ccbb3c3404b531ac7bc5605c5580"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"ff7b965d304d0e75c8d5a358678e8b37afd6e50b","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        # version contains the column (when OVS 2.8.2 is released)."},{"line_number":636,"context_line":"        if not self.is_col_present(\u0027NAT\u0027, \u0027external_ids\u0027):"},{"line_number":637,"context_line":"            return"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        fip \u003d self.db_find(\u0027NAT\u0027, (\u0027external_ids\u0027, \u0027\u003d\u0027,"},{"line_number":640,"context_line":"                                   {ovn_const.OVN_FIP_EXT_ID_KEY: fip_id}))"},{"line_number":641,"context_line":"        result \u003d fip.execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d0bcefdd","side":"PARENT","line":638,"in_reply_to":"1f621f24_c509d895","updated":"2020-11-09 10:16:13.000000000","message":"yes, you are right!","commit_id":"b207f05ba718ccbb3c3404b531ac7bc5605c5580"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11025f70a62367975a609d89554184705245d5f9","unresolved":false,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        nat_rules \u003d []"},{"line_number":557,"context_line":"        for nat_rule in getattr(lrouter, \u0027nat\u0027, []):"},{"line_number":558,"context_line":"            ext_ids \u003d {}"},{"line_number":559,"context_line":"            ext_ids \u003d dict(getattr(nat_rule, \u0027external_ids\u0027, {}))"},{"line_number":560,"context_line":"            nat_rules.append({\u0027external_ip\u0027: nat_rule.external_ip,"},{"line_number":561,"context_line":"                              \u0027logical_ip\u0027: nat_rule.logical_ip,"},{"line_number":562,"context_line":"                              \u0027type\u0027: nat_rule.type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_fa2bcfe7","line":559,"range":{"start_line":558,"start_character":12,"end_line":559,"end_character":65},"updated":"2020-11-05 13:57:01.000000000","message":"You can remove L558","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"ff7b965d304d0e75c8d5a358678e8b37afd6e50b","unresolved":false,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        nat_rules \u003d []"},{"line_number":557,"context_line":"        for nat_rule in getattr(lrouter, \u0027nat\u0027, []):"},{"line_number":558,"context_line":"            ext_ids \u003d {}"},{"line_number":559,"context_line":"            ext_ids \u003d dict(getattr(nat_rule, \u0027external_ids\u0027, {}))"},{"line_number":560,"context_line":"            nat_rules.append({\u0027external_ip\u0027: nat_rule.external_ip,"},{"line_number":561,"context_line":"                              \u0027logical_ip\u0027: nat_rule.logical_ip,"},{"line_number":562,"context_line":"                              \u0027type\u0027: nat_rule.type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d0d34f37","line":559,"range":{"start_line":558,"start_character":12,"end_line":559,"end_character":65},"in_reply_to":"1f621f24_fa2bcfe7","updated":"2020-11-09 10:16:13.000000000","message":"Done","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11025f70a62367975a609d89554184705245d5f9","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        return result[0] if result else None"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def get_floatingip(self, fip_id):"},{"line_number":630,"context_line":"        # TODO(dalvarez): remove this check once the minimum OVS required"},{"line_number":631,"context_line":"        # version contains the column (when OVS 2.8.2 is released)."},{"line_number":632,"context_line":"        if not self.is_col_present(\u0027NAT\u0027, \u0027external_ids\u0027):"},{"line_number":633,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_1a396b40","line":630,"updated":"2020-11-05 13:57:01.000000000","message":"And this one?","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"ff7b965d304d0e75c8d5a358678e8b37afd6e50b","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        return result[0] if result else None"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def get_floatingip(self, fip_id):"},{"line_number":630,"context_line":"        # TODO(dalvarez): remove this check once the minimum OVS required"},{"line_number":631,"context_line":"        # version contains the column (when OVS 2.8.2 is released)."},{"line_number":632,"context_line":"        if not self.is_col_present(\u0027NAT\u0027, \u0027external_ids\u0027):"},{"line_number":633,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_b0d69326","line":630,"in_reply_to":"1f621f24_1a396b40","updated":"2020-11-09 10:16:13.000000000","message":"Done","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11025f70a62367975a609d89554184705245d5f9","unresolved":false,"context_lines":[{"line_number":654,"context_line":"            if self._nb_idl.lsp_get_up(floatingip[\u0027port_id\u0027]).execute():"},{"line_number":655,"context_line":"                columns[\u0027external_mac\u0027] \u003d port_db[\u0027mac_address\u0027]"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        columns[\u0027external_ids\u0027] \u003d ext_ids"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        # TODO(mjozefcz): Remove this workaround when OVN LB"},{"line_number":660,"context_line":"        # will support both decentralized FIPs on LB and member."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_da17f3a2","line":657,"range":{"start_line":657,"start_character":8,"end_line":657,"end_character":41},"updated":"2020-11-05 13:57:01.000000000","message":"You can add this one to L648-651","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11025f70a62367975a609d89554184705245d5f9","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"        port \u003d self._plugin.get_port(context, gw_port_id)"},{"line_number":1024,"context_line":"        self._create_lrouter_port(context, router, port, txn\u003dtxn)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"        def _build_extids(gw_info):"},{"line_number":1027,"context_line":"            columns \u003d {}"},{"line_number":1028,"context_line":"            columns[\u0027external_ids\u0027] \u003d {"},{"line_number":1029,"context_line":"                ovn_const.OVN_ROUTER_IS_EXT_GW: \u0027true\u0027,"},{"line_number":1030,"context_line":"                ovn_const.OVN_SUBNET_EXT_ID_KEY: gw_info.subnet_id}"},{"line_number":1031,"context_line":"            return columns"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"        # 2. Add default route with nexthop as gateway ip"},{"line_number":1034,"context_line":"        lrouter_name \u003d utils.ovn_name(router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_ba22f7fe","line":1031,"range":{"start_line":1026,"start_character":0,"end_line":1031,"end_character":26},"updated":"2020-11-05 13:57:01.000000000","message":"You can remove the whole function now and just assign \"columns\"","commit_id":"418156c83297b3c4cc5cc3eaf46ff64b1d947d8e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e5c38f593c08812f15fed3a23130623c31676c5c","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"        self._create_lrouter_port(context, router, port, txn\u003dtxn)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"        # 2. Add default route with nexthop as gateway ip"},{"line_number":1027,"context_line":"        lrouter_name \u003d utils.ovn_name(router[\u0027id\u0027])"},{"line_number":1028,"context_line":"        for gw_info in gateways:"},{"line_number":1029,"context_line":"            columns \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ae50f40b","line":1026,"updated":"2020-11-06 01:06:42.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"c78b2a6592afd5be98b1ed429cbf1f00aeb69966"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ef91b878d21c918fef5cc12bd98ad0815a1f2f74","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"        # 2. Add default route with nexthop as gateway ip"},{"line_number":1027,"context_line":"        lrouter_name \u003d utils.ovn_name(router[\u0027id\u0027])"},{"line_number":1028,"context_line":"        for gw_info in gateways:"},{"line_number":1029,"context_line":"            columns \u003d {}"},{"line_number":1030,"context_line":"            columns[\u0027external_ids\u0027] \u003d {"},{"line_number":1031,"context_line":"                ovn_const.OVN_ROUTER_IS_EXT_GW: \u0027true\u0027,"},{"line_number":1032,"context_line":"                ovn_const.OVN_SUBNET_EXT_ID_KEY: gw_info.subnet_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9f63a0b1","line":1029,"range":{"start_line":1029,"start_character":12,"end_line":1029,"end_character":24},"updated":"2020-11-06 09:40:20.000000000","message":"please, when creating a new variable, assign the value in the same command:\n\ncolumns \u003d {\u0027external_ids\u0027: {\n    ovn_const.OVN_ROUTER_IS_EXT_GW: \u0027true\u0027,\n    ovn_const.OVN_SUBNET_EXT_ID_KEY: gw_info.subnet_id}}","commit_id":"c78b2a6592afd5be98b1ed429cbf1f00aeb69966"}]}