)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"62af9ffb428549e652d4593eea109a466fecee69","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve the CIDRs overlap check method for router add interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a external network have multiple subnets, the router whose"},{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ceb9afa_dea4e985","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":4},"updated":"2020-11-24 11:45:06.000000000","message":"an","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5844abf9c08b9c50589f194bb1f6e2e203dc7b28","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve the CIDRs overlap check method for router add interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a external network have multiple subnets, the router whose"},{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e9a220a4_a71052e7","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":4},"in_reply_to":"1ceb9afa_dea4e985","updated":"2020-11-26 11:54:25.000000000","message":"thx","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"12a69190efc07fdb32d0eeee5a120eed0759fc4b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve the CIDRs overlap check method for router add interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a external network have multiple subnets, the router whose"},{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c168634e_0fbb9700","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":4},"in_reply_to":"e9a220a4_a71052e7","updated":"2020-11-26 12:16:34.000000000","message":"Done","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"62af9ffb428549e652d4593eea109a466fecee69","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a external network have multiple subnets, the router whose"},{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"},{"line_number":13,"context_line":"to be joined to check whether the CIDRs is overlap."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bc8a263d_0157893b","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":38},"updated":"2020-11-24 11:45:06.000000000","message":"was","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5844abf9c08b9c50589f194bb1f6e2e203dc7b28","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a external network have multiple subnets, the router whose"},{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"},{"line_number":13,"context_line":"to be joined to check whether the CIDRs is overlap."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eaabaafb_5a6e78b6","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":38},"in_reply_to":"bc8a263d_0157893b","updated":"2020-11-26 11:54:25.000000000","message":"thx","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"12a69190efc07fdb32d0eeee5a120eed0759fc4b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a external network have multiple subnets, the router whose"},{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"},{"line_number":13,"context_line":"to be joined to check whether the CIDRs is overlap."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8dc2942b_cbd2d814","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":38},"in_reply_to":"eaabaafb_5a6e78b6","updated":"2020-11-26 12:16:34.000000000","message":"Done","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"62af9ffb428549e652d4593eea109a466fecee69","unresolved":true,"context_lines":[{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"},{"line_number":13,"context_line":"to be joined to check whether the CIDRs is overlap."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, this patch revert the patch [1]"},{"line_number":16,"context_line":"[1] https://review.opendev.org/#/c/473356/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"105df534_ade53b19","line":13,"range":{"start_line":13,"start_character":43,"end_line":13,"end_character":50},"updated":"2020-11-24 11:45:06.000000000","message":"overlapped","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5844abf9c08b9c50589f194bb1f6e2e203dc7b28","unresolved":true,"context_lines":[{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"},{"line_number":13,"context_line":"to be joined to check whether the CIDRs is overlap."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, this patch revert the patch [1]"},{"line_number":16,"context_line":"[1] https://review.opendev.org/#/c/473356/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"122b393e_37fba972","line":13,"range":{"start_line":13,"start_character":43,"end_line":13,"end_character":50},"in_reply_to":"105df534_ade53b19","updated":"2020-11-26 11:54:25.000000000","message":"thx","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"12a69190efc07fdb32d0eeee5a120eed0759fc4b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"external gateway at the network will have all routes about those"},{"line_number":11,"context_line":"subnets. So, when a internal subnet be added to the router, all subnets"},{"line_number":12,"context_line":"of the the network which the router\u0027s external gateway belong to need"},{"line_number":13,"context_line":"to be joined to check whether the CIDRs is overlap."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, this patch revert the patch [1]"},{"line_number":16,"context_line":"[1] https://review.opendev.org/#/c/473356/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1e3a8131_87dd8cff","line":13,"range":{"start_line":13,"start_character":43,"end_line":13,"end_character":50},"in_reply_to":"122b393e_37fba972","updated":"2020-11-26 12:16:34.000000000","message":"Done","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"62af9ffb428549e652d4593eea109a466fecee69","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"                                                  expected_code\u003dexc."},{"line_number":1752,"context_line":"                                                  HTTPBadRequest.code)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    def test_router_add_interface_cidr_overlapped_with_gateway(self):"},{"line_number":1755,"context_line":"        with self.router() as r, self.network() as net:"},{"line_number":1756,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s1, self.subnet("},{"line_number":1757,"context_line":"                    network\u003dnet, cidr\u003d\u002710.0.0.0/16\u0027) as s2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"841b8e6a_d17e04dc","line":1754,"range":{"start_line":1754,"start_character":8,"end_line":1754,"end_character":62},"updated":"2020-11-24 11:45:06.000000000","message":"Could you add a test case that add the router interface first and then set the router external gateway with overlapped subnets?","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5844abf9c08b9c50589f194bb1f6e2e203dc7b28","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"                                                  expected_code\u003dexc."},{"line_number":1752,"context_line":"                                                  HTTPBadRequest.code)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    def test_router_add_interface_cidr_overlapped_with_gateway(self):"},{"line_number":1755,"context_line":"        with self.router() as r, self.network() as net:"},{"line_number":1756,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s1, self.subnet("},{"line_number":1757,"context_line":"                    network\u003dnet, cidr\u003d\u002710.0.0.0/16\u0027) as s2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"062389c3_82d0efe8","line":1754,"range":{"start_line":1754,"start_character":8,"end_line":1754,"end_character":62},"in_reply_to":"841b8e6a_d17e04dc","updated":"2020-11-26 11:54:25.000000000","message":"Sure, I will add it.","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5844abf9c08b9c50589f194bb1f6e2e203dc7b28","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"                                                  expected_code\u003dexc."},{"line_number":1752,"context_line":"                                                  HTTPBadRequest.code)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    def test_router_add_interface_cidr_overlapped_with_gateway(self):"},{"line_number":1755,"context_line":"        with self.router() as r, self.network() as net:"},{"line_number":1756,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s1, self.subnet("},{"line_number":1757,"context_line":"                    network\u003dnet, cidr\u003d\u002710.0.0.0/16\u0027) as s2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"e07f44d9_8acad6a9","line":1754,"range":{"start_line":1754,"start_character":8,"end_line":1754,"end_character":62},"in_reply_to":"841b8e6a_d17e04dc","updated":"2020-11-26 11:54:25.000000000","message":"Sure, I will add it.","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"12a69190efc07fdb32d0eeee5a120eed0759fc4b","unresolved":false,"context_lines":[{"line_number":1751,"context_line":"                                                  expected_code\u003dexc."},{"line_number":1752,"context_line":"                                                  HTTPBadRequest.code)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    def test_router_add_interface_cidr_overlapped_with_gateway(self):"},{"line_number":1755,"context_line":"        with self.router() as r, self.network() as net:"},{"line_number":1756,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s1, self.subnet("},{"line_number":1757,"context_line":"                    network\u003dnet, cidr\u003d\u002710.0.0.0/16\u0027) as s2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b2c1da9_9d932da8","line":1754,"range":{"start_line":1754,"start_character":8,"end_line":1754,"end_character":62},"in_reply_to":"e07f44d9_8acad6a9","updated":"2020-11-26 12:16:34.000000000","message":"Done","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"48a559d589edb083bb79d2ef7d99559e160d73f5","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"                                                  HTTPBadRequest.code)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    def test_router_add_interface_cidr_overlapped_with_gateway(self):"},{"line_number":1755,"context_line":"        with self.router() as r, self.network() as net:"},{"line_number":1756,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s1, self.subnet("},{"line_number":1757,"context_line":"                    network\u003dnet, cidr\u003d\u002710.0.0.0/16\u0027) as s2:"},{"line_number":1758,"context_line":"                ext_net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"45262f3a_452187d1","line":1755,"range":{"start_line":1755,"start_character":51,"end_line":1755,"end_character":54},"updated":"2020-11-24 10:24:50.000000000","message":"why not name it \"ext_net\"? It would be IMO easier to read it","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"12a69190efc07fdb32d0eeee5a120eed0759fc4b","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"                                                  HTTPBadRequest.code)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    def test_router_add_interface_cidr_overlapped_with_gateway(self):"},{"line_number":1755,"context_line":"        with self.router() as r, self.network() as net:"},{"line_number":1756,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s1, self.subnet("},{"line_number":1757,"context_line":"                    network\u003dnet, cidr\u003d\u002710.0.0.0/16\u0027) as s2:"},{"line_number":1758,"context_line":"                ext_net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"73e2a0a4_e79bafa4","line":1755,"range":{"start_line":1755,"start_character":51,"end_line":1755,"end_character":54},"in_reply_to":"45262f3a_452187d1","updated":"2020-11-26 12:16:34.000000000","message":"Done","commit_id":"7e9b19dc2f0916f28f8948b6e577050ab91866c4"}]}