)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a3b546bf1ca63b906c84d68d743d91372b1c516b","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: str(port_tags[port.port_name]) if port_tags[port.port_name] else \"no tag\"}"},{"line_number":1794,"context_line":"                    )"},{"line_number":1795,"context_line":"                    changed_ports.add(port.vif_id)"},{"line_number":1796,"context_line":"        if changed_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_3f0e87e4","line":1793,"range":{"start_line":1793,"start_character":41,"end_line":1793,"end_character":114},"updated":"2020-11-12 14:01:56.000000000","message":"1) max line length is 80\n\n2) this should be\n\n  \u0027new_vlan_tag\u0027: port_tags.get(port.port_name, \"no tag\")","commit_id":"0226e91333fe00aa4a70d9e368192a6b9cf055f4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"bf5b5d89c13e10fe4807a9c33e4402936083c8c4","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: str(port_tags[port.port_name]) if port_tags[port.port_name] else \"no tag\"}"},{"line_number":1794,"context_line":"                    )"},{"line_number":1795,"context_line":"                    changed_ports.add(port.vif_id)"},{"line_number":1796,"context_line":"        if changed_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_7233faab","line":1793,"range":{"start_line":1793,"start_character":41,"end_line":1793,"end_character":44},"updated":"2020-11-16 04:52:04.000000000","message":"no need for str() if have %s in string above;\nIs it important to have \u0027no tag\u0027 instead of just \u0027None\u0027? If not, this line could stay as was.","commit_id":"0226e91333fe00aa4a70d9e368192a6b9cf055f4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3b1f352ad4b9b39a2b61afe69472e43a53b81792","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: str(port_tags[port.port_name]) if port_tags[port.port_name] else \"no tag\"}"},{"line_number":1794,"context_line":"                    )"},{"line_number":1795,"context_line":"                    changed_ports.add(port.vif_id)"},{"line_number":1796,"context_line":"        if changed_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_77cdc383","line":1793,"updated":"2020-11-12 18:58:47.000000000","message":"pep8: E501 line too long (115 \u003e 79 characters)","commit_id":"0226e91333fe00aa4a70d9e368192a6b9cf055f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b9410af76ae4fea5bc35f1645235b0b27d4d7424","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: str(port_tags[port.port_name]) if port_tags[port.port_name] else \"no tag\"}"},{"line_number":1794,"context_line":"                    )"},{"line_number":1795,"context_line":"                    changed_ports.add(port.vif_id)"},{"line_number":1796,"context_line":"        if changed_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_cd220dbb","line":1793,"range":{"start_line":1793,"start_character":41,"end_line":1793,"end_character":114},"in_reply_to":"1f621f24_3f0e87e4","updated":"2020-11-18 09:12:54.000000000","message":"Done","commit_id":"0226e91333fe00aa4a70d9e368192a6b9cf055f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b9410af76ae4fea5bc35f1645235b0b27d4d7424","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: str(port_tags[port.port_name]) if port_tags[port.port_name] else \"no tag\"}"},{"line_number":1794,"context_line":"                    )"},{"line_number":1795,"context_line":"                    changed_ports.add(port.vif_id)"},{"line_number":1796,"context_line":"        if changed_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ed29c99b","line":1793,"range":{"start_line":1793,"start_character":41,"end_line":1793,"end_character":44},"in_reply_to":"1f621f24_7233faab","updated":"2020-11-18 09:12:54.000000000","message":"Done","commit_id":"0226e91333fe00aa4a70d9e368192a6b9cf055f4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b9410af76ae4fea5bc35f1645235b0b27d4d7424","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: str(port_tags[port.port_name]) if port_tags[port.port_name] else \"no tag\"}"},{"line_number":1794,"context_line":"                    )"},{"line_number":1795,"context_line":"                    changed_ports.add(port.vif_id)"},{"line_number":1796,"context_line":"        if changed_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_0d2d25a8","line":1793,"in_reply_to":"1f621f24_77cdc383","updated":"2020-11-18 09:12:54.000000000","message":"Done","commit_id":"0226e91333fe00aa4a70d9e368192a6b9cf055f4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"22eda1385c42819a8d872bb7b0080a9cce44c76a","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: port_tags.get(port.port_name, None)"},{"line_number":1794,"context_line":"                         }"},{"line_number":1795,"context_line":"                    )"},{"line_number":1796,"context_line":"                    changed_ports.add(port.vif_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_8d12d561","line":1793,"range":{"start_line":1793,"start_character":71,"end_line":1793,"end_character":75},"updated":"2020-11-18 09:16:12.000000000","message":"check for port.port_name in port_tags is done at #1784 so here could stay \u0027port_tags[port.port_name]\u0027","commit_id":"77dc2300ba0f646fcb88de7600ef90319cdfdbd7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ef9afef7fe4591922155614abae1c9c5f7d86e81","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                        \"Current vlan tag on this port is \u0027%(new_vlan_tag)s\u0027.\","},{"line_number":1791,"context_line":"                        {\u0027port_name\u0027: port.port_name,"},{"line_number":1792,"context_line":"                         \u0027vlan_tag\u0027: lvm.vlan,"},{"line_number":1793,"context_line":"                         \u0027new_vlan_tag\u0027: port_tags.get(port.port_name, None)"},{"line_number":1794,"context_line":"                         }"},{"line_number":1795,"context_line":"                    )"},{"line_number":1796,"context_line":"                    changed_ports.add(port.vif_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_081b5373","line":1793,"range":{"start_line":1793,"start_character":71,"end_line":1793,"end_character":75},"in_reply_to":"1f621f24_8d12d561","updated":"2020-11-18 09:21:57.000000000","message":"\u003e check for port.port_name in port_tags is done at #1784 so here\n \u003e could stay \u0027port_tags[port.port_name]\u0027\n\nOk, you are right, let me fix.","commit_id":"77dc2300ba0f646fcb88de7600ef90319cdfdbd7"}]}