)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f5e31e1be741e4f21fd39fd8f642854e6785d14a","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                                         may_exist\u003dmay_exist, **columns)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def delete_dhcp_options(self, row_uuid, if_exists\u003dTrue):"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        return cmd.DelDHCPOptionsCommand(self, row_uuid, if_exists\u003dif_exists)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def _format_dhcp_row(self, row):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_fe007136","line":460,"updated":"2020-11-16 12:12:24.000000000","message":"unrelated change","commit_id":"05d68072c34312aa988d1dc10db3fb213fb9a72c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f5e31e1be741e4f21fd39fd8f642854e6785d14a","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        if uuidutils.is_uuid_like(lrouter_name):"},{"line_number":662,"context_line":"            lrouter_name \u003d utils.ovn_name(lrouter_name)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        lr \u003d self.lr_get(lrouter_name)"},{"line_number":665,"context_line":"        result \u003d lr.execute(check_error\u003dTrue)"},{"line_number":666,"context_line":"        return result[0] if result else None"},{"line_number":667,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_7e362105","line":664,"updated":"2020-11-16 12:12:24.000000000","message":"There\u0027s a change of behavior here because this will raise \"RowNotFound\" if the LR does not exist, where before, it would return None (L666).\n\nWe can confirm this by running the following script: http://paste.openstack.org/show/800052/\n\nWe need to handle this RowNotFound exception and return None if the LR does not exist to keep the same behavior as before.","commit_id":"05d68072c34312aa988d1dc10db3fb213fb9a72c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eddb680f1cf8a32d3e098a4f144bb48062032743","unresolved":true,"context_lines":[{"line_number":652,"context_line":"            lrouter_name \u003d utils.ovn_name(lrouter_name)"},{"line_number":653,"context_line":"        try:"},{"line_number":654,"context_line":"            lr \u003d self.lr_get(lrouter_name)"},{"line_number":655,"context_line":"            result \u003d lr.execute(check_error\u003dTrue)[0]"},{"line_number":656,"context_line":"        except idlutils.RowNotFound:"},{"line_number":657,"context_line":"            pass"},{"line_number":658,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"74624ca5_b069fa4d","line":655,"updated":"2020-11-23 14:27:48.000000000","message":"nit: just to make code look better\n\nYou don\u0027t need to create this empty variable and you can return from inside the try/catch context.\n\ndef get_lrouter(self, lrouter_name):\nif uuidutils.is_uuid_like(lrouter_name):\n    lrouter_name \u003d utils.ovn_name(lrouter_name)\ntry:\n    return self.lr_get(lrouter_name).execute(check_error\u003dTrue)[0]\nexcept idlutils.RowNotFound:\n    pass","commit_id":"dadd48ab1c5ea4b29da428a2ad7b2c537d795e3a"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"c32ee9384ce47d27a2737c2338925243ccb46908","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            lrouter_name \u003d utils.ovn_name(lrouter_name)"},{"line_number":653,"context_line":"        try:"},{"line_number":654,"context_line":"            lr \u003d self.lr_get(lrouter_name)"},{"line_number":655,"context_line":"            result \u003d lr.execute(check_error\u003dTrue)[0]"},{"line_number":656,"context_line":"        except idlutils.RowNotFound:"},{"line_number":657,"context_line":"            pass"},{"line_number":658,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"412c74a6_dd63bd4c","line":655,"in_reply_to":"74624ca5_b069fa4d","updated":"2020-11-23 16:17:40.000000000","message":"Done, thanks!!","commit_id":"dadd48ab1c5ea4b29da428a2ad7b2c537d795e3a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f3d81d6907988541eb34e1d21e121280e4d1c1ff","unresolved":true,"context_lines":[{"line_number":651,"context_line":"            lrouter_name \u003d utils.ovn_name(lrouter_name)"},{"line_number":652,"context_line":"        try:"},{"line_number":653,"context_line":"            lr \u003d self.lr_get(lrouter_name)"},{"line_number":654,"context_line":"            result \u003d lr.execute(check_error\u003dTrue)[0]"},{"line_number":655,"context_line":"        except idlutils.RowNotFound:"},{"line_number":656,"context_line":"            result \u003d None"},{"line_number":657,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"97587d3b_c94fa885","line":654,"range":{"start_line":654,"start_character":49,"end_line":654,"end_character":52},"updated":"2020-11-24 09:42:04.000000000","message":"I don\u0027t think we need the index here, lr_get() seems to return the LR object directly, not a list of objects.\n\nresult \u003d self.lr_get(lrouter_name).execute(check_error\u003dTrue)","commit_id":"f1407eea88e4476c514635391cb30cdebe860b2a"}]}