)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cf9cc10e0046a66b40d13dfdefb07109a1561fd2","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def get_gre_tunnel_port_type(remote_ip, local_ip):"},{"line_number":107,"context_line":"    if (common_utils.get_ip_version(remote_ip) \u003d\u003d p_const.IP_VERSION_6 or"},{"line_number":108,"context_line":"            common_utils.get_ip_version(local_ip) \u003d\u003d p_const.IP_VERSION_6):"},{"line_number":109,"context_line":"        return TYPE_GRE_IP6"},{"line_number":110,"context_line":"    return p_const.TYPE_GRE"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_3b9aebc4","line":108,"updated":"2020-11-18 23:16:44.000000000","message":"This should be fine as and ovs agent will check the two ends of the tunnel are of the same protocol version in _setup_tunnel_port()","commit_id":"8eaf57c7678c427c0a69148b28bc0a7dc4574802"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"438a78d499b15d1939e781ede86811b36636170b","unresolved":true,"context_lines":[{"line_number":527,"context_line":"            options[\u0027tos\u0027] \u003d str(tos)"},{"line_number":528,"context_line":"        attrs.append((\u0027options\u0027, options))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        return self.add_port(port_name, *attrs)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    def add_patch_port(self, local_name, remote_name):"},{"line_number":533,"context_line":"        attrs \u003d [(\u0027type\u0027, \u0027patch\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"76063611_0044fd2b","line":530,"range":{"start_line":530,"start_character":41,"end_line":530,"end_character":46},"updated":"2020-11-25 15:21:25.000000000","message":"I have one concern about OVS support in IPv6. According to the reference you provide in the LP bug [1], \"L2 tunnel interface GRE over IPv6 is supported. L3 GRE tunnel over IPv6 is not supported.\"\n\nI think \"options:packet_type\u003dlegacy_l2\" [2] is the default option in the interface, but maybe we should enforce this config option.\n\n[1]https://docs.openvswitch.org/en/latest/faq/configuration/\n[2]http://www.openvswitch.org/support/dist-docs/ovs-vswitchd.conf.db.5.html","commit_id":"884ca714d127e42a7356d3be6054ee017c62322a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"389ad86015b0ae51ef8e7f4adbf0bf96f59af0ed","unresolved":false,"context_lines":[{"line_number":527,"context_line":"            options[\u0027tos\u0027] \u003d str(tos)"},{"line_number":528,"context_line":"        attrs.append((\u0027options\u0027, options))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        return self.add_port(port_name, *attrs)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    def add_patch_port(self, local_name, remote_name):"},{"line_number":533,"context_line":"        attrs \u003d [(\u0027type\u0027, \u0027patch\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"cf545443_b1a8247c","line":530,"range":{"start_line":530,"start_character":41,"end_line":530,"end_character":46},"in_reply_to":"76063611_0044fd2b","updated":"2020-12-03 12:04:18.000000000","message":"Done","commit_id":"884ca714d127e42a7356d3be6054ee017c62322a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19974ab85e484cd0d996fd65648743cdd474f9bd","unresolved":true,"context_lines":[{"line_number":528,"context_line":"        if tunnel_type \u003d\u003d TYPE_GRE_IP6:"},{"line_number":529,"context_line":"            # NOTE(slaweq) According to the OVS documentation L3 GRE tunnels"},{"line_number":530,"context_line":"            # over IPv6 are not supported."},{"line_number":531,"context_line":"            options[\u0027packet_type\u0027] \u003d \u0027legacy\u0027"},{"line_number":532,"context_line":"        attrs.append((\u0027options\u0027, options))"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        return self.add_port(port_name, *attrs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3d8947d8_a1394569","line":531,"range":{"start_line":531,"start_character":38,"end_line":531,"end_character":44},"updated":"2020-12-04 16:00:05.000000000","message":"+1","commit_id":"80e6781bc2d2b39e547e80996743d29ec090c816"}],"neutron/tests/functional/agent/test_ovs_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"438a78d499b15d1939e781ede86811b36636170b","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                                 self.br.br_name, \u0027datapath_id\u0027, dpid)"},{"line_number":212,"context_line":"        self.assertIn(dpid, self.br.get_datapath_id())"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _test_add_tunnel_port(self, attrs, expected_tunnel_type\u003d\u0027gre\u0027):"},{"line_number":215,"context_line":"        port_name \u003d utils.get_rand_device_name(net_helpers.PORT_PREFIX)"},{"line_number":216,"context_line":"        self.br.add_tunnel_port(port_name, attrs[\u0027remote_ip\u0027],"},{"line_number":217,"context_line":"                                attrs[\u0027local_ip\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"08b727d8_6afbb7c7","line":214,"range":{"start_line":214,"start_character":64,"end_line":214,"end_character":69},"updated":"2020-11-25 15:21:25.000000000","message":"super nit: const.TYPE_GRE","commit_id":"884ca714d127e42a7356d3be6054ee017c62322a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"389ad86015b0ae51ef8e7f4adbf0bf96f59af0ed","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                                 self.br.br_name, \u0027datapath_id\u0027, dpid)"},{"line_number":212,"context_line":"        self.assertIn(dpid, self.br.get_datapath_id())"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _test_add_tunnel_port(self, attrs, expected_tunnel_type\u003d\u0027gre\u0027):"},{"line_number":215,"context_line":"        port_name \u003d utils.get_rand_device_name(net_helpers.PORT_PREFIX)"},{"line_number":216,"context_line":"        self.br.add_tunnel_port(port_name, attrs[\u0027remote_ip\u0027],"},{"line_number":217,"context_line":"                                attrs[\u0027local_ip\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"33471d86_6b7ac86c","line":214,"range":{"start_line":214,"start_character":64,"end_line":214,"end_character":69},"in_reply_to":"08b727d8_6afbb7c7","updated":"2020-12-03 12:04:18.000000000","message":"Done","commit_id":"884ca714d127e42a7356d3be6054ee017c62322a"}]}