)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"3d21ad947409036616e819da5e1727b8ba83fc78","unresolved":false,"context_lines":[{"line_number":12,"context_line":"requirement too."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I485762b46567a99b9ebd6eb047c7088fed8071d1"},{"line_number":15,"context_line":"Related-Bug: 1904412"},{"line_number":16,"context_line":"Signed-off-by: Elvira García Ruiz \u003cegarciar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fffc6b78_b613770d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"updated":"2020-11-20 14:47:58.000000000","message":"Are you planning to send more patches to this? If not, this might as well be changed to Closes-Bug: #1904412\n\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#committing-changes","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1fb42475e1421a7281578dd6e891e319bddc39c4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"requirement too."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I485762b46567a99b9ebd6eb047c7088fed8071d1"},{"line_number":15,"context_line":"Related-Bug: 1904412"},{"line_number":16,"context_line":"Signed-off-by: Elvira García Ruiz \u003cegarciar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"83b24422_f46b905d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"fffc6b78_b613770d","updated":"2020-11-23 10:05:20.000000000","message":"I didn\u0027t add it before because this was a WIP and I wasn\u0027t sure if it was appropiate. Thanks!!","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"3a36afdb1e5fb32f8c0cee3a33f72ee51e3ef053","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Elvira García \u003cegarciar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-22 13:49:26 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unwanted IP addresses from OVN ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Once mac learning is added in OVN v21.03, if DHCP and port security are"},{"line_number":10,"context_line":"disabled, then the addresses field of a port should not include its MAC IP."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"194eed4e_2efb4909","line":7,"updated":"2021-03-22 14:52:56.000000000","message":"You can prepend a tag to easily identify OVN patches such as \u0027[ovn]: \u0027","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"39dd318f504ae02063ae8908349aceff909adc49","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-03-22 13:49:26 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unwanted IP addresses from OVN ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Once mac learning is added in OVN v21.03, if DHCP and port security are"},{"line_number":10,"context_line":"disabled, then the addresses field of a port should not include its MAC IP."},{"line_number":11,"context_line":"This allows to send traffic to all ports with an unknown address. Existing"},{"line_number":12,"context_line":"tests now match this requirement too."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"415304c7_4f3eee26","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":40},"updated":"2021-03-22 14:48:46.000000000","message":"MAC learning has been added already, we can probably change this and link to the patches:\n\nhttp://patchwork.ozlabs.org/project/ovn/list/?series\u003d228135\u0026state\u003d%2A\u0026archive\u003dboth","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"39dd318f504ae02063ae8908349aceff909adc49","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove unwanted IP addresses from OVN ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Once mac learning is added in OVN v21.03, if DHCP and port security are"},{"line_number":10,"context_line":"disabled, then the addresses field of a port should not include its MAC IP."},{"line_number":11,"context_line":"This allows to send traffic to all ports with an unknown address. Existing"},{"line_number":12,"context_line":"tests now match this requirement too."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a13d7a02_80027b6e","line":10,"range":{"start_line":10,"start_character":68,"end_line":10,"end_character":75},"updated":"2021-03-22 14:48:46.000000000","message":"MAC - IP address pairs ?","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6d76a2a10a90c431156b038efe1b26488f8614e1","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Once mac learning is added in OVN v21.03, if DHCP and port security are"},{"line_number":10,"context_line":"disabled, then the addresses field of a port should not include its MAC IP."},{"line_number":11,"context_line":"This allows to send traffic to all ports with an unknown address. Existing"},{"line_number":12,"context_line":"tests now match this requirement too."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I485762b46567a99b9ebd6eb047c7088fed8071d1"},{"line_number":15,"context_line":"Closes-Bug: 1904412"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9cffca3f_1a1956f7","line":12,"range":{"start_line":11,"start_character":66,"end_line":12,"end_character":37},"updated":"2021-03-22 14:51:13.000000000","message":"another nit: line length :)\n\nhttps://review.opendev.org/plugins/commit-message-length-validator/Documentation/config.html","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"d2c6d699716e57c7a02eac5ff92a2d709d3bcd40","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MAC learning has been added in OVN v21.03[0]. Now, if DHCP and port"},{"line_number":10,"context_line":"security are disabled, then the addresses field of a port should not"},{"line_number":11,"context_line":"include its MAC-IP address pairs. This allows to send traffic to all"},{"line_number":12,"context_line":"ports with an unknown address. Existing tests now match this requirement"},{"line_number":13,"context_line":"too."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[0] http://patchwork.ozlabs.org/project/ovn/list/?series\u003d228135i\u0026state\u003d%2A\u0026archive\u003dboth"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"97981488_21de4311","line":12,"range":{"start_line":11,"start_character":34,"end_line":12,"end_character":30},"updated":"2021-03-23 08:58:02.000000000","message":"I believe this is not accurate.\n\nThe MAC learning capabilities introduced recently in OVN are precisely to avoid sending traffic to all ports with addresses field set to \u0027unknown\u0027. Instead, OVN will avoid flooding by learning which port in the Logical Switch the destination MAC address is connected and sending the traffic only to that port.\n\nPrior to v21.03, the behavior would be to flood all traffic to all the \u0027unknown\u0027 ports with a potential performance hit and unwanted network traffic if the number of such ports is large.","commit_id":"5d7f7c6a3edbc6ee5daee22987edba650f8286a4"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"01f6f1d2fbb5c9af8e652d1de7eca2df997aa750","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MAC learning has been added in OVN v21.03[0]. Now, if DHCP and port"},{"line_number":10,"context_line":"security are disabled, then the addresses field of a port should not"},{"line_number":11,"context_line":"include its MAC-IP address pairs. This allows to send traffic to all"},{"line_number":12,"context_line":"ports with an unknown address. Existing tests now match this requirement"},{"line_number":13,"context_line":"too."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[0] http://patchwork.ozlabs.org/project/ovn/list/?series\u003d228135i\u0026state\u003d%2A\u0026archive\u003dboth"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5bba4600_accf586e","line":12,"range":{"start_line":11,"start_character":34,"end_line":12,"end_character":30},"in_reply_to":"97981488_21de4311","updated":"2021-03-23 10:25:18.000000000","message":"I think you are right here, thanks!","commit_id":"5d7f7c6a3edbc6ee5daee22987edba650f8286a4"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"023e895ad0e3580b23e1084bb5d431599caa22cc","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    import qos as qos_extension"},{"line_number":46,"context_line":"from neutron.scheduler import l3_ovn_scheduler"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ed06acaa_ffd41f8a","side":"PARENT","line":48,"updated":"2020-11-23 10:53:06.000000000","message":"unrelated, it\u0027s best to not remove things to not affect future backports and force unnecessary rebases for other patches","commit_id":"144c70f896405f8d92721ef31148672cb5d72673"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"ec7fe197097c500455e8047589efaa3ebdadae41","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    import qos as qos_extension"},{"line_number":46,"context_line":"from neutron.scheduler import l3_ovn_scheduler"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ce8fbfbe_0c90564d","side":"PARENT","line":48,"in_reply_to":"d0dd8f72_b525d007","updated":"2020-11-23 15:58:57.000000000","message":"no need to be sorry :p","commit_id":"144c70f896405f8d92721ef31148672cb5d72673"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"90ef88637f0efee7f1b6ae92a67647590a1a71b7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    import qos as qos_extension"},{"line_number":46,"context_line":"from neutron.scheduler import l3_ovn_scheduler"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d0dd8f72_b525d007","side":"PARENT","line":48,"in_reply_to":"ed06acaa_ffd41f8a","updated":"2020-11-23 15:04:07.000000000","message":"I\u0027m so sorry!! This is because I used the PDB, then erased the line and not checked with pep8 if everything was fine :(","commit_id":"144c70f896405f8d92721ef31148672cb5d72673"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"1aedbd263ef44e62b313f12d6502d1abfdfef185","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            port_security, new_macs \u003d ("},{"line_number":257,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":258,"context_line":"            addresses \u003d [address]"},{"line_number":259,"context_line":"            addresses.extend(new_macs)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # Only adjust the OVN type if the port is not owned by Neutron"},{"line_number":262,"context_line":"            # DHCP agents."}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_f6d85f80","line":259,"range":{"start_line":258,"start_character":0,"end_line":259,"end_character":38},"updated":"2020-11-20 14:44:09.000000000","message":"What about:\n\nif port_security and (dhcpv4_options or dhcpv6_options):\n    addresses \u003d [address]\n    addresses.extend(new_macs)","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"90ef88637f0efee7f1b6ae92a67647590a1a71b7","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            port_security, new_macs \u003d ("},{"line_number":257,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":258,"context_line":"            addresses \u003d [address]"},{"line_number":259,"context_line":"            addresses.extend(new_macs)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # Only adjust the OVN type if the port is not owned by Neutron"},{"line_number":262,"context_line":"            # DHCP agents."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f064f61_b047c45e","line":259,"range":{"start_line":258,"start_character":0,"end_line":259,"end_character":38},"in_reply_to":"2debee9b_e4e064aa","updated":"2020-11-23 15:04:07.000000000","message":"This would work, but then I\u0027m still not sure this would leave the old L290 since there is now a possibility that addresses is unassigned when it gets to that line and therefore the append line would not make sense. I can do the following if you prefer the change here though:\n\naddresses \u003d []\nif port_security or dhcpv4_options or dhcpv6_options:\n    addresses \u003d [address]\n    addresses.extend(new_macs)","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"ec7fe197097c500455e8047589efaa3ebdadae41","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            port_security, new_macs \u003d ("},{"line_number":257,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":258,"context_line":"            addresses \u003d [address]"},{"line_number":259,"context_line":"            addresses.extend(new_macs)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # Only adjust the OVN type if the port is not owned by Neutron"},{"line_number":262,"context_line":"            # DHCP agents."}],"source_content_type":"text/x-python","patch_set":1,"id":"d88b42ab_afc297c1","line":259,"range":{"start_line":258,"start_character":0,"end_line":259,"end_character":38},"in_reply_to":"3f064f61_b047c45e","updated":"2020-11-23 15:58:57.000000000","message":"Yeah this looks good to me! However, feel free to take any of the approaches.\nThe reason I was suggesting this is that by doing so you avoid populating the addresses field and then overwrite it in your L294.","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"023e895ad0e3580b23e1084bb5d431599caa22cc","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            port_security, new_macs \u003d ("},{"line_number":257,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":258,"context_line":"            addresses \u003d [address]"},{"line_number":259,"context_line":"            addresses.extend(new_macs)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # Only adjust the OVN type if the port is not owned by Neutron"},{"line_number":262,"context_line":"            # DHCP agents."}],"source_content_type":"text/x-python","patch_set":1,"id":"2debee9b_e4e064aa","line":259,"range":{"start_line":258,"start_character":0,"end_line":259,"end_character":38},"in_reply_to":"a4770e1b_8db5495a","updated":"2020-11-23 10:53:06.000000000","message":"Yes, you\u0027re right. What about then:\n\nif port_security or dhcpv4_options or dhcpv6_options:\n    addresses \u003d [address]\n    addresses.extend(new_macs)","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1fb42475e1421a7281578dd6e891e319bddc39c4","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            port_security, new_macs \u003d ("},{"line_number":257,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":258,"context_line":"            addresses \u003d [address]"},{"line_number":259,"context_line":"            addresses.extend(new_macs)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # Only adjust the OVN type if the port is not owned by Neutron"},{"line_number":262,"context_line":"            # DHCP agents."}],"source_content_type":"text/x-python","patch_set":1,"id":"a4770e1b_8db5495a","line":259,"range":{"start_line":258,"start_character":0,"end_line":259,"end_character":38},"in_reply_to":"fffc6b78_f6d85f80","updated":"2020-11-23 10:05:20.000000000","message":"But then the case \"port_security enabled and DHCP disabled\" would not have a MAC IP on the addresses variable, which I think is not the case that the bug talks about (both dhcp and port security_disabled).","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"1aedbd263ef44e62b313f12d6502d1abfdfef185","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                # OVN allows any mac address from a port if \"unknown\""},{"line_number":289,"context_line":"                # is added to the Logical_Switch_Port.addresses column."},{"line_number":290,"context_line":"                # So add it."},{"line_number":291,"context_line":"                if dhcpv4_options or dhcpv6_options:"},{"line_number":292,"context_line":"                    addresses.append(ovn_const.UNKNOWN_ADDR)"},{"line_number":293,"context_line":"                else:"},{"line_number":294,"context_line":"                    addresses \u003d [ovn_const.UNKNOWN_ADDR]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # HA Chassis Group will bind the port to the highest"},{"line_number":297,"context_line":"        # priority Chassis"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_36b5c732","line":294,"range":{"start_line":291,"start_character":0,"end_line":294,"end_character":56},"updated":"2020-11-20 14:44:09.000000000","message":"Another possibility could be to avoid appending the addresses in the first place in L258 and L259. In this case you can leave this block untouched and keep the old L290.\n\nSee above.","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7d4c4481b878526b726bc9bf1c707a95c75eefdd","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            addresses \u003d []"},{"line_number":280,"context_line":"            port_security, new_macs \u003d ("},{"line_number":281,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":282,"context_line":"            if port_security or port_type or dhcpv4_options or dhcpv6_options:"},{"line_number":283,"context_line":"                addresses.append(address)"},{"line_number":284,"context_line":"                addresses.extend(new_macs)"},{"line_number":285,"context_line":"            # The \"unknown\" address should only be set for the normal LSP"}],"source_content_type":"text/x-python","patch_set":5,"id":"57de85f2_1be67f7c","line":282,"updated":"2021-03-19 16:34:00.000000000","message":"I think we should also check if the version of core OVN used does support MAC learning or not and include the addresses if it\u0027s not supported (the behavior prior to this patch).\n\nFrom what I can see in the core OVN patches for that feature, a new table has been introduced with that work [0] (called FBD) so we can check whether its present to know if this version of core OVN supports MAC learning or not.\n\n[0] https://github.com/ovn-org/ovn/blob/0ddb8b2c979c1102d206b4f855eb5fbe1566768e/ovn-sb.ovsschema#L517","commit_id":"7f517ff62a261866c65d1461e5c7128ba555b688"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"415365dec2451552c568a1810b2edbe2e017fa15","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            addresses \u003d []"},{"line_number":280,"context_line":"            port_security, new_macs \u003d ("},{"line_number":281,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":282,"context_line":"            if port_security or port_type or dhcpv4_options or dhcpv6_options:"},{"line_number":283,"context_line":"                addresses.append(address)"},{"line_number":284,"context_line":"                addresses.extend(new_macs)"},{"line_number":285,"context_line":"            # The \"unknown\" address should only be set for the normal LSP"}],"source_content_type":"text/x-python","patch_set":5,"id":"eec8127f_6a01ee03","line":282,"in_reply_to":"57de85f2_1be67f7c","updated":"2021-03-22 12:51:34.000000000","message":"You are right, it\u0027s now changed in the new patch, thanks!!","commit_id":"7f517ff62a261866c65d1461e5c7128ba555b688"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"39dd318f504ae02063ae8908349aceff909adc49","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            addresses \u003d []"},{"line_number":279,"context_line":"            port_security, new_macs \u003d ("},{"line_number":280,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":281,"context_line":"            # TODO(egarciar): OVN supports mac learning from V21.03. This"},{"line_number":282,"context_line":"            # if-else block is stated so as to keep compability with older OVN"},{"line_number":283,"context_line":"            # versions and should be removed in a future."},{"line_number":284,"context_line":"            if self._nb_idl.is_table_present(\u0027FDB\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"13b8dc75_e5ce05bc","line":281,"range":{"start_line":281,"start_character":43,"end_line":281,"end_character":46},"updated":"2021-03-22 14:48:46.000000000","message":"nitnit: MAC","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"39dd318f504ae02063ae8908349aceff909adc49","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            # TODO(egarciar): OVN supports mac learning from V21.03. This"},{"line_number":282,"context_line":"            # if-else block is stated so as to keep compability with older OVN"},{"line_number":283,"context_line":"            # versions and should be removed in a future."},{"line_number":284,"context_line":"            if self._nb_idl.is_table_present(\u0027FDB\u0027):"},{"line_number":285,"context_line":"                if (port_security or port_type or dhcpv4_options or"},{"line_number":286,"context_line":"                        dhcpv6_options):"},{"line_number":287,"context_line":"                    addresses.append(address)"}],"source_content_type":"text/x-python","patch_set":6,"id":"90a54e96_b8122557","line":284,"range":{"start_line":284,"start_character":11,"end_line":284,"end_character":51},"updated":"2021-03-22 14:48:46.000000000","message":"This should use the SB IDL:\nhttps://github.com/ovn-org/ovn/blob/master/ovn-sb.ovsschema#L517\n\nThe FDB table is not present in the NB database","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"d2c6d699716e57c7a02eac5ff92a2d709d3bcd40","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            addresses \u003d []"},{"line_number":279,"context_line":"            port_security, new_macs \u003d ("},{"line_number":280,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":281,"context_line":"            # TODO(egarciar): OVN supports MAC learning from V21.03. This"},{"line_number":282,"context_line":"            # if-else block is stated so as to keep compability with older OVN"},{"line_number":283,"context_line":"            # versions and should be removed in a future."},{"line_number":284,"context_line":"            if self._sb_idl.is_table_present(\u0027FDB\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"77d79949_c700146e","line":281,"range":{"start_line":281,"start_character":61,"end_line":281,"end_character":67},"updated":"2021-03-23 08:58:02.000000000","message":"nitnit: v21.03 as it corresponds to the actual git tag","commit_id":"5d7f7c6a3edbc6ee5daee22987edba650f8286a4"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"d2c6d699716e57c7a02eac5ff92a2d709d3bcd40","unresolved":true,"context_lines":[{"line_number":280,"context_line":"                self._get_allowed_addresses_from_port(port))"},{"line_number":281,"context_line":"            # TODO(egarciar): OVN supports MAC learning from V21.03. This"},{"line_number":282,"context_line":"            # if-else block is stated so as to keep compability with older OVN"},{"line_number":283,"context_line":"            # versions and should be removed in a future."},{"line_number":284,"context_line":"            if self._sb_idl.is_table_present(\u0027FDB\u0027):"},{"line_number":285,"context_line":"                if (port_security or port_type or dhcpv4_options or"},{"line_number":286,"context_line":"                        dhcpv6_options):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f31d5202_6208ccb4","line":283,"range":{"start_line":283,"start_character":45,"end_line":283,"end_character":56},"updated":"2021-03-23 08:58:02.000000000","message":"nit: \u0027in a future release\u0027 or \u0027in the future\u0027?\nJust if you need to respin :)","commit_id":"5d7f7c6a3edbc6ee5daee22987edba650f8286a4"}],"neutron/tests/unit/fake_resources.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"39dd318f504ae02063ae8908349aceff909adc49","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        self.meter_add \u003d mock.Mock()"},{"line_number":153,"context_line":"        self.meter_del \u003d mock.Mock()"},{"line_number":154,"context_line":"        self.is_table_present \u003d mock.Mock()"},{"line_number":155,"context_line":"        self.is_table_present.return_value \u003d True"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class FakeOvsdbSbOvnIdl(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9254747b_ad9831e9","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":49},"updated":"2021-03-22 14:48:46.000000000","message":"Isn\u0027t this testing just one path of the code and affecting all tests?","commit_id":"fa061fd2f8a293bd04c0b069e43a8d6de4791e5b"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"fcc3347b80519c42614fc3ee59f36900b2fb7d71","unresolved":true,"context_lines":[{"line_number":60,"context_line":"from neutron.tests.unit.plugins.ml2 import test_plugin"},{"line_number":61,"context_line":"from neutron.tests.unit.plugins.ml2 import test_security_group"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"OVN_PROFILE \u003d ovn_const.OVN_PORT_BINDING_PROFILE"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e71fa7d5_eb68c015","side":"PARENT","line":63,"updated":"2020-11-23 11:36:51.000000000","message":"was this change intentional? I cannot tell from the new gerrit if this is removing a line or removing a white space. If I remember corectly (iirc), we need 2 blank lines to make pep8 happy.","commit_id":"144c70f896405f8d92721ef31148672cb5d72673"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"90ef88637f0efee7f1b6ae92a67647590a1a71b7","unresolved":true,"context_lines":[{"line_number":60,"context_line":"from neutron.tests.unit.plugins.ml2 import test_plugin"},{"line_number":61,"context_line":"from neutron.tests.unit.plugins.ml2 import test_security_group"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"OVN_PROFILE \u003d ovn_const.OVN_PORT_BINDING_PROFILE"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa7e691_b57e92ff","side":"PARENT","line":63,"in_reply_to":"e71fa7d5_eb68c015","updated":"2020-11-23 15:04:07.000000000","message":"No it wasn\u0027t. I will fix it asap \u003d)","commit_id":"144c70f896405f8d92721ef31148672cb5d72673"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"fcc3347b80519c42614fc3ee59f36900b2fb7d71","unresolved":true,"context_lines":[{"line_number":540,"context_line":"                    self.assertEqual([],"},{"line_number":541,"context_line":"                                     called_args_dict.get(\u0027port_security\u0027))"},{"line_number":542,"context_line":"                    self.assertEqual(ovn_const.UNKNOWN_ADDR,"},{"line_number":543,"context_line":"                                     called_args_dict.get(\u0027addresses\u0027)[-1])"},{"line_number":544,"context_line":"                    data \u003d {\u0027port\u0027: {\u0027mac_address\u0027: \u002700:00:00:00:00:01\u0027}}"},{"line_number":545,"context_line":"                    req \u003d self.new_update_request("},{"line_number":546,"context_line":"                        \u0027ports\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3ff4841_7d5f0a16","line":543,"range":{"start_line":543,"start_character":71,"end_line":543,"end_character":73},"updated":"2020-11-23 11:36:51.000000000","message":"nit: I would be specific on the number of elements, since this is a unit test and we should have tight control of what should be in addresses.","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"90ef88637f0efee7f1b6ae92a67647590a1a71b7","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                    self.assertEqual([],"},{"line_number":541,"context_line":"                                     called_args_dict.get(\u0027port_security\u0027))"},{"line_number":542,"context_line":"                    self.assertEqual(ovn_const.UNKNOWN_ADDR,"},{"line_number":543,"context_line":"                                     called_args_dict.get(\u0027addresses\u0027)[-1])"},{"line_number":544,"context_line":"                    data \u003d {\u0027port\u0027: {\u0027mac_address\u0027: \u002700:00:00:00:00:01\u0027}}"},{"line_number":545,"context_line":"                    req \u003d self.new_update_request("},{"line_number":546,"context_line":"                        \u0027ports\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7bd20710_59b974fb","line":543,"range":{"start_line":543,"start_character":71,"end_line":543,"end_character":73},"in_reply_to":"b3ff4841_7d5f0a16","updated":"2020-11-23 15:04:07.000000000","message":"Ack","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"fcc3347b80519c42614fc3ee59f36900b2fb7d71","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                                     called_args_dict.get(\u0027port_security\u0027))"},{"line_number":555,"context_line":"                    self.assertEqual(1, len(called_args_dict.get(\u0027addresses\u0027)))"},{"line_number":556,"context_line":"                    self.assertEqual(ovn_const.UNKNOWN_ADDR,"},{"line_number":557,"context_line":"                                     called_args_dict.get(\u0027addresses\u0027)[-1])"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"                    # Enable port security"},{"line_number":560,"context_line":"                    data \u003d {\u0027port\u0027: {\u0027port_security_enabled\u0027: \u0027True\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb667dce_868d46f1","line":557,"range":{"start_line":557,"start_character":71,"end_line":557,"end_character":73},"updated":"2020-11-23 11:36:51.000000000","message":"nit: if length is 1, then we can use [0] instead of [-1], yes?","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"90ef88637f0efee7f1b6ae92a67647590a1a71b7","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                                     called_args_dict.get(\u0027port_security\u0027))"},{"line_number":555,"context_line":"                    self.assertEqual(1, len(called_args_dict.get(\u0027addresses\u0027)))"},{"line_number":556,"context_line":"                    self.assertEqual(ovn_const.UNKNOWN_ADDR,"},{"line_number":557,"context_line":"                                     called_args_dict.get(\u0027addresses\u0027)[-1])"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"                    # Enable port security"},{"line_number":560,"context_line":"                    data \u003d {\u0027port\u0027: {\u0027port_security_enabled\u0027: \u0027True\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae13566_fefb6c90","line":557,"range":{"start_line":557,"start_character":71,"end_line":557,"end_character":73},"in_reply_to":"fb667dce_868d46f1","updated":"2020-11-23 15:04:07.000000000","message":"Ack","commit_id":"e8c3dec17f291016610106526f5f6afe452a0259"}]}