)]}'
{"neutron/plugins/ml2/driver_context.py":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"141631973a32f4a6c891a2eba072ba8388139073","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self._binding \u003d db.ensure_port_binding(plugin_context.session,"},{"line_number":80,"context_line":"                                               port[\u0027id\u0027])"},{"line_number":81,"context_line":"        if original_port:"},{"line_number":82,"context_line":"            self._original_bound_segment \u003d self._binding.segment"},{"line_number":83,"context_line":"            self._original_bound_driver \u003d self._binding.driver"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            self._original_bound_segment \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fj0Q%3D","line":82,"updated":"2014-02-25 22:56:42.000000000","message":"Consider changing this to _original_bound_segment_id.","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"69b4c336ad2a268b677bf11656496e210c9fe521","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self._binding \u003d db.ensure_port_binding(plugin_context.session,"},{"line_number":80,"context_line":"                                               port[\u0027id\u0027])"},{"line_number":81,"context_line":"        if original_port:"},{"line_number":82,"context_line":"            self._original_bound_segment \u003d self._binding.segment"},{"line_number":83,"context_line":"            self._original_bound_driver \u003d self._binding.driver"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            self._original_bound_segment \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FdqE%3D","line":82,"in_reply_to":"AAAAU3%2F%2Fj0Q%3D","updated":"2014-02-26 15:57:00.000000000","message":"Done","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"141631973a32f4a6c891a2eba072ba8388139073","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                if segment[api.ID] \u003d\u003d id:"},{"line_number":106,"context_line":"                    return segment"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @property"},{"line_number":109,"context_line":"    def original_bound_segment(self):"},{"line_number":110,"context_line":"        if self._original_bound_segment:"},{"line_number":111,"context_line":"            for segment in self._network_context.network_segments:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FjzM%3D","line":108,"updated":"2014-02-25 22:56:42.000000000","message":"This original information will not be available to the delete_port_pre/postcommit() methods, correct?","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"69b4c336ad2a268b677bf11656496e210c9fe521","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                if segment[api.ID] \u003d\u003d id:"},{"line_number":106,"context_line":"                    return segment"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @property"},{"line_number":109,"context_line":"    def original_bound_segment(self):"},{"line_number":110,"context_line":"        if self._original_bound_segment:"},{"line_number":111,"context_line":"            for segment in self._network_context.network_segments:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fdn0%3D","line":108,"in_reply_to":"AAAAU3%2F%2FjzM%3D","updated":"2014-02-26 15:57:00.000000000","message":"Right. That\u0027s why the commit message says this partially resolves bug 1276395. The remainder will be addressed in a separate patch for bug 1276391 that changes the rearranges the code to move the bind_port() call outside transactions.","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"}],"neutron/tests/unit/ml2/drivers/mechanism_test.py":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"141631973a32f4a6c891a2eba072ba8388139073","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # REVISIT(rkukura): Currently, bind_port() is called as part"},{"line_number":139,"context_line":"        # of either a create or update transaction. The fix for bug"},{"line_number":140,"context_line":"        # 1276391 will change it to be called outside any transaction,"},{"line_number":141,"context_line":"        # so the context.original* will no longer be available."},{"line_number":142,"context_line":"        self._check_port_context(context, context.original is not None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        host \u003d context.current.get(portbindings.HOST_ID, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fj5A%3D","line":141,"updated":"2014-02-25 22:56:42.000000000","message":"The context.original* information is only available in the update_port_pre/postcommit() methods, correct?\nIf yes then you might want to change the last sentence to make that clear. Here and in the comments below.","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"69b4c336ad2a268b677bf11656496e210c9fe521","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # REVISIT(rkukura): Currently, bind_port() is called as part"},{"line_number":139,"context_line":"        # of either a create or update transaction. The fix for bug"},{"line_number":140,"context_line":"        # 1276391 will change it to be called outside any transaction,"},{"line_number":141,"context_line":"        # so the context.original* will no longer be available."},{"line_number":142,"context_line":"        self._check_port_context(context, context.original is not None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        host \u003d context.current.get(portbindings.HOST_ID, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FdjY%3D","line":141,"in_reply_to":"AAAAU3%2F%2Fj5A%3D","updated":"2014-02-26 15:57:00.000000000","message":"Actually the context.original* information is available in bind_port(), validate_port_binding() and unbind_port() right now when these are called as part of an update operation. Its not available when they are called as part of a create or delete operation. With the fix for 1276391, it will never be available to these calls.","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"}],"neutron/tests/unit/ml2/test_port_binding.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"d75f47e6d7c42e7a1fcd1d44869d12283053cee5","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_update_with_new_host_binding_notifies_agent(self):"},{"line_number":111,"context_line":"        self._test_update_port_binding(\u0027host-ovs-no_filter\u0027,"},{"line_number":112,"context_line":"                                       \u0027host-bridge-no-filter\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_update_with_same_host_binding_does_not_notify(self):"},{"line_number":115,"context_line":"        self._test_update_port_binding(\u0027host-ovs-no_filter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FkUg%3D","line":112,"updated":"2014-02-25 21:49:27.000000000","message":"Not sure what is the relevance of this change to other changes.\nWhy change is applied for string containing ovs only? Seems that line 112 should follow the same format.","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"69b4c336ad2a268b677bf11656496e210c9fe521","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_update_with_new_host_binding_notifies_agent(self):"},{"line_number":111,"context_line":"        self._test_update_port_binding(\u0027host-ovs-no_filter\u0027,"},{"line_number":112,"context_line":"                                       \u0027host-bridge-no-filter\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_update_with_same_host_binding_does_not_notify(self):"},{"line_number":115,"context_line":"        self._test_update_port_binding(\u0027host-ovs-no_filter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fcbw%3D","line":112,"in_reply_to":"AAAAU3%2F%2FkUg%3D","updated":"2014-02-26 15:57:00.000000000","message":"Good catch. I\u0027ve fixed it to use only the two host_id values defined in the test mechanism driver.","commit_id":"be5f97c8735defe610658e7e432c9a486e966af2"}]}