)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3d55afec9ea5481754c17e39c7a0926e9679caee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests/unit: refactor reading neutron.conf.tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron.conf.tests includes rpc_backend whose value notification stashes."},{"line_number":10,"context_line":"Thus it is required to reset when tearing down, otherwise the stale status"},{"line_number":11,"context_line":"will be used by succeeding tests causing random error."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAU3%2F%2Fhks%3D","line":9,"updated":"2014-02-26 05:35:51.000000000","message":"neutron.conf.test (without s)?","commit_id":"2d3238a42758a5f245a8f30c450418d3c5178c38"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a58a1e295a6c570f80607addc6fe6660e06ef87d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron.conf.tests includes rpc_backend whose value notification stashes."},{"line_number":10,"context_line":"Thus it is required to reset when tearing down, otherwise the stale status"},{"line_number":11,"context_line":"will be used by succeeding tests causing random error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch refactors reading neutron.conf.tests and resets the status of"},{"line_number":14,"context_line":"notification driver properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAU3%2F%2FhUc%3D","line":11,"updated":"2014-02-26 06:04:35.000000000","message":"test_notifier does not seem to be affected by rpc_backend.\nare rpc_notifier variants used during tests?","commit_id":"2d3238a42758a5f245a8f30c450418d3c5178c38"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b007527f17d8cab18ecfd1f4d1b7c64fffd5598d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron.conf.tests includes rpc_backend whose value notification stashes."},{"line_number":10,"context_line":"Thus it is required to reset when tearing down, otherwise the stale status"},{"line_number":11,"context_line":"will be used by succeeding tests causing random error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch refactors reading neutron.conf.tests and resets the status of"},{"line_number":14,"context_line":"notification driver properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2FnEg%3D","line":11,"in_reply_to":"AAAAU3%2F%2FhUc%3D","updated":"2014-03-05 03:07:19.000000000","message":"Ah, you\u0027re right.\nIt is rpc_driver and impl_fake that should be reset.\nwill respin","commit_id":"2d3238a42758a5f245a8f30c450418d3c5178c38"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"707ae870af5df55df1edf1622b0bf39a8af337ac","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron.conf.tests includes rpc_backend whose value notification stashes."},{"line_number":10,"context_line":"Thus it is required to reset when tearing down, otherwise the stale status"},{"line_number":11,"context_line":"will be used by succeeding tests causing random error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch refactors reading neutron.conf.tests and resets the status of"},{"line_number":14,"context_line":"notification driver properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2Fm9k%3D","line":11,"in_reply_to":"AAAAVn%2F%2FnEg%3D","updated":"2014-03-05 03:24:39.000000000","message":"yea.\nthe use of the term notification/notify in neutron is confusing.\n\nmy understanding is that we need to reset rpc_driver for bug 1284549 and fake_impl for bug 1281481.","commit_id":"2d3238a42758a5f245a8f30c450418d3c5178c38"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"87ae589eda15b672824a407490baefe391f902d6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch refactors reading neutron.conf.test and resets the status of"},{"line_number":14,"context_line":"rpc_backend properly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-Bug: #1281481"},{"line_number":17,"context_line":"Closes-Bug: #1284549"},{"line_number":18,"context_line":"Change-Id: I0fa5945b6adbb9945d353028ec88d00ccbf4e31a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2Fmgk%3D","line":16,"updated":"2014-03-05 05:13:37.000000000","message":"Closes-Bug ?","commit_id":"96dc48056660c74f81a9e2907ca59d54993bce0d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b3f8c532697da7f7436e31167245758ef8cddbe2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch refactors reading neutron.conf.test and resets the status of"},{"line_number":14,"context_line":"rpc_backend properly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-Bug: #1281481"},{"line_number":17,"context_line":"Closes-Bug: #1284549"},{"line_number":18,"context_line":"Change-Id: I0fa5945b6adbb9945d353028ec88d00ccbf4e31a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2FmZU%3D","line":16,"in_reply_to":"AAAAVn%2F%2Fmgk%3D","updated":"2014-03-05 05:21:16.000000000","message":"Done","commit_id":"96dc48056660c74f81a9e2907ca59d54993bce0d"}],"neutron/tests/base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3d55afec9ea5481754c17e39c7a0926e9679caee","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def config_parse(self, conf\u003dNone, args\u003dNone):"},{"line_number":87,"context_line":"        \"\"\"Create the default configurations.\"\"\""},{"line_number":88,"context_line":"        # neutron.conf.tests includes rpc_backend which needs to be cleaned up"},{"line_number":89,"context_line":"        config_parse(conf, args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FhlM%3D","line":88,"updated":"2014-02-26 05:35:51.000000000","message":"neutron.conf.test (without s)?","commit_id":"2d3238a42758a5f245a8f30c450418d3c5178c38"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"87ae589eda15b672824a407490baefe391f902d6","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def config_parse(conf\u003dNone, args\u003dNone):"},{"line_number":57,"context_line":"    notifier_api._reset_drivers()"},{"line_number":58,"context_line":"    if args is None:"},{"line_number":59,"context_line":"        args \u003d [\u0027--config-file\u0027, etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":60,"context_line":"    if conf is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FmeQ%3D","line":57,"updated":"2014-03-05 05:13:37.000000000","message":"why here?\nit seems like a wrong place to reset this as neutron.conf.test has rpc_backend, not notification_driver.\nwhat your setup_notification_driver do should be enough.","commit_id":"96dc48056660c74f81a9e2907ca59d54993bce0d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b3f8c532697da7f7436e31167245758ef8cddbe2","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def config_parse(conf\u003dNone, args\u003dNone):"},{"line_number":57,"context_line":"    notifier_api._reset_drivers()"},{"line_number":58,"context_line":"    if args is None:"},{"line_number":59,"context_line":"        args \u003d [\u0027--config-file\u0027, etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":60,"context_line":"    if conf is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FmaM%3D","line":57,"in_reply_to":"AAAAVn%2F%2FmeQ%3D","updated":"2014-03-05 05:21:16.000000000","message":"Done","commit_id":"96dc48056660c74f81a9e2907ca59d54993bce0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"87ae589eda15b672824a407490baefe391f902d6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def _cleanup_rpc_backend(self):"},{"line_number":96,"context_line":"        rpc._RPCIMPL \u003d None"},{"line_number":97,"context_line":"        impl_fake.CONSUMERS.clear()"},{"line_number":98,"context_line":"        impl_zmq.cleanup()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        super(BaseTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fmhs%3D","line":98,"updated":"2014-03-05 05:13:37.000000000","message":"is there tests using impl_zmq?","commit_id":"96dc48056660c74f81a9e2907ca59d54993bce0d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b3f8c532697da7f7436e31167245758ef8cddbe2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def _cleanup_rpc_backend(self):"},{"line_number":96,"context_line":"        rpc._RPCIMPL \u003d None"},{"line_number":97,"context_line":"        impl_fake.CONSUMERS.clear()"},{"line_number":98,"context_line":"        impl_zmq.cleanup()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        super(BaseTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FmZ8%3D","line":98,"in_reply_to":"AAAAVn%2F%2Fmhs%3D","updated":"2014-03-05 05:21:16.000000000","message":"Done","commit_id":"96dc48056660c74f81a9e2907ca59d54993bce0d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ba19878aa0ab9821ec9d3c91385c7c386f48ae88","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def config_parse(conf\u003dNone, args\u003dNone):"},{"line_number":60,"context_line":"    if args is None:"},{"line_number":61,"context_line":"        args \u003d [\u0027--config-file\u0027, etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":62,"context_line":"    if conf is None:"},{"line_number":63,"context_line":"        config.parse(args\u003dargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_654db072","line":60,"updated":"2014-04-30 14:10:02.000000000","message":"nit: args \u003d args or [\u0027--config-file\u0027, etcdir(\u0027neutron.conf.test\u0027)]","commit_id":"adbacc7c2dc43575ff5c3cb34814fab190f7b292"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8251c5d1a0c38357e0aacc1dd151d85e91111641","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def config_parse(conf\u003dNone, args\u003dNone):"},{"line_number":60,"context_line":"    if args is None:"},{"line_number":61,"context_line":"        args \u003d [\u0027--config-file\u0027, etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":62,"context_line":"    if conf is None:"},{"line_number":63,"context_line":"        config.parse(args\u003dargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_3ef8097c","line":60,"in_reply_to":"9ad9bd40_654db072","updated":"2014-04-30 22:29:25.000000000","message":"arcs\u003d[] should be treated distinctly","commit_id":"adbacc7c2dc43575ff5c3cb34814fab190f7b292"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ba19878aa0ab9821ec9d3c91385c7c386f48ae88","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def config_parse(self, conf\u003dNone, args\u003dNone):"},{"line_number":99,"context_line":"        \"\"\"Create the default configurations.\"\"\""},{"line_number":100,"context_line":"        # neutron.conf.test includes rpc_backend which needs to be cleaned up"},{"line_number":101,"context_line":"        config_parse(conf, args)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _cleanup_rpc_backend(self):"},{"line_number":104,"context_line":"        rpc._RPCIMPL \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_252f28a3","line":101,"updated":"2014-04-30 14:10:02.000000000","message":"Is there a reason why this function is called and not implemented at this place?","commit_id":"adbacc7c2dc43575ff5c3cb34814fab190f7b292"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8251c5d1a0c38357e0aacc1dd151d85e91111641","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def config_parse(self, conf\u003dNone, args\u003dNone):"},{"line_number":99,"context_line":"        \"\"\"Create the default configurations.\"\"\""},{"line_number":100,"context_line":"        # neutron.conf.test includes rpc_backend which needs to be cleaned up"},{"line_number":101,"context_line":"        config_parse(conf, args)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _cleanup_rpc_backend(self):"},{"line_number":104,"context_line":"        rpc._RPCIMPL \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_be2b39ea","line":101,"in_reply_to":"9ad9bd40_252f28a3","updated":"2014-04-30 22:29:25.000000000","message":"Done","commit_id":"adbacc7c2dc43575ff5c3cb34814fab190f7b292"}]}