)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"399d6173d1a2555ee16c18fc2df8263240ef428e","unresolved":true,"context_lines":[{"line_number":372,"context_line":"            remote, schema, probe_interval\u003dprobe_interval, **kwargs)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"class BaseOvnIdl(Ml2OvnIdlBase):"},{"line_number":376,"context_line":"    def __init__(self, remote, schema):"},{"line_number":377,"context_line":"        self.notify_handler \u003d event.RowEventHandler()"},{"line_number":378,"context_line":"        super(BaseOvnIdl, self).__init__(remote, schema)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e733623_a40c7f87","line":375,"updated":"2020-11-27 08:50:18.000000000","message":"this naming seems a bit odd for me. Ml2Something class is parent of BaseSomething class. Shouldn\u0027t it be in the opposite way maybe?","commit_id":"5783e952887b2fe5e8aaa32b3077e8dcdefa7252"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7054e5a4db4eeae9ba98ba2f1d2810c139bb9452","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            remote, schema, probe_interval\u003dprobe_interval, **kwargs)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"class BaseOvnIdl(Ml2OvnIdlBase):"},{"line_number":376,"context_line":"    def __init__(self, remote, schema):"},{"line_number":377,"context_line":"        self.notify_handler \u003d event.RowEventHandler()"},{"line_number":378,"context_line":"        super(BaseOvnIdl, self).__init__(remote, schema)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8e403eea_20beca0f","line":375,"in_reply_to":"0f7a6290_fd7200a8","updated":"2020-12-04 17:42:53.000000000","message":"Marking resolved since you +2\u0027d. I\u0027ll see about doing a good renaming patch for some of this OVN stuff...","commit_id":"5783e952887b2fe5e8aaa32b3077e8dcdefa7252"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f86cec8aab261cc4164e77627c6e780fb64643c2","unresolved":true,"context_lines":[{"line_number":372,"context_line":"            remote, schema, probe_interval\u003dprobe_interval, **kwargs)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"class BaseOvnIdl(Ml2OvnIdlBase):"},{"line_number":376,"context_line":"    def __init__(self, remote, schema):"},{"line_number":377,"context_line":"        self.notify_handler \u003d event.RowEventHandler()"},{"line_number":378,"context_line":"        super(BaseOvnIdl, self).__init__(remote, schema)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f7a6290_fd7200a8","line":375,"in_reply_to":"7e733623_a40c7f87","updated":"2020-11-30 13:57:50.000000000","message":"BaseOvnIdl *used* to be the Base for everything. Then it looks like BaseOvnSbIdl didn\u0027t use it. Now we need something that is a base of everything, including BaseOvnSbIdl, so Ml2OvnIdlBase...yeah, the naming is now bad, but it isn\u0027t *this* patch\u0027s fault. :) And I didn\u0027t want to obscure things by making an un-related name change. There is so much that I would rename here and in ovsdbapp to make things more clear. There\u0027s always backporting issues with name changes though.","commit_id":"5783e952887b2fe5e8aaa32b3077e8dcdefa7252"}]}