)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e5e9df8dd0480a9fca5a4721eea238c1c451cf71","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is adding IGMP querier support in the OVN driver."},{"line_number":10,"context_line":"IGMP querier is working only when IGMP snooping is enable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/762818"},{"line_number":13,"context_line":"Change-Id: I0b9e1c0b7cf467c6c507102cd1fae72b68be90cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ed6e1b23_4616d1d2","line":11,"updated":"2021-01-07 14:07:43.000000000","message":"Is there a LP bug?","commit_id":"87042b784b1460b56028e8d179f5a970776f6c12"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b7358d6949e16516d347eab39792303a14f38293","unresolved":true,"context_lines":[{"line_number":555,"context_line":"    def check_for_igmp_snoop_support(self):"},{"line_number":556,"context_line":"        if not self.has_lock:"},{"line_number":557,"context_line":"            return"},{"line_number":558,"context_line":"        mcast_eth, mcast_ip \u003d \u0027\u0027, \u0027\u0027"},{"line_number":559,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":560,"context_line":"            value \u003d (\u0027true\u0027 if ovn_conf.is_igmp_snooping_enabled()"},{"line_number":561,"context_line":"                     else \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"aabd1111_6a9e7880","line":558,"range":{"start_line":558,"start_character":8,"end_line":558,"end_character":36},"updated":"2020-11-27 10:23:00.000000000","message":"If you want to use this as a default value, shouldn\u0027t you move it down to L565? Otherwise seems that you will be adding \u0027mcast_eth\u0027 and \u0027mcast_ip\u0027 values from a previous LS if the current LS doesn\u0027t have ports.","commit_id":"ae65c4fbc99455f6812c559966b4d0dfec007149"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"29e9d37001df891f1ef348f8a6192d6963254031","unresolved":false,"context_lines":[{"line_number":555,"context_line":"    def check_for_igmp_snoop_support(self):"},{"line_number":556,"context_line":"        if not self.has_lock:"},{"line_number":557,"context_line":"            return"},{"line_number":558,"context_line":"        mcast_eth, mcast_ip \u003d \u0027\u0027, \u0027\u0027"},{"line_number":559,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":560,"context_line":"            value \u003d (\u0027true\u0027 if ovn_conf.is_igmp_snooping_enabled()"},{"line_number":561,"context_line":"                     else \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"77b8a3e7_77425ddc","line":558,"range":{"start_line":558,"start_character":8,"end_line":558,"end_character":36},"in_reply_to":"aabd1111_6a9e7880","updated":"2021-01-07 13:09:26.000000000","message":"Done","commit_id":"ae65c4fbc99455f6812c559966b4d0dfec007149"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e5e9df8dd0480a9fca5a4721eea238c1c451cf71","unresolved":true,"context_lines":[{"line_number":555,"context_line":"    def check_for_igmp_snoop_support(self):"},{"line_number":556,"context_line":"        if not self.has_lock:"},{"line_number":557,"context_line":"            return"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":560,"context_line":"            value \u003d (\u0027true\u0027 if ovn_conf.is_igmp_snooping_enabled()"},{"line_number":561,"context_line":"                     else \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d8dbab6_7f1cf296","side":"PARENT","line":558,"range":{"start_line":558,"start_character":0,"end_line":558,"end_character":0},"updated":"2021-01-07 14:07:43.000000000","message":"nit: not related","commit_id":"495fcd81ec120c6d494b7d4933dece6322d4eb83"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e5e9df8dd0480a9fca5a4721eea238c1c451cf71","unresolved":true,"context_lines":[{"line_number":566,"context_line":"                for lsp in ls.ports:"},{"line_number":567,"context_line":"                    if lsp.type !\u003d ovn_const.LSP_TYPE_LOCALPORT:"},{"line_number":568,"context_line":"                        continue"},{"line_number":569,"context_line":"                    mcast_eth, mcast_ip \u003d lsp.addresses[0].split()"},{"line_number":570,"context_line":"                txn.add(self._nb_idl.db_set("},{"line_number":571,"context_line":"                    \u0027Logical_Switch\u0027, ls.name,"},{"line_number":572,"context_line":"                    (\u0027other_config\u0027, {"}],"source_content_type":"text/x-python","patch_set":5,"id":"b2c7f425_8f1f3fb2","line":569,"updated":"2021-01-07 14:07:43.000000000","message":"1) Why do you iterate over the list of LS ports? You should need only one IP/MAC\n2) What MAC/IP should you add here? Shouldn\u0027t be an MAC/IP other than any of those LS ports?","commit_id":"87042b784b1460b56028e8d179f5a970776f6c12"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e5e9df8dd0480a9fca5a4721eea238c1c451cf71","unresolved":true,"context_lines":[{"line_number":1589,"context_line":"                params[\u0027other_config\u0027].update({"},{"line_number":1590,"context_line":"                    ovn_const.MCAST_ETH_SRC: mcast_eth,"},{"line_number":1591,"context_line":"                    ovn_const.MCAST_IP_SRC: mcast_ip"},{"line_number":1592,"context_line":"                })"},{"line_number":1593,"context_line":"        return params"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"    def create_network(self, context, network):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9e7a7b07_05a1e6ae","line":1592,"updated":"2021-01-07 14:07:43.000000000","message":"Same question here about iterating over the LS ports and rewriting \"other_config\" each time.","commit_id":"87042b784b1460b56028e8d179f5a970776f6c12"}]}