)]}'
{"neutron/conf/policies/agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f1b046a8da865373758d8fdddebad429059e706","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEPRECATION_REASON \u003d \"\"\""},{"line_number":22,"context_line":"The Agent API now supports system scope and default roles."},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deprecated_get_agent_rule \u003d policy.DeprecatedRule("},{"line_number":26,"context_line":"    name\u003d\u0027get_agent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"de6df417_e185dad0","line":23,"updated":"2020-11-30 14:32:13.000000000","message":"just a question: do we need to use triple-quote here? I think a normal string with a single double-quote is enough.","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ea132474e84dd802ead130d6135c3f2908bcf4e7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEPRECATION_REASON \u003d \"\"\""},{"line_number":22,"context_line":"The Agent API now supports system scope and default roles."},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deprecated_get_agent_rule \u003d policy.DeprecatedRule("},{"line_number":26,"context_line":"    name\u003d\u0027get_agent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6abb6fa3_1f1cf792","line":23,"in_reply_to":"de6df417_e185dad0","updated":"2020-12-02 08:26:31.000000000","message":"Done","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0a1534ca8950728e4b4baac06734c22db192c4b4","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    name\u003d\u0027delete_agent\u0027,"},{"line_number":33,"context_line":"    check_str\u003dbase.RULE_ADMIN_ONLY)"},{"line_number":34,"context_line":"deprecated_create_dhcp_network_rule \u003d policy.DeprecatedRule("},{"line_number":35,"context_line":"    name\u003d\u0027create_dhcp-networ\u0027,"},{"line_number":36,"context_line":"    check_str\u003dbase.RULE_ADMIN_ONLY)"},{"line_number":37,"context_line":"deprecated_get_dhcp_networks_rule \u003d policy.DeprecatedRule("},{"line_number":38,"context_line":"    name\u003d\u0027get_dhcp-networs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4aab9777_4da7d9bf","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":28},"updated":"2020-11-30 15:14:48.000000000","message":"s/networks\n\ntypo below as well","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f1b046a8da865373758d8fdddebad429059e706","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            },"},{"line_number":73,"context_line":"        ],"},{"line_number":74,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":75,"context_line":"        deprecated_rule\u003ddeprecated_get_agent_rule,"},{"line_number":76,"context_line":"        deprecated_reason\u003dDEPRECATION_REASON,"},{"line_number":77,"context_line":"        deprecated_since\u003d\u0027Wallaby\u0027"},{"line_number":78,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"6f5316aa_6f3aca10","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":49},"updated":"2020-11-30 14:32:13.000000000","message":"Deprecated rules are defined one by one.\nHow about defining deprecated rules inline?\nI think it may be easier to read and review it (as we don\u0027t need to scroll lines a lot).\n\n  deprecated_rule\u003dpolicy.DeprecatedRule(\n    name\u003d\u0027get_agent\u0027,\n    check_str\u003dbase.RULE_ADMIN_ONLY),\n\nThis is the first migration patch, so I am raising a dumb question.\n\nThought?","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ea132474e84dd802ead130d6135c3f2908bcf4e7","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            },"},{"line_number":73,"context_line":"        ],"},{"line_number":74,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":75,"context_line":"        deprecated_rule\u003ddeprecated_get_agent_rule,"},{"line_number":76,"context_line":"        deprecated_reason\u003dDEPRECATION_REASON,"},{"line_number":77,"context_line":"        deprecated_since\u003d\u0027Wallaby\u0027"},{"line_number":78,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"36ef20d8_a1a4912d","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":49},"in_reply_to":"6f5316aa_6f3aca10","updated":"2020-12-02 08:26:31.000000000","message":"Good idea. Done.","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f1b046a8da865373758d8fdddebad429059e706","unresolved":true,"context_lines":[{"line_number":213,"context_line":"    ),"},{"line_number":214,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":215,"context_line":"        name\u003d\u0027get_l3-agents\u0027,"},{"line_number":216,"context_line":"        check_str\u003dbase.RULE_ADMIN_ONLY,"},{"line_number":217,"context_line":"        description\u003d\u0027List L3 agents hosting a router\u0027,"},{"line_number":218,"context_line":"        operations\u003d["},{"line_number":219,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"2b1442f3_7df67a15","line":216,"range":{"start_line":216,"start_character":23,"end_line":216,"end_character":38},"updated":"2020-11-30 14:32:13.000000000","message":"-\u003e SYSTEM_READER","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2760a661aecf249335e21e96ae144a8bd1a87a08","unresolved":true,"context_lines":[{"line_number":213,"context_line":"    ),"},{"line_number":214,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":215,"context_line":"        name\u003d\u0027get_l3-agents\u0027,"},{"line_number":216,"context_line":"        check_str\u003dbase.RULE_ADMIN_ONLY,"},{"line_number":217,"context_line":"        description\u003d\u0027List L3 agents hosting a router\u0027,"},{"line_number":218,"context_line":"        operations\u003d["},{"line_number":219,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb97a603_91f331d7","line":216,"range":{"start_line":216,"start_character":23,"end_line":216,"end_character":38},"in_reply_to":"2b1442f3_7df67a15","updated":"2020-11-30 15:28:44.000000000","message":"+1","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ea132474e84dd802ead130d6135c3f2908bcf4e7","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    ),"},{"line_number":214,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":215,"context_line":"        name\u003d\u0027get_l3-agents\u0027,"},{"line_number":216,"context_line":"        check_str\u003dbase.RULE_ADMIN_ONLY,"},{"line_number":217,"context_line":"        description\u003d\u0027List L3 agents hosting a router\u0027,"},{"line_number":218,"context_line":"        operations\u003d["},{"line_number":219,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"db277fac_ad4568cc","line":216,"range":{"start_line":216,"start_character":23,"end_line":216,"end_character":38},"in_reply_to":"cb97a603_91f331d7","updated":"2020-12-02 08:26:31.000000000","message":"Done","commit_id":"992e39a19ed3d350fe20acc8accc86137581c5f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7fcdf7344cfffb5417faea93ff94212891af52fc","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            name\u003d\u0027get_agent\u0027,"},{"line_number":42,"context_line":"            check_str\u003dbase.RULE_ADMIN_ONLY),"},{"line_number":43,"context_line":"        deprecated_reason\u003dDEPRECATION_REASON,"},{"line_number":44,"context_line":"        deprecated_since\u003d\u0027Wallaby\u0027"},{"line_number":45,"context_line":"    ),"},{"line_number":46,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":47,"context_line":"        name\u003d\u0027update_agent\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ed955db6_c498cf6a","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":34},"updated":"2020-12-16 06:18:18.000000000","message":"saw versionutils.deprecated.WALLABY in other patches","commit_id":"bd79f1405234c8ee8f399054509ce63e6d4fd8f7"}]}