)]}'
{"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee5c4c87940dde24c9935948b5cd7bf22dacd87d","unresolved":true,"context_lines":[{"line_number":689,"context_line":"    def _set_router_states(cls, context, bindings, states):"},{"line_number":690,"context_line":"        for binding in bindings:"},{"line_number":691,"context_line":"            try:"},{"line_number":692,"context_line":"                with db_api.CONTEXT_WRITER.using(context):"},{"line_number":693,"context_line":"                    binding.state \u003d states[binding.router_id]"},{"line_number":694,"context_line":"            except (orm.exc.StaleDataError, orm.exc.ObjectDeletedError):"},{"line_number":695,"context_line":"                # Take concurrently deleted routers in to account"}],"source_content_type":"text/x-python","patch_set":1,"id":"008fee1e_64fe38dd","line":692,"range":{"start_line":692,"start_character":15,"end_line":692,"end_character":58},"updated":"2020-12-01 14:40:40.000000000","message":"I think (I\u0027m not 100% sure yet) that wee need to retrieve the port binding inside the transaction where is modified (here exactly).\n\n\"_set_router_states\" is called by \"update_routers_states\". \"bindings\" is retrieved just before calling this method. I think we should move this retrieval inside this context.","commit_id":"6de6cc73780a003e606aad77132a85dbadcc8492"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"355dd3e5147ba5b82e2b0c5670fe75a8a8028d08","unresolved":true,"context_lines":[{"line_number":700,"context_line":"    def update_routers_states(self, context, states, host):"},{"line_number":701,"context_line":"        \"\"\"Receive dict of router ID to state and update them all.\"\"\""},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":704,"context_line":"            bindings \u003d self.get_ha_router_port_bindings("},{"line_number":705,"context_line":"                context, router_ids\u003dstates.keys(), host\u003dhost)"},{"line_number":706,"context_line":"        self._set_router_states(context, bindings, states)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1cbe738_20cf69a6","line":703,"range":{"start_line":703,"start_character":20,"end_line":703,"end_character":34},"updated":"2020-12-09 07:54:34.000000000","message":"is writer needed for get_ha_router_port_bindings?","commit_id":"f8235cc899522cba48364919128b2846572eac26"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d7e7046afdb1dc43a65c15e3677e81a2c0e3239e","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    def update_routers_states(self, context, states, host):"},{"line_number":701,"context_line":"        \"\"\"Receive dict of router ID to state and update them all.\"\"\""},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        with db_api.CONTEXT_WRITER.using(context):"},{"line_number":704,"context_line":"            bindings \u003d self.get_ha_router_port_bindings("},{"line_number":705,"context_line":"                context, router_ids\u003dstates.keys(), host\u003dhost)"},{"line_number":706,"context_line":"        self._set_router_states(context, bindings, states)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ca4c6271_3796f6bb","line":703,"range":{"start_line":703,"start_character":20,"end_line":703,"end_character":34},"in_reply_to":"e1cbe738_20cf69a6","updated":"2020-12-09 08:33:35.000000000","message":"nope. I just forgot to change it before send patch to gerrit. Thx :)","commit_id":"f8235cc899522cba48364919128b2846572eac26"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"355dd3e5147ba5b82e2b0c5670fe75a8a8028d08","unresolved":true,"context_lines":[{"line_number":850,"context_line":"        router1 \u003d self._create_router()"},{"line_number":851,"context_line":"        router2 \u003d self._create_router()"},{"line_number":852,"context_line":"        ctx \u003d self.admin_ctx"},{"line_number":853,"context_line":"        with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":854,"context_line":"            bindings \u003d self.plugin.get_ha_router_port_bindings("},{"line_number":855,"context_line":"                ctx, [router1[\u0027id\u0027], router2[\u0027id\u0027]])"},{"line_number":856,"context_line":"        self.plugin.delete_router(ctx, router1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"26d7ab60_b0189fd9","line":853,"range":{"start_line":853,"start_character":20,"end_line":853,"end_character":34},"updated":"2020-12-09 07:54:34.000000000","message":"ditto","commit_id":"f8235cc899522cba48364919128b2846572eac26"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d7e7046afdb1dc43a65c15e3677e81a2c0e3239e","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        router1 \u003d self._create_router()"},{"line_number":851,"context_line":"        router2 \u003d self._create_router()"},{"line_number":852,"context_line":"        ctx \u003d self.admin_ctx"},{"line_number":853,"context_line":"        with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":854,"context_line":"            bindings \u003d self.plugin.get_ha_router_port_bindings("},{"line_number":855,"context_line":"                ctx, [router1[\u0027id\u0027], router2[\u0027id\u0027]])"},{"line_number":856,"context_line":"        self.plugin.delete_router(ctx, router1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4548c91_093668f2","line":853,"range":{"start_line":853,"start_character":20,"end_line":853,"end_character":34},"in_reply_to":"26d7ab60_b0189fd9","updated":"2020-12-09 08:33:35.000000000","message":"same here","commit_id":"f8235cc899522cba48364919128b2846572eac26"}]}