)]}'
{"neutron/conf/policies/l3_conntrack_helper.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7ff51e7ab22de51d00d4d53eaa5e0947769354b4","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        name\u003d\u0027create_router_conntrack_helper\u0027,"},{"line_number":32,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":33,"context_line":"            base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":34,"context_line":"            base.RULE_ADMIN_OR_PARENT_OWNER),"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"        description\u003d\u0027Create a router conntrack helper\u0027,"},{"line_number":37,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":4,"id":"41fe4df0_61cd0999","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":43},"updated":"2021-01-27 14:13:13.000000000","message":"Same question I had in https://review.opendev.org/c/openstack/neutron/+/765847 should we drop the old rule here?","commit_id":"e2d1396ca04dccf84ca906689687bba9b7b1af90"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"484eacf9ce554527edf1e081a88b14d3e01e2ffc","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        name\u003d\u0027create_router_conntrack_helper\u0027,"},{"line_number":32,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":33,"context_line":"            base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":34,"context_line":"            base.RULE_ADMIN_OR_PARENT_OWNER),"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"        description\u003d\u0027Create a router conntrack helper\u0027,"},{"line_number":37,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":5,"id":"b96027a8_f1c6a1fc","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":43},"updated":"2021-02-19 17:45:18.000000000","message":"I have similar questions here as in the other review. The deprecation should handle the OR\u0027ing, unless we still want PARENT_OWNERS to access this API?\n\nIf that\u0027s the case, maybe we consider updating the new check string to use:\n\n  check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER_OR_PARENT_MEMBER\n\nI\u0027m not sure I fully understand what a parent owner is.","commit_id":"f4947c72896c474298d976073e5225b5932864eb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a789ad92496e1baa9d46f83a5302c23bdbe379db","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        name\u003d\u0027create_router_conntrack_helper\u0027,"},{"line_number":32,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":33,"context_line":"            base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":34,"context_line":"            base.RULE_ADMIN_OR_PARENT_OWNER),"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"        description\u003d\u0027Create a router conntrack helper\u0027,"},{"line_number":37,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":5,"id":"e56df27b_1b08effa","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":43},"in_reply_to":"b96027a8_f1c6a1fc","updated":"2021-03-06 08:28:07.000000000","message":"Parent owner is owner of the parent resource. We have in Neutron such resources like e.g. port_forwarding which \"belongs\" to the floating_ip, or this conntrack_helper which \"belongs\" to the router or e.g. qos rules for which parent is qos policy object.\n\nI updated it to what we discussed in different patch already. I hope it will be ok now.","commit_id":"f4947c72896c474298d976073e5225b5932864eb"}]}