)]}'
{"etc/neutron/plugins/vmware/nsx.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"805f56dbdead78e2397008060d12087b5c8e765f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# a service node is required in order to perform packet replication. This can"},{"line_number":133,"context_line":"# also be set to source if one wants replication to be performed locally (NOTE:"},{"line_number":134,"context_line":"# usually only useful for testing if one does not want to deploy a service node)."},{"line_number":135,"context_line":"#replication_mode \u003d service"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"[nsx_sync]"},{"line_number":138,"context_line":"# Interval in seconds between runs of the status synchronization task."}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAVn%2F%2FtAg%3D","line":135,"updated":"2014-03-04 15:45:45.000000000","message":"nit: space\n\nAlso, just for Icehouse, could you copy this over to nvp.ini?","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dfb118b22be9b64a839e2b66fd9c21c8ba5625c1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"# a service node is required in order to perform packet replication. This can"},{"line_number":133,"context_line":"# also be set to source if one wants replication to be performed locally (NOTE:"},{"line_number":134,"context_line":"# usually only useful for testing if one does not want to deploy a service node)."},{"line_number":135,"context_line":"#replication_mode \u003d service"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"[nsx_sync]"},{"line_number":138,"context_line":"# Interval in seconds between runs of the status synchronization task."}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAVn%2F%2Fmjk%3D","line":135,"in_reply_to":"AAAAVn%2F%2FtAg%3D","updated":"2014-03-05 04:48:02.000000000","message":"Done","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"}],"neutron/plugins/nicira/common/config.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3de9d0ea5bd8d4a947ead4318a5e6e3cd4162d8c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"cfg.CONF.register_opts(sync_opts, group\u003d\"NSX_SYNC\")"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def validate_config_options():"},{"line_number":194,"context_line":"    if cfg.CONF.NSX.replication_mode not in [ReplicationModes.SERVICE,"},{"line_number":195,"context_line":"                                             ReplicationModes.SOURCE]:"},{"line_number":196,"context_line":"        error \u003d (_(\"Invalid replication_mode: %s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F8gk%3D","line":193,"updated":"2014-03-03 09:05:37.000000000","message":"Can\u0027t you just use a StrOpt with choices to this aim?","commit_id":"12e1bc10bda279e894d6b97aa909357dcb4fa1d4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"c61587db9ff2149cf948ccd3b5bfbd51f33a21ec","unresolved":false,"context_lines":[{"line_number":190,"context_line":"cfg.CONF.register_opts(sync_opts, group\u003d\"NSX_SYNC\")"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def validate_config_options():"},{"line_number":194,"context_line":"    if cfg.CONF.NSX.replication_mode not in [ReplicationModes.SERVICE,"},{"line_number":195,"context_line":"                                             ReplicationModes.SOURCE]:"},{"line_number":196,"context_line":"        error \u003d (_(\"Invalid replication_mode: %s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F23M%3D","line":193,"in_reply_to":"AAAAVn%2F%2F8gk%3D","updated":"2014-03-03 19:16:09.000000000","message":"I looked in oslo.config/olso/config/cfg.py and it looks like they don\u0027t have anything to do this. I agree this would be a nice thing to add there. The agent_mode config option handles the options the same way i\u0027m doing it here.","commit_id":"12e1bc10bda279e894d6b97aa909357dcb4fa1d4"}],"neutron/plugins/vmware/common/config.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"805f56dbdead78e2397008060d12087b5c8e765f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    cfg.StrOpt(\u0027replication_mode\u0027, default\u003dReplicationModes.SERVICE,"},{"line_number":73,"context_line":"               help\u003d_(\"The default option leverages service nodes to perform\""},{"line_number":74,"context_line":"                      \" packet replication though one could set to this to\""},{"line_number":75,"context_line":"                      \"\u0027source\u0027 to perform replication locally. This is useful\""},{"line_number":76,"context_line":"                      \" if one does not want to deploy a service node(s).\"))"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FtAA%3D","line":75,"updated":"2014-03-04 15:45:45.000000000","message":"nit: missing space between to and \u0027source. I\u0027d suggest you leave the space at the end of the previous sentence and start without space on the new one.","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dfb118b22be9b64a839e2b66fd9c21c8ba5625c1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    cfg.StrOpt(\u0027replication_mode\u0027, default\u003dReplicationModes.SERVICE,"},{"line_number":73,"context_line":"               help\u003d_(\"The default option leverages service nodes to perform\""},{"line_number":74,"context_line":"                      \" packet replication though one could set to this to\""},{"line_number":75,"context_line":"                      \"\u0027source\u0027 to perform replication locally. This is useful\""},{"line_number":76,"context_line":"                      \" if one does not want to deploy a service node(s).\"))"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fmjo%3D","line":75,"in_reply_to":"AAAAVn%2F%2FtAA%3D","updated":"2014-03-05 04:48:02.000000000","message":"Done","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"805f56dbdead78e2397008060d12087b5c8e765f","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def validate_config_options():"},{"line_number":194,"context_line":"    if cfg.CONF.NSX.replication_mode not in [ReplicationModes.SERVICE,"},{"line_number":195,"context_line":"                                             ReplicationModes.SOURCE]:"},{"line_number":196,"context_line":"        error \u003d (_(\"Invalid replication_mode: %s\") %"},{"line_number":197,"context_line":"                 cfg.CONF.NSX.replication_mode)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fs%2Fc%3D","line":194,"updated":"2014-03-04 15:45:45.000000000","message":"Please consider using a tuple instead.","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dfb118b22be9b64a839e2b66fd9c21c8ba5625c1","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def validate_config_options():"},{"line_number":194,"context_line":"    if cfg.CONF.NSX.replication_mode not in [ReplicationModes.SERVICE,"},{"line_number":195,"context_line":"                                             ReplicationModes.SOURCE]:"},{"line_number":196,"context_line":"        error \u003d (_(\"Invalid replication_mode: %s\") %"},{"line_number":197,"context_line":"                 cfg.CONF.NSX.replication_mode)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fmj8%3D","line":194,"in_reply_to":"AAAAVn%2F%2Fs%2Fc%3D","updated":"2014-03-05 04:48:02.000000000","message":"just curious why?","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"805f56dbdead78e2397008060d12087b5c8e765f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                             ReplicationModes.SOURCE]:"},{"line_number":196,"context_line":"        error \u003d (_(\"Invalid replication_mode: %s\") %"},{"line_number":197,"context_line":"                 cfg.CONF.NSX.replication_mode)"},{"line_number":198,"context_line":"        raise nsx_exc.NvpPluginException(err_msg\u003derror)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fs%2Fs%3D","line":198,"updated":"2014-03-04 15:45:45.000000000","message":"Nvp \u003d\u003e Nsx","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dfb118b22be9b64a839e2b66fd9c21c8ba5625c1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                             ReplicationModes.SOURCE]:"},{"line_number":196,"context_line":"        error \u003d (_(\"Invalid replication_mode: %s\") %"},{"line_number":197,"context_line":"                 cfg.CONF.NSX.replication_mode)"},{"line_number":198,"context_line":"        raise nsx_exc.NvpPluginException(err_msg\u003derror)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fmj4%3D","line":198,"in_reply_to":"AAAAVn%2F%2Fs%2Fs%3D","updated":"2014-03-05 04:48:02.000000000","message":"Done","commit_id":"c1a88924432efa39a6859df486d86c58aea85e04"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7ca0b0c675be4d978ab032f568a1a3d2fe2f3b11","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cfg.StrOpt(\u0027agent_mode\u0027, default\u003dAgentModes.AGENT,"},{"line_number":70,"context_line":"               deprecated_group\u003d\u0027NVP\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\"The mode used to implement DHCP/metadata services.\")),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027replication_mode\u0027, default\u003dReplicationModes.SERVICE,"},{"line_number":73,"context_line":"               help\u003d_(\"The default option leverages service nodes to perform\""},{"line_number":74,"context_line":"                      \" packet replication though one could set to this to \""},{"line_number":75,"context_line":"                      \"\u0027source\u0027 to perform replication locally. This is useful\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FAuQ%3D","line":72,"updated":"2014-03-20 23:13:57.000000000","message":"can\u0027t you use the choices keywork avoiding the validation function?","commit_id":"42c882b9e98755b9e119f6c566fc00a62a420af7"}],"neutron/plugins/vmware/plugins/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d0b867a25fc4ee2133cbf32672005cd613af1be1","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                \u0027security-group\u0027 in self.supported_extension_aliases}}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self._extend_fault_map()"},{"line_number":178,"context_line":"        config.validate_config_options()"},{"line_number":179,"context_line":"        self.setup_dhcpmeta_access()"},{"line_number":180,"context_line":"        # Set this flag to false as the default gateway has not"},{"line_number":181,"context_line":"        # been yet updated from the config file"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FLds%3D","line":178,"updated":"2014-03-07 20:31:52.000000000","message":"wouldn\u0027t it make sense to bring this to the top? What\u0027s the point of connecting to the NSX cluster if we are going to fail here? That unless this is something that\u0027s version dependent, in which case we\u0027d need to talk to the controller first. As far as I can tell SOURCE is a 3.1+ feature.\n\nI am not aware of anyone running 3.0 or lower still...but you\u0027d never know.","commit_id":"093257ef38d9aeb8887439f6613f0be9857b0ccd"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"102a93cab38defa07fdee828442fd4482c4ec222","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                \u0027security-group\u0027 in self.supported_extension_aliases}}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self._extend_fault_map()"},{"line_number":178,"context_line":"        config.validate_config_options()"},{"line_number":179,"context_line":"        self.setup_dhcpmeta_access()"},{"line_number":180,"context_line":"        # Set this flag to false as the default gateway has not"},{"line_number":181,"context_line":"        # been yet updated from the config file"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2B%2BKY%3D","line":178,"in_reply_to":"AAAAVn%2F%2FLds%3D","updated":"2014-03-10 23:33:19.000000000","message":"Done","commit_id":"093257ef38d9aeb8887439f6613f0be9857b0ccd"}]}