)]}'
{"id":"openstack%2Fneutron~766939","triplet_id":"openstack%2Fneutron~master~I2e784ea7e00c145135288bf309bb34ce311ac15c","project":"openstack/neutron","branch":"master","topic":"bug/1908057","hashtags":[],"change_id":"I2e784ea7e00c145135288bf309bb34ce311ac15c","subject":"Ensure \"keepalived\" is correcly disabled","status":"MERGED","created":"2020-12-14 12:32:49.000000000","updated":"2020-12-17 13:27:16.000000000","submitted":"2020-12-17 13:25:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"766939-bug/1908057","meta_rev_id":"d87ac2c5c1a26e6e55005212b91f8492405e40a7","_number":766939,"virtual_id_number":766939,"owner":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"recommended":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2020-12-16 18:35:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},{"value":0,"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-17 13:25:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"all":[{"value":0,"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},{"value":2,"date":"2020-12-17 07:48:27.000000000","_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},{"value":2,"date":"2020-12-17 07:35:54.000000000","_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"all":[{"value":0,"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},{"value":1,"date":"2020-12-17 09:29:28.000000000","_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},{"value":0,"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-14 14:28:34.000000000","updated_by":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"reviewer":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"state":"CC"},{"updated":"2020-12-14 15:17:48.000000000","updated_by":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-14 17:12:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-15 05:49:36.000000000","updated_by":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"reviewer":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"state":"REVIEWER"},{"updated":"2020-12-17 07:48:27.000000000","updated_by":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"reviewer":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"state":"REVIEWER"}],"messages":[{"id":"a667d30d5d3f725005f2ccd984a51fcc6cf404f5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-14 12:32:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d1085f3169766f1be17102054056c0ae3a259c61","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2020-12-14 14:28:34.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/766939/1 : SUCCESS in 1h 55m 02s","accounts_in_message":[],"_revision_number":1},{"id":"79726148601730265d47637c776c8daf7524f596","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2020-12-14 15:17:48.000000000","message":"Patch Set 1: Verified+1\n\nArista third party testing PASSED [ https://arista-openstack-ci.arista.com:8000/December-2020/Arista_Tempest_Testrefs/changes/39/766939/1 ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":1},{"id":"55b598dee1fd6c6657efd24eb19ea481fd45adea","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-14 17:12:42.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/a38bb353cfad4b7185925382227935c0 : SUCCESS in 1h 00m 22s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/834b21006b684360ab41cd742b74a51b : SUCCESS in 37m 50s (non-voting)\n- neutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/8ec3a0db4e1f4302903237accd56994d : SUCCESS in 1h 55m 31s\n- neutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/7649234bcb7440099e7e3d7d8b6774a3 : SUCCESS in 1h 09m 08s\n- neutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/ddb1c6927a324cc29361d846dc9c88d3 : SUCCESS in 1h 29m 24s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/3757494466ce4a8eb29f6624f785c571 : SUCCESS in 1h 21m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f07c007d7c5c4398ad260b0796348e84 : SUCCESS in 53m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/aa58975bb96f469d91ec3e3bd4233297 : SUCCESS in 39m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/03f75c7cd91e4e54bdd1deea63513803 : SUCCESS in 12m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/48f3634597894e2799ffbbc9f938ad13 : SUCCESS in 44m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8834cf403752413180f6f77bd5aa62d1 : SUCCESS in 33m 40s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/106b2bd548fa4c6abe25c60cff45fd54 : SUCCESS in 34m 52s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3e3f31f4f2fa43f89f6d591ffd7e3320 : SUCCESS in 8m 37s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/5fa84fda84d540a39f5807baff4c1ea8 : SUCCESS in 1h 03m 24s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/c1dd8a781e8047d9aa75f8ca1882ffb4 : SUCCESS in 1h 07m 41s\n- neutron-rally-task https://zuul.opendev.org/t/openstack/build/5fe8e4a49d78469580f5662580172e06 : SUCCESS in 1h 26m 56s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/ff07f9d3f0ae4d71b13e5de7111f7b63 : SUCCESS in 54m 07s\n- neutron-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/d651c4deb4924d9788534a9e7f0e3bd5 : SUCCESS in 58m 38s\n- neutron-grenade-ovn https://zuul.opendev.org/t/openstack/build/601db0da82314ce7acaa3fc780894c39 : FAILURE in 48m 49s (non-voting)\n- neutron-tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/b4da119d53b145d39dcc6b62760b557a : SUCCESS in 1h 09m 14s\n- neutron-tempest-dvr-ha-multinode-full https://zuul.opendev.org/t/openstack/build/9f365b15686948fea6b40f4b8151c6f9 : FAILURE in 1h 13m 23s (non-voting)\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/e77000156d09488cb1f88a8225347d8f : SUCCESS in 1h 16m 32s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/8c51c81559a74930aa904a1f0794db87 : FAILURE in 1h 54m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/00a05c592863450eb407108b5fced33b : SUCCESS in 1h 15m 13s\n- neutron-tempest-with-neutron-lib-master https://zuul.opendev.org/t/openstack/build/a948a8c3dd414b71b857d3e736137a4c : SUCCESS in 1h 06m 16s (non-voting)\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/b44294bccfcf4d3292f7869b17774b2d : SUCCESS in 1h 05m 51s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/4d4d6b27cd6342d9ae0813dce7e27f0f : SUCCESS in 35m 28s\n- neutron-tempest-with-uwsgi-loki https://zuul.opendev.org/t/openstack/build/9070554ddb4d4c17849724b65e4f5fe9 : FAILURE in 1h 13m 11s (non-voting)\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/d22a8e5bd4bf4358848c41e4a24f535b : SUCCESS in 1h 38m 39s (non-voting)\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/979afa29d5374d75b4d2da73da4ca66f : SUCCESS in 3h 51m 16s (non-voting)\n- neutron-centos-8-tripleo-standalone https://zuul.opendev.org/t/openstack/build/866f96261a244454b6b5f392d1ece84b : SUCCESS in 1h 13m 26s (non-voting)\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/75c99d474eb8442ab9a4959c4dbc7ca5 : SUCCESS in 1h 50m 25s (non-voting)\n- neutron-ovn-tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/87b11ce292af4c19a27a46f9821470c7 : SUCCESS in 1h 58m 46s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/15cbfb2b641d4b3e81be55f8e1e15d71 : TIMED_OUT in 3h 03m 36s (non-voting)\n- neutron-ovn-tempest-full-multinode-ovs-master https://zuul.opendev.org/t/openstack/build/b5a4bfc7d20744d2a30743a287ef96e3 : FAILURE in 2h 10m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8496968b38ef2344f926744ff6a68413eaaef226","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-14 21:51:35.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"90a7fdc51ba7de725d913fd3425c66e5a71f3ad0","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2020-12-14 23:39:40.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/766939/1 : SUCCESS in 1h 47m 34s","accounts_in_message":[],"_revision_number":1},{"id":"019f97e9a7f2d8ef676ccd9fad55e8cfe4edcc22","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-15 02:02:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/2d9b042b8112404788f18fd44dcfb08b : SUCCESS in 50m 07s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/e5101a715811455da61c3611d805d314 : SUCCESS in 27m 56s (non-voting)\n- neutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/9a0d7c9ad9c3429db6caf7f4032d1036 : SUCCESS in 1h 30m 34s\n- neutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/593490d795584c8291956f74b21857f4 : SUCCESS in 1h 21m 34s\n- neutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/74fb65e52fcf40608aad060ed63138af : SUCCESS in 1h 47m 15s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/dd04ccf2fa984ffda46b3c762150e245 : SUCCESS in 1h 45m 29s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a48120fbef934498a732fdc9c0bce76a : SUCCESS in 34m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ff2a6e282554609aed5068a624d72fc : SUCCESS in 20m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77e9ae40b3ae436899846f08c7df7446 : SUCCESS in 11m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9f9960dc9b6248bb882699e34efc9ad5 : SUCCESS in 25m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/309e4883585f46f1ab278b1940be2274 : SUCCESS in 30m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/be8d8c07bef3423b8217938b37971e86 : SUCCESS in 29m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d5f5de14fc634959945afc38fea427f3 : SUCCESS in 8m 48s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/f9bae91a996a443caad826128afbe744 : SUCCESS in 1h 17m 46s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/03baf12284c340cda2aed4c5398594af : SUCCESS in 1h 15m 13s\n- neutron-rally-task https://zuul.opendev.org/t/openstack/build/4eee4ae7acd6462d82a40061c2979e60 : SUCCESS in 1h 45m 42s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/b152e643129d46a0be85cb23fffabbb8 : SUCCESS in 59m 01s\n- neutron-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/3c6ed4d7ca484489a7cb9420518f4862 : SUCCESS in 54m 45s\n- neutron-grenade-ovn https://zuul.opendev.org/t/openstack/build/809fd5ba3ad54d02acefdf9b1a2dc956 : FAILURE in 1h 01m 34s (non-voting)\n- neutron-tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/aa1cb59fc3794449ae79c1f4fd458e2b : SUCCESS in 1h 10m 50s\n- neutron-tempest-dvr-ha-multinode-full https://zuul.opendev.org/t/openstack/build/cab670195f9c475db7376e6dedb3067a : FAILURE in 1h 12m 20s (non-voting)\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ae09799e4e9f41ca856668a636c782f4 : SUCCESS in 1h 26m 29s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/6851ca008f5f479ca939b5a58c5e18bd : SUCCESS in 2h 26m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9474bc9aef6f45978e6fc5ac90122bb3 : SUCCESS in 56m 23s\n- neutron-tempest-with-neutron-lib-master https://zuul.opendev.org/t/openstack/build/cf4bca943b7e49de942c825f9382e61c : SUCCESS in 55m 13s (non-voting)\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/a15c8817d9f040ba90ed41ad2308fbfd : SUCCESS in 1h 17m 03s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/6fc3ebedfa9341488a46b28cacc322e5 : SUCCESS in 40m 07s\n- neutron-tempest-with-uwsgi-loki https://zuul.opendev.org/t/openstack/build/75d35b3c38c748f98ce75bdd260e3759 : FAILURE in 1h 13m 07s (non-voting)\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/93a73a97605b40119fba898885583c7b : SUCCESS in 1h 14m 38s (non-voting)\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/9102149c8b3346609a76d9269a5044ed : SUCCESS in 3h 58m 13s (non-voting)\n- neutron-centos-8-tripleo-standalone https://zuul.opendev.org/t/openstack/build/1585264fc0f74ec1b1c4417daee9e4b4 : SUCCESS in 1h 30m 08s (non-voting)\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/bfd90aecb12c4a14a57e8f041e2ff24e : SUCCESS in 1h 32m 06s (non-voting)\n- neutron-ovn-tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/da7914390db14ac785db1a7e0d43387b : SUCCESS in 2h 13m 54s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/30c476d5d92c4ba7af070d2be3c3b6f6 : FAILURE in 2h 39m 49s (non-voting)\n- neutron-ovn-tempest-full-multinode-ovs-master https://zuul.opendev.org/t/openstack/build/f6ad0f03312d4ca781d568fd32656106 : FAILURE in 1h 54m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4d902a0c54a939ee16b751b0c126eb909747296c","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2020-12-15 05:49:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b79e36e7bb7dfd28d24fa2235a06d2dad6ef5d25","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-15 08:34:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4f4d0b74f64b83300a236b44c977c2b7844d62b9","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2020-12-15 09:34:17.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"407cfd12e7cb37832f3b8b988c8d3d29c5451b91","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-15 14:40:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e0f559f62713c7bc79ed9597ca5e73120e11a05b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-15 17:30:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b09cf05f6a9adf9049ea3e7e76e1b037120c6178","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2020-12-15 21:13:07.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/766939/2 : SUCCESS in 1h 48m 22s","accounts_in_message":[],"_revision_number":2},{"id":"01a5ec1491486eddfb75a394deefb23c114956b0","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2020-12-16 04:32:55.000000000","message":"Patch Set 2:\n\nArista third party testing FAILED [ https://arista-openstack-ci.arista.com:8000/December-2020/Arista_Tempest_Testrefs/changes/39/766939/2 ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":2},{"id":"776d9d8c51667b8edc667260fab3340dc2dc0c76","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2020-12-16 06:03:56.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ce1cbbb3ed301812f8f7754216f4b733f63923bc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-16 15:32:07.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/29e1a47ee2a24970ae697ccad01dfd9a : SUCCESS in 1h 01m 31s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/0bb06a6004994a4a9a3eef523268acdd : FAILURE in 36m 38s (non-voting)\n- neutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/16fe5d7b90414602b1c8f016513ca97f : SUCCESS in 1h 51m 58s\n- neutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/3d9ade77c3b44190a77a0b5bc51b5180 : SUCCESS in 1h 44m 40s\n- neutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/54f2ab432192405ca46b9c593304f389 : SUCCESS in 1h 37m 11s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/ca6255327de146b19e7c5cd12a03ff18 : SUCCESS in 1h 30m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b0891faba3da4faf9260546e87f327d8 : SUCCESS in 33m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/515e795cfbcd43948d1a6f7729e78487 : SUCCESS in 29m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1cd134ef6e474962b4c7444f994b7e39 : SUCCESS in 13m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7e5dd6a1d1c84a5586499ad3b7269652 : SUCCESS in 27m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bfe16271aa4248d4b5784ee5c016584c : SUCCESS in 27m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6272d83bc9b7446382b75a5e72f65508 : SUCCESS in 25m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d3989b92c0c149d79e28c44ab3f46a29 : SUCCESS in 10m 07s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/4def94fbcf5f4f42acd5c85d9bbe5e2b : SUCCESS in 1h 28m 41s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/4bc5a6dc36f74294ae668c07f2dfd5f2 : SUCCESS in 1h 10m 44s\n- neutron-rally-task https://zuul.opendev.org/t/openstack/build/81f574b13c124f02a96df650338a65d7 : SUCCESS in 1h 40m 36s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/569ac996443e44949928a06c22f8c196 : SUCCESS in 58m 34s\n- neutron-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/f4707c0f381040a7aee43d16c5844453 : SUCCESS in 58m 00s\n- neutron-grenade-ovn https://zuul.opendev.org/t/openstack/build/cb8adbd165b8415aa86dc8ba70694c4d : FAILURE in 54m 40s (non-voting)\n- neutron-tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/ac47601af65a4d6e85a45561cb86fdae : SUCCESS in 1h 10m 07s\n- neutron-tempest-dvr-ha-multinode-full https://zuul.opendev.org/t/openstack/build/a607676b70744e01a76f378a8e15c1c9 : FAILURE in 1h 15m 04s (non-voting)\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/186ed554cd314d37a07e11900cfb364b : SUCCESS in 1h 05m 49s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/dc883e8684fa4c79b20515983c7faad1 : SUCCESS in 1h 53m 11s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/62aa7223a2ba4fa8bb69fcb43239c28f : SUCCESS in 54m 59s\n- neutron-tempest-with-neutron-lib-master https://zuul.opendev.org/t/openstack/build/7cefec780367494891042eb00da7c740 : SUCCESS in 57m 21s (non-voting)\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/7b22110c24de4fa1b3a5e03f1f43b8f0 : FAILURE in 50m 19s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/287420fe99b7494bafc3f703bcb595a4 : SUCCESS in 44m 57s\n- neutron-tempest-with-uwsgi-loki https://zuul.opendev.org/t/openstack/build/8264e56ffc3a4e53aa7c0749663cb207 : FAILURE in 1h 19m 19s (non-voting)\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/287c39bec96e47fab5d86642f5a15be3 : SUCCESS in 1h 12m 41s (non-voting)\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/8ca2b4c07af047bfa235af3525d3587a : SUCCESS in 4h 10m 33s (non-voting)\n- neutron-centos-8-tripleo-standalone https://zuul.opendev.org/t/openstack/build/f4230623c01d4b9285bc8d66b546e1bf : SUCCESS in 1h 14m 52s (non-voting)\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/ee8a90f117ee4cac86200e40c5b60504 : SUCCESS in 1h 52m 46s (non-voting)\n- neutron-ovn-tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/c326810c2ad244bdabce1e98944bc372 : SUCCESS in 1h 56m 49s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/e3496664362e4de687c82db2e684a4a7 : FAILURE in 3h 00m 59s (non-voting)\n- neutron-ovn-tempest-full-multinode-ovs-master https://zuul.opendev.org/t/openstack/build/e028885b1e4c4065a64b99f174bd31fc : FAILURE in 1h 45m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1832251d87aa352904cf6093996e97b47628baaa","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-16 16:31:41.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e5287287b970024cc5d36c15de46b1c23141f4d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-16 16:33:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"50b3227e69e16313ad9a1ef225feabdf79968740","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2020-12-16 18:23:23.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/766939/3 : SUCCESS in 1h 48m 55s","accounts_in_message":[],"_revision_number":3},{"id":"55b21dc4d2e35b79c6c0e5dd707ff811372877c8","author":{"_account_id":9845,"name":"Arista CI","email":"arista-openstack-test@aristanetworks.com","username":"arista-test","tags":["SERVICE_USER"]},"date":"2020-12-16 18:35:16.000000000","message":"Patch Set 3: Verified+1\n\nArista third party testing PASSED [ https://arista-openstack-ci.arista.com:8000/December-2020/Arista_Tempest_Testrefs/changes/39/766939/3 ]\n\nFor testing details or any questions please check https://wiki.openstack.org/wiki/Arista-third-party-testing","accounts_in_message":[],"_revision_number":3},{"id":"3bc3253bdce1ffa03da93e2756750282cad152fa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 05:18:02.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/91eb1989e7e848f4a2855c5a7c69abb4 : SUCCESS in 47m 35s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/e0e299a8c6a74e2587d90df14d8ecfd0 : SUCCESS in 32m 01s (non-voting)\n- neutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/bb328228a8bc42e99fbddd7c762c89f5 : SUCCESS in 1h 43m 38s\n- neutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/8f43c7badf144c08b02d7dc442f2b989 : SUCCESS in 1h 26m 04s\n- neutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/0bf4f708881d482ca7742a1b780d99bb : SUCCESS in 1h 35m 43s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/4b51ad8173424d0aa6cba7273df02f16 : SUCCESS in 1h 29m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fa89e0e9f54e4f59a10a63ba4a967163 : SUCCESS in 41m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/55193a04d41a47358af63d109f5c18ef : SUCCESS in 30m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/063840afffff4e8b9a3298a09c1d144c : SUCCESS in 12m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/241ae2f26b6347a489fd17c3ec180430 : SUCCESS in 16m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/41f03c921be94f049c99bd8dd057f3a6 : SUCCESS in 27m 03s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/86801b67e6514bf28870fe66a9462dcb : SUCCESS in 31m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1cee7f08990145efbf0b4bbf3b95f6d0 : SUCCESS in 8m 46s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/66c0ec0d931040ee82be767ae0045600 : FAILURE in 1h 16m 32s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/8066446321064ed59a3f413f126bc392 : SUCCESS in 1h 03m 33s\n- neutron-rally-task https://zuul.opendev.org/t/openstack/build/1ece994716c340b6b78e4417f75b2b47 : SUCCESS in 1h 01m 33s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/9c967d825cf74cdd899b92143d03dfd7 : SUCCESS in 1h 12m 42s\n- neutron-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/dc8650da99134668a328b7eff720d275 : SUCCESS in 55m 05s\n- neutron-grenade-ovn https://zuul.opendev.org/t/openstack/build/5f3d8f64c99d43f38e89685bc7f739a0 : FAILURE in 59m 34s (non-voting)\n- neutron-tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/256dd23ddcb94f92bb08c13ae2cfc47d : SUCCESS in 1h 29m 30s\n- neutron-tempest-dvr-ha-multinode-full https://zuul.opendev.org/t/openstack/build/561a09a9e26a4a6a9d45db7a002f63a6 : FAILURE in 1h 18m 31s (non-voting)\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d487280ab0ef4f7980d67cce0998a707 : SUCCESS in 1h 14m 17s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/6bbb87ecc0294a07ae72bda1612026a7 : SUCCESS in 2h 29m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/592da490a1c241ff8e0c154b364702ea : SUCCESS in 59m 35s\n- neutron-tempest-with-neutron-lib-master https://zuul.opendev.org/t/openstack/build/556a21f23dd142e392a1fbe2fbadbde0 : SUCCESS in 1h 01m 46s (non-voting)\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/ed2758ec0a2f499488d74e55176e5174 : SUCCESS in 1h 00m 39s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/4a80152d46834f12acc26de116264a11 : SUCCESS in 33m 24s\n- neutron-tempest-with-uwsgi-loki https://zuul.opendev.org/t/openstack/build/ca0aa82f94504b088af0508fb50a2fcd : FAILURE in 1h 02m 19s (non-voting)\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/acc28dd4dd4c402aa0cf91697085fcaa : SUCCESS in 1h 31m 23s (non-voting)\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/6b78fa6859ec4594af2cde26d1b00ba6 : SUCCESS in 3h 59m 34s (non-voting)\n- neutron-centos-8-tripleo-standalone https://zuul.opendev.org/t/openstack/build/af8e9b4bf17b4a20b6f15a36d8719f4c : SUCCESS in 1h 29m 52s (non-voting)\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/27885c1c27024cbc99633d75eb7de84d : SUCCESS in 1h 36m 27s (non-voting)\n- neutron-ovn-tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/f34bb2e08a5e484d9aa567a7a9e60ebe : SUCCESS in 2h 12m 07s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/ee79a75e16064e00b54670285699f42c : FAILURE in 2h 45m 49s (non-voting)\n- neutron-ovn-tempest-full-multinode-ovs-master https://zuul.opendev.org/t/openstack/build/7744f20d5a8c439ba77795195b2d3d20 : FAILURE in 2h 02m 24s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d278e5053ab1798454edddd77ea9a272c34e87df","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-17 07:15:42.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"70859aa2080d6856fb640444095976aafdea995a","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2020-12-17 07:35:54.000000000","message":"Patch Set 3: Code-Review+2\n\n`","accounts_in_message":[],"_revision_number":3},{"id":"c5ea620b2c577d973c38f751707cfd54a38e2449","author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"date":"2020-12-17 07:48:27.000000000","message":"Patch Set 3: Code-Review+2\n\nCode are basically same to the destroy_state_change_monitor which disable the neutron-state-change process. But for keepalived it has a process stucture like this:\nPID         111     Keepalived  \u003c-- Parent process monitoring children\n            112     \\_ Keepalived   \u003c-- VRRP child\n            113     \\_ Keepalived   \u003c-- Healthchecking child [neutron does not spawn this process]\n\nSo for the kill -9 action here, IIUC, it only kill the \u003cpid_111\u003e. The keepalived VRRP process \u003cpid_112\u003e will be killed as well? Or become zombie or left there forever if the singal does not pass from the parent to the child?\n\nFrom my local test, it shows out that the keepalived VRRP can be killed as well. So I guess that keepalived Parent process passes the TERM signal to the child. But a very corner case, what if VRRP process is doing the failover work?\n\nSo, code looks good to me. We can go with this to see if something happens.\n\n[1] https://keepalived.readthedocs.io/en/latest/software_design.html","accounts_in_message":[],"_revision_number":3},{"id":"ff65431990d6d19d62f5f5937db7aa69ffa41242","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-12-17 07:59:49.000000000","message":"Patch Set 3:\n\n\u003e Patch Set 3: Code-Review+2\n\u003e \n\u003e Code are basically same to the destroy_state_change_monitor which disable the neutron-state-change process. But for keepalived it has a process stucture like this:\n\u003e PID         111     Keepalived  \u003c-- Parent process monitoring children\n\u003e             112     \\_ Keepalived   \u003c-- VRRP child\n\u003e             113     \\_ Keepalived   \u003c-- Healthchecking child [neutron does not spawn this process]\n\u003e \n\u003e So for the kill -9 action here, IIUC, it only kill the \u003cpid_111\u003e. The keepalived VRRP process \u003cpid_112\u003e will be killed as well? Or become zombie or left there forever if the singal does not pass from the parent to the child?\n\u003e \n\u003e From my local test, it shows out that the keepalived VRRP can be killed as well. So I guess that keepalived Parent process passes the TERM signal to the child. But a very corner case, what if VRRP process is doing the failover work?\n\u003e \n\u003e So, code looks good to me. We can go with this to see if something happens.\n\u003e \n\u003e [1] https://keepalived.readthedocs.io/en/latest/software_design.html\n\nHi Liu, please see my comment here: https://review.opendev.org/c/openstack/neutron/+/766939/1/neutron/agent/linux/keepalived.py#487","accounts_in_message":[],"_revision_number":3},{"id":"2d5a6c1701ae4f9c7d21e0a904d0a272bb482c11","author":{"_account_id":26622,"name":"Cloudbase Neutron Hyper-V CI","email":"neutron_hyperv_ci@cloudbasesolutions.com","username":"neutron_hyperv_ci"},"date":"2020-12-17 09:12:50.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- neutron http://cloudbase-ci.com/neutron/766939/3 : SUCCESS in 1h 56m 35s","accounts_in_message":[],"_revision_number":3},{"id":"2a284b2c33023867f573b07bd795e60b7850fa6c","author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"date":"2020-12-17 09:29:28.000000000","message":"Patch Set 3: Workflow+1\n\n\u003e Patch Set 3:\n\u003e \n\u003e \u003e Patch Set 3: Code-Review+2\n\u003e \u003e \n\u003e \u003e Code are basically same to the destroy_state_change_monitor which disable the neutron-state-change process. But for keepalived it has a process stucture like this:\n\u003e \u003e PID         111     Keepalived  \u003c-- Parent process monitoring children\n\u003e \u003e             112     \\_ Keepalived   \u003c-- VRRP child\n\u003e \u003e             113     \\_ Keepalived   \u003c-- Healthchecking child [neutron does not spawn this process]\n\u003e \u003e \n\u003e \u003e So for the kill -9 action here, IIUC, it only kill the \u003cpid_111\u003e. The keepalived VRRP process \u003cpid_112\u003e will be killed as well? Or become zombie or left there forever if the singal does not pass from the parent to the child?\n\u003e \u003e \n\u003e \u003e From my local test, it shows out that the keepalived VRRP can be killed as well. So I guess that keepalived Parent process passes the TERM signal to the child. But a very corner case, what if VRRP process is doing the failover work?\n\u003e \u003e \n\u003e \u003e So, code looks good to me. We can go with this to see if something happens.\n\u003e \u003e \n\u003e \u003e [1] https://keepalived.readthedocs.io/en/latest/software_design.html\n\u003e \n\u003e Hi Liu, please see my comment here: https://review.opendev.org/c/openstack/neutron/+/766939/1/neutron/agent/linux/keepalived.py#487\n\nSo, your \"monitoring thread\" means the \"VRRP child\" process, while the \"main thread\" means the \"Parent process\", right? 😊","accounts_in_message":[],"_revision_number":3},{"id":"1eec77b3430233384d935642040b665d7ddc1a49","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 10:54:47.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/5e05f277240e4afbb13377faf498ecdf : SUCCESS in 59m 08s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/53017108b58040c8acbe92ddd2fc8acc : SUCCESS in 38m 07s (non-voting)\n- neutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/1c7910b4f798446e802115b94fb5ff82 : SUCCESS in 1h 26m 29s\n- neutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/f8c657277382403fa81cc4ec7af5746b : SUCCESS in 1h 25m 31s\n- neutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/882205da22c148c0ad44f195edd7e56c : SUCCESS in 1h 32m 08s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/3213734a8ae742cf8096e1827d4b2c51 : SUCCESS in 1h 18m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9420c145192b463c9748b51f6f119433 : SUCCESS in 33m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/65df7afe54ca4a1f8ca3d1a9bdd4ce9a : SUCCESS in 32m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eff1561a4c0942649ee3e2998af54940 : SUCCESS in 13m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e532bee98f364c3f91bc7a6b4e82dd22 : SUCCESS in 28m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6f96b06a8ec6435aa351db9ecf330b19 : SUCCESS in 24m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cc6a5c533de746318d16dbba8ca5cee9 : SUCCESS in 33m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8a4fdcbb9a1e45d09bab9b54d39fbee4 : SUCCESS in 8m 59s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/6c4e3384b68c445fae1129e3bc367dbd : SUCCESS in 1h 22m 20s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/8231f5fe215a4735b7350c7208c5adf8 : SUCCESS in 1h 09m 48s\n- neutron-rally-task https://zuul.opendev.org/t/openstack/build/934a14894d124c9e9eda56b241e5ecfa : SUCCESS in 1h 30m 27s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/eb5def6a46944794b449b3b45d11e90d : SUCCESS in 59m 10s\n- neutron-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/0d3e8f12b3994925935c9fd58396ed1e : SUCCESS in 1h 04m 08s\n- neutron-grenade-ovn https://zuul.opendev.org/t/openstack/build/681b8383e4e04e1f80fab9b7380295d1 : FAILURE in 53m 53s (non-voting)\n- neutron-tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/c883ea8de6f447b6a420d8ab15b28ab3 : SUCCESS in 1h 23m 34s\n- neutron-tempest-dvr-ha-multinode-full https://zuul.opendev.org/t/openstack/build/daaf18e214194fe281dc113084263a19 : FAILURE in 1h 36m 59s (non-voting)\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/30439fa369674cc5b0b1c3c271a9fb7e : SUCCESS in 1h 10m 50s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/25ee58a2c7234641adaa9cfa82780c48 : SUCCESS in 2h 32m 41s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3852de136a5b406f849e287aafe0bba2 : SUCCESS in 1h 08m 59s\n- neutron-tempest-with-neutron-lib-master https://zuul.opendev.org/t/openstack/build/8c334890162842e6bb6210444c960f1c : SUCCESS in 1h 03m 01s (non-voting)\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/f67df2f10f5a4695953ba34ddf5b1612 : SUCCESS in 1h 07m 15s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/4c832c63067243968ef5732d76c3d25e : SUCCESS in 35m 59s\n- neutron-tempest-with-uwsgi-loki https://zuul.opendev.org/t/openstack/build/13891b5556d44973990ca242c65e1f57 : FAILURE in 1h 07m 35s (non-voting)\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/26415a1c3ac246dc893c2599f4ed848b : SUCCESS in 1h 21m 34s (non-voting)\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/08058785e00241e98e62e2b1eef69adb : SUCCESS in 3h 04m 34s (non-voting)\n- neutron-centos-8-tripleo-standalone https://zuul.opendev.org/t/openstack/build/6f4cc6f4405e45e7aa1911041200a23a : SUCCESS in 1h 27m 45s (non-voting)\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/ea209e3ef7b140449028bb2b6fa4d554 : SUCCESS in 1h 13m 57s (non-voting)\n- neutron-ovn-tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/1777968e43d94df9bb9c3bedeb8dd7f2 : SUCCESS in 1h 48m 31s (non-voting)\n- neutron-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/628c8d2262ae4307bebef17f6015cbf4 : FAILURE in 2h 51m 00s (non-voting)\n- neutron-ovn-tempest-full-multinode-ovs-master https://zuul.opendev.org/t/openstack/build/89a09930a48b40279a89d58644226f07 : FAILURE in 1h 59m 03s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b93803eee70ef5b5c034fbec9c9c5169ebc0bfe8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 10:55:05.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"871e206980f01a3c1c6a96c578c57f4f126d53de","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 13:25:34.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/18b9acd8cd0947f8a78b8c8da58dbdc0 : SUCCESS in 53m 37s\n- neutron-tempest-plugin-scenario-linuxbridge https://zuul.opendev.org/t/openstack/build/422362696a3d417b9ba16a5a52d48908 : SUCCESS in 1h 58m 03s\n- neutron-tempest-plugin-scenario-openvswitch https://zuul.opendev.org/t/openstack/build/a4fdbc1eb0224e4daae06bd757b27730 : SUCCESS in 1h 22m 23s\n- neutron-tempest-plugin-scenario-ovn https://zuul.opendev.org/t/openstack/build/c6020cb11399403cb32b093967838aff : SUCCESS in 1h 46m 27s\n- neutron-tempest-plugin-scenario-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/6a479b7675ff4bc39677034e680ed9d6 : SUCCESS in 1h 28m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4f9617a110fe4e62a7250259a1a2d9cb : SUCCESS in 28m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef12158b908447f7b32bead4922078e9 : SUCCESS in 22m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e4141ab0331a47c99305b81238f6783b : SUCCESS in 29m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ed2c36b6a82e48ccbb63adff5c834707 : SUCCESS in 24m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1c4325902aaa47a282a3287bb5120f61 : SUCCESS in 7m 50s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/b5fe995b9d804a11814660721ff33a76 : SUCCESS in 1h 17m 13s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/812f906714ec4be19535b4aa1adcf6f8 : SUCCESS in 1h 12m 44s\n- neutron-tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/2c1c2888a02644318e77a43994530d12 : SUCCESS in 1h 16m 49s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/1dddad51ab914a9f8ea01f91fba2f1b0 : SUCCESS in 1h 20m 32s\n- neutron-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/79d6fdc0289541febfdf950eae7fd577 : SUCCESS in 57m 09s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/28f1ddd5282b4fa3a88e2de0028926ea : SUCCESS in 2h 23m 43s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/67d7de92045c49509ff642438de6e5ea : SUCCESS in 1h 05m 19s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/376f67e68f474c38b4ee08ed037b01aa : SUCCESS in 1h 05m 30s\n- neutron-ovn-tempest-ovs-release-ipv6-only https://zuul.opendev.org/t/openstack/build/cea8bc56eac44e6c9323f29c51a033dc : SUCCESS in 35m 27s","accounts_in_message":[],"_revision_number":3},{"id":"e951d7afad4312e337a625f9c985f3d341d5c6c8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 13:25:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"d87ac2c5c1a26e6e55005212b91f8492405e40a7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 13:27:16.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3e78b83cf2594bafbf60e07311b6036e : SUCCESS in 58s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2618acff516e5cfd2437dabf550cc3c3c7972b9f","revisions":{"f9a3e46b1aa623fd408e655bc0df1866c8858e4f":{"kind":"REWORK","_number":1,"created":"2020-12-14 12:32:49.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/39/766939/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/39/766939/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/39/766939/1"}}},"commit":{"parents":[{"commit":"2d4b3aa119c4dcee73c8cbb4f964bb092ae0775b","subject":"Merge \"Delete HA metadata proxy PID and config with elevated privileges\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/2d4b3aa119c4dcee73c8cbb4f964bb092ae0775b"}]}],"author":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2020-12-14 12:29:40.000000000","tz":0},"committer":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2020-12-14 12:31:40.000000000","tz":0},"subject":"Ensure \"keepalived\" is correcly disabled","message":"Ensure \"keepalived\" is correcly disabled\n\nTo stop a \"keepalived\" process, a SIGTERM signal is sent. This patch\nchecks if the process is not present in the system. If the instance\nis still running after a short time, a SIGKILL signal is sent.\n\nChange-Id: I2e784ea7e00c145135288bf309bb34ce311ac15c\nCloses-Bug: #1908057\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/f9a3e46b1aa623fd408e655bc0df1866c8858e4f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/f9a3e46b1aa623fd408e655bc0df1866c8858e4f"}]},"branch":"refs/heads/master"},"7466570a580d7e4a031eb47020f34b555f461aa9":{"kind":"REWORK","_number":2,"created":"2020-12-15 17:30:21.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/39/766939/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/39/766939/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/39/766939/2"}}},"commit":{"parents":[{"commit":"2d4b3aa119c4dcee73c8cbb4f964bb092ae0775b","subject":"Merge \"Delete HA metadata proxy PID and config with elevated privileges\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/2d4b3aa119c4dcee73c8cbb4f964bb092ae0775b"}]}],"author":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2020-12-14 12:29:40.000000000","tz":0},"committer":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2020-12-15 17:29:58.000000000","tz":0},"subject":"Ensure \"keepalived\" is correcly disabled","message":"Ensure \"keepalived\" is correcly disabled\n\nTo stop a \"keepalived\" process, a SIGTERM signal is sent. This patch\nchecks if the process is not present in the system. If the instance\nis still running after a short time, a SIGKILL signal is sent.\n\nChange-Id: I2e784ea7e00c145135288bf309bb34ce311ac15c\nCloses-Bug: #1908057\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/7466570a580d7e4a031eb47020f34b555f461aa9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/7466570a580d7e4a031eb47020f34b555f461aa9"}]},"branch":"refs/heads/master"},"2618acff516e5cfd2437dabf550cc3c3c7972b9f":{"kind":"REWORK","_number":3,"created":"2020-12-16 16:33:41.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/39/766939/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/39/766939/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/39/766939/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/39/766939/3"}}},"commit":{"parents":[{"commit":"2d4b3aa119c4dcee73c8cbb4f964bb092ae0775b","subject":"Merge \"Delete HA metadata proxy PID and config with elevated privileges\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/2d4b3aa119c4dcee73c8cbb4f964bb092ae0775b"}]}],"author":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2020-12-14 12:29:40.000000000","tz":0},"committer":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2020-12-16 16:33:01.000000000","tz":0},"subject":"Ensure \"keepalived\" is correcly disabled","message":"Ensure \"keepalived\" is correcly disabled\n\nTo stop a \"keepalived\" process, a SIGTERM signal is sent. This patch\nchecks if the process is not present in the system. If the instance\nis still running after a short time, a SIGKILL signal is sent.\n\nChange-Id: I2e784ea7e00c145135288bf309bb34ce311ac15c\nCloses-Bug: #1908057\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/2618acff516e5cfd2437dabf550cc3c3c7972b9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/2618acff516e5cfd2437dabf550cc3c3c7972b9f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}