)]}'
{"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e454537a08b789ea71158d80dcb2911794393d1e","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        net_name \u003d \u0027network1\u0027"},{"line_number":144,"context_line":"        self._make_network(self.fmt, net_name, True)"},{"line_number":145,"context_line":"        row_event \u003d WaitForDataPathBindingCreateEvent(net_name)"},{"line_number":146,"context_line":"        self.mech_driver._sb_ovn.idl.notify_handler.watch_event(row_event)"},{"line_number":147,"context_line":"        dp \u003d self.sb_api.db_find("},{"line_number":148,"context_line":"            \u0027Datapath_Binding\u0027,"},{"line_number":149,"context_line":"            (\u0027external_ids\u0027, \u0027\u003d\u0027, {\u0027name2\u0027: net_name})).execute()"}],"source_content_type":"text/x-python","patch_set":1,"id":"32b7c552_33843f3f","line":146,"updated":"2021-01-08 17:04:21.000000000","message":"The way WaitEvents usually work is:\n1. Create event\n2. Watch for event\n3. Do thing that causes the change (in this case I *think* _make_network())\n4. Call wait on the event().\n\nIf I\u0027m reading this right, it looks like this code is watching for the event after _make_network() is called and not calling row_event.wait().","commit_id":"eeebd5685621984f66500a7b469cad7e76edc6f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f4bc8248a3cef350ed0e3472d76dbec4cec68dd1","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        net_name \u003d \u0027network1\u0027"},{"line_number":144,"context_line":"        self._make_network(self.fmt, net_name, True)"},{"line_number":145,"context_line":"        row_event \u003d WaitForDataPathBindingCreateEvent(net_name)"},{"line_number":146,"context_line":"        self.mech_driver._sb_ovn.idl.notify_handler.watch_event(row_event)"},{"line_number":147,"context_line":"        dp \u003d self.sb_api.db_find("},{"line_number":148,"context_line":"            \u0027Datapath_Binding\u0027,"},{"line_number":149,"context_line":"            (\u0027external_ids\u0027, \u0027\u003d\u0027, {\u0027name2\u0027: net_name})).execute()"}],"source_content_type":"text/x-python","patch_set":1,"id":"18d8836c_8e12a03a","line":146,"in_reply_to":"32b7c552_33843f3f","updated":"2021-01-11 10:08:37.000000000","message":"You are right. I\u0027ll change this code not only here but in other places where we need to wait for a specific event.","commit_id":"eeebd5685621984f66500a7b469cad7e76edc6f0"}]}