)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"357dca4dd91c9c559fac93e6ae24fc985e1d14df","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Validate local_ip when ovs-agent starts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"local_ip gets validated when ovs-agent starts with netaddr.valid_ipv6()"},{"line_number":10,"context_line":"and netaddr.valid_ipv4(). If none of them match ovs-agent fails."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This prevents that invalid tunnel endpoints get synced via RPC"},{"line_number":13,"context_line":"inside the database. Which then needs to be removed manually from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVX%2F%2Fw0k%3D","line":10,"updated":"2014-02-28 13:42:07.000000000","message":"I don\u0027t think the commit message should say how the patch works with this level of detail.","commit_id":"d8d44a1ac1a2363497ae78259c34b3adc7da56d9"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"357dca4dd91c9c559fac93e6ae24fc985e1d14df","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This prevents that invalid tunnel endpoints get synced via RPC"},{"line_number":13,"context_line":"inside the database. Which then needs to be removed manually from"},{"line_number":14,"context_line":"the database. Since the sync is unidirectional."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also the local_ip verify check got moved out of the tunnel_types loop"},{"line_number":17,"context_line":"to verify only once the local_ip."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVX%2F%2FwsU%3D","line":14,"updated":"2014-02-28 13:42:07.000000000","message":"The English in these 3 lines could be improved. Maybe something like:\n\nThis prevents invalid tunnel endpoints being written to the database where they can then only be removed manually.","commit_id":"d8d44a1ac1a2363497ae78259c34b3adc7da56d9"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"357dca4dd91c9c559fac93e6ae24fc985e1d14df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the database. Since the sync is unidirectional."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also the local_ip verify check got moved out of the tunnel_types loop"},{"line_number":17,"context_line":"to verify only once the local_ip."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifc376ba8a43ca4cc4881a4563b578c8eb8aade6d"},{"line_number":20,"context_line":"Closes-Bug: 1284684"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVX%2F%2FwsM%3D","line":17,"updated":"2014-02-28 13:42:07.000000000","message":"see above","commit_id":"d8d44a1ac1a2363497ae78259c34b3adc7da56d9"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"89859bc06c9acc382909ff220e17324f9004d369","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1318,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specificed: %s\u0027), tun"},{"line_number":1319,"context_line":"            raise ValueError(msg)"},{"line_number":1320,"context_line":"        if not kwargs[\u0027local_ip\u0027]:"},{"line_number":1321,"context_line":"            msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1322,"context_line":"            raise ValueError(msg)"},{"line_number":1323,"context_line":"        if not netaddr.valid_ipv4(kwargs[\u0027local_ip\u0027]) \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FypI%3D","line":1320,"updated":"2014-02-28 08:49:53.000000000","message":"i think L1320-1327 could be extracted to _validate_local_ip() method","commit_id":"70347c149580c7bad9c2f9f38601a719c46524a7"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"cad2be31413e052a13849438f8ffad0a017730a7","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1318,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specificed: %s\u0027), tun"},{"line_number":1319,"context_line":"            raise ValueError(msg)"},{"line_number":1320,"context_line":"        if not kwargs[\u0027local_ip\u0027]:"},{"line_number":1321,"context_line":"            msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1322,"context_line":"            raise ValueError(msg)"},{"line_number":1323,"context_line":"        if not netaddr.valid_ipv4(kwargs[\u0027local_ip\u0027]) \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FybI%3D","line":1320,"in_reply_to":"AAAAVX%2F%2FypI%3D","updated":"2014-02-28 09:30:32.000000000","message":"Done","commit_id":"70347c149580c7bad9c2f9f38601a719c46524a7"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"89859bc06c9acc382909ff220e17324f9004d369","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"        if not kwargs[\u0027local_ip\u0027]:"},{"line_number":1321,"context_line":"            msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1322,"context_line":"            raise ValueError(msg)"},{"line_number":1323,"context_line":"        if not netaddr.valid_ipv4(kwargs[\u0027local_ip\u0027]) \\"},{"line_number":1324,"context_line":"           and not netaddr.valid_ipv6(kwargs[\u0027local_ip\u0027]):"},{"line_number":1325,"context_line":"            msg \u003d _(\u0027Tunneling requires a valid IPv4/IPv6 local_ip. Invalid \u0027"},{"line_number":1326,"context_line":"                    \u0027IPv4/IPv6 address: %s\u0027), kwargs[\u0027local_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fypo%3D","line":1323,"updated":"2014-02-28 08:49:53.000000000","message":"please use parenthesis instead of \\ for line continuations:\n if (not netaddr.valid_ipv4(kwargs[\u0027local_ip\u0027])\n     and not netaddr.valid_ipv6(kwargs[\u0027local_ip\u0027])):\n      ...","commit_id":"70347c149580c7bad9c2f9f38601a719c46524a7"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"cad2be31413e052a13849438f8ffad0a017730a7","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"        if not kwargs[\u0027local_ip\u0027]:"},{"line_number":1321,"context_line":"            msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1322,"context_line":"            raise ValueError(msg)"},{"line_number":1323,"context_line":"        if not netaddr.valid_ipv4(kwargs[\u0027local_ip\u0027]) \\"},{"line_number":1324,"context_line":"           and not netaddr.valid_ipv6(kwargs[\u0027local_ip\u0027]):"},{"line_number":1325,"context_line":"            msg \u003d _(\u0027Tunneling requires a valid IPv4/IPv6 local_ip. Invalid \u0027"},{"line_number":1326,"context_line":"                    \u0027IPv4/IPv6 address: %s\u0027), kwargs[\u0027local_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FybE%3D","line":1323,"in_reply_to":"AAAAVX%2F%2Fypo%3D","updated":"2014-02-28 09:30:32.000000000","message":"Done","commit_id":"70347c149580c7bad9c2f9f38601a719c46524a7"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"357dca4dd91c9c559fac93e6ae24fc985e1d14df","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"    if not local_ip:"},{"line_number":1289,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1290,"context_line":"        raise ValueError(msg)"},{"line_number":1291,"context_line":"    if (not netaddr.valid_ipv4(local_ip) and not netaddr.valid_ipv6(local_ip)):"},{"line_number":1292,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4/IPv6 local_ip. Invalid \u0027"},{"line_number":1293,"context_line":"                \u0027IPv4/IPv6 address: %s\u0027), local_ip"},{"line_number":1294,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2Fw1k%3D","line":1291,"updated":"2014-02-28 13:42:07.000000000","message":"Are you sure IPv6 can be used for tunnel endpoints? I\u0027m 99% sure that it can\u0027t (I just never tried it).  http://openvswitch.org/ovs-vswitchd.conf.db.5.pdf","commit_id":"d8d44a1ac1a2363497ae78259c34b3adc7da56d9"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"357dca4dd91c9c559fac93e6ae24fc985e1d14df","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"    #  test_create_agent_config_map_fails_for_invalid_tunnel_config"},{"line_number":1338,"context_line":"    #"},{"line_number":1339,"context_line":"    # is testing this behaviour (unintended?). To avoid regression of existing"},{"line_number":1340,"context_line":"    # deployments we try to keep this existing behaviour."},{"line_number":1341,"context_line":"    if kwargs[\u0027tunnel_types\u0027]:"},{"line_number":1342,"context_line":"        _validate_local_ip(kwargs[\u0027local_ip\u0027])"},{"line_number":1343,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2Fw6Q%3D","line":1340,"updated":"2014-02-28 13:42:07.000000000","message":"I think this behaviour is ok, although confusing. See L206-209. So this comment can be removed.","commit_id":"d8d44a1ac1a2363497ae78259c34b3adc7da56d9"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"51333a1b7910747ed4878d23c3943b18abaeb581","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specificed: %s\u0027), tun"},{"line_number":1329,"context_line":"            raise ValueError(msg)"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"    # NOTE(dgollub): I would have guessed that we only need to verify local_ip"},{"line_number":1332,"context_line":"    # when config.OVS.enable_tunneling is set, but it is/was possible to"},{"line_number":1333,"context_line":"    # configure local_ip and tunnel_types even without setting"},{"line_number":1334,"context_line":"    # enable_tunneling."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2FwOM%3D","line":1331,"updated":"2014-02-28 14:51:36.000000000","message":"enable_tunneling is redundant and we actually were looking to deprecate it at some point. The idea is, if you configure a local_ip and/or tunnel_types you want tunneling enabled. Can you remove this NOTE here based on this info?","commit_id":"7895bf9093d276482793219070f5a31680a941ab"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"f4cb670d4b75347cd0102e06c0942b5fad52ca4d","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specificed: %s\u0027), tun"},{"line_number":1329,"context_line":"            raise ValueError(msg)"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"    # NOTE(dgollub): I would have guessed that we only need to verify local_ip"},{"line_number":1332,"context_line":"    # when config.OVS.enable_tunneling is set, but it is/was possible to"},{"line_number":1333,"context_line":"    # configure local_ip and tunnel_types even without setting"},{"line_number":1334,"context_line":"    # enable_tunneling."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2FwGw%3D","line":1331,"in_reply_to":"AAAAVX%2F%2FwOM%3D","updated":"2014-02-28 15:06:58.000000000","message":"Done","commit_id":"7895bf9093d276482793219070f5a31680a941ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"7a453d64ae9901b1e1ad3f646fd311e1a030ab97","unresolved":false,"context_lines":[{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"def _validate_local_ip(local_ip):"},{"line_number":1288,"context_line":"    if not local_ip:"},{"line_number":1289,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1290,"context_line":"        raise ValueError(msg)"},{"line_number":1291,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1292,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2F%2F0w%3D","line":1289,"updated":"2014-03-02 19:00:22.000000000","message":"\"local ip\" might have been better","commit_id":"741054b16b8ca87247ed026006ffd382672b0d88"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ce180a4044ee8e729ec27496e207edd1db7f912e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"import signal"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Bzek%3D","line":17,"updated":"2014-03-24 07:49:27.000000000","message":"netaddr is third party module. Please move it to L.23.","commit_id":"c11aa6e9621e16bdd457f34b466bb9ea37b804af"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b8726ccbf775316b31a6fe868f043543ad2c3f96","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"    if not local_ip:"},{"line_number":1258,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local ip.\u0027)"},{"line_number":1259,"context_line":"        raise ValueError(msg)"},{"line_number":1260,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1261,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1262,"context_line":"                \u0027address: %s\u0027), local_ip"},{"line_number":1263,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2Fzb4%3D","line":1260,"updated":"2014-03-04 01:55:41.000000000","message":"What if the local IP is IPv6? This will prevent neutron agent starting from pure IPv6 management network. Suggest to validate both valid IPv4 and IPv6 address.","commit_id":"c11aa6e9621e16bdd457f34b466bb9ea37b804af"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"3fd649bc2d7c919021e469da74ae24e816ebb5c8","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"    if not local_ip:"},{"line_number":1258,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local ip.\u0027)"},{"line_number":1259,"context_line":"        raise ValueError(msg)"},{"line_number":1260,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1261,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1262,"context_line":"                \u0027address: %s\u0027), local_ip"},{"line_number":1263,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2BznE%3D","line":1260,"in_reply_to":"AAAAVn%2F%2Fzb4%3D","updated":"2014-03-24 07:08:47.000000000","message":"The initial patch (patchset 1) checked for both.\n\nDuring review for this gerrit-changeset it turned out that OVS does not seem to support yet IPv6 yet for VXLAN/GRE tunnels\n\nSo we decided to not make IPv6 a valid IP address until there is OVS supports IPv6 for tunnels.\n\nThanks.","commit_id":"c11aa6e9621e16bdd457f34b466bb9ea37b804af"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ce180a4044ee8e729ec27496e207edd1db7f912e","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"    if not local_ip:"},{"line_number":1258,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local ip.\u0027)"},{"line_number":1259,"context_line":"        raise ValueError(msg)"},{"line_number":1260,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1261,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1262,"context_line":"                \u0027address: %s\u0027), local_ip"},{"line_number":1263,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Bzes%3D","line":1260,"in_reply_to":"AAAAWH%2F%2BznE%3D","updated":"2014-03-24 07:49:27.000000000","message":"It is worth commented in the code. IPv6 support for tunnel is not available yet in ovs-agent.","commit_id":"c11aa6e9621e16bdd457f34b466bb9ea37b804af"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ab9ba2be1200ad6ace020c0d8f905df0cf38c9d7","unresolved":false,"context_lines":[{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1306,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1307,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1308,"context_line":"                \u0027address: %s\u0027), local_ip"},{"line_number":1309,"context_line":"        raise ValueError(msg)"},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BXtk%3D","line":1307,"updated":"2014-03-27 09:55:19.000000000","message":"that needs to be a string substitution, don\u0027t mix with preferred way of passing parametes to logging methods","commit_id":"b1b3c809ec7d74f7ed500049a56d98508e403774"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"90e16da490d8b76229836e7c4997e156c1526daa","unresolved":false,"context_lines":[{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1306,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1307,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1308,"context_line":"                \u0027address: %s\u0027), local_ip"},{"line_number":1309,"context_line":"        raise ValueError(msg)"},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2F78I%3D","line":1307,"in_reply_to":"AAAAWH%2F%2BXtk%3D","updated":"2014-04-09 11:31:54.000000000","message":"Done","commit_id":"b1b3c809ec7d74f7ed500049a56d98508e403774"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"58a3415e7ff342f5d8d3c95386743aa5618b12a7","unresolved":false,"context_lines":[{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1306,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1307,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1308,"context_line":"                \u0027address: %s\u0027), local_ip"},{"line_number":1309,"context_line":"        raise ValueError(msg)"},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BSSs%3D","line":1307,"in_reply_to":"AAAAWH%2F%2BXtk%3D","updated":"2014-03-27 20:55:09.000000000","message":"I am bit lost here - could you give me a quick example what you mean exactly here by string substation? Thanks.","commit_id":"b1b3c809ec7d74f7ed500049a56d98508e403774"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"153a6512448e0336b5967eec335b042d0f12304e","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %s\u0027) % local_ip"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAW3%2F%2F7oQ%3D","line":1307,"updated":"2014-04-09 12:17:47.000000000","message":"You don\u0027t need the \u0027%\u0027 but just a comma\n\nmsg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027\n               \u0027address: %s\u0027), local_ip","commit_id":"8585a2607a60ccc0d2163fd988e66d52399c50eb"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"209dffe4ec857dd1f56545443b59dfbdbb9fb1ef","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %s\u0027) % local_ip"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAW3%2F%2F7B0%3D","line":1307,"in_reply_to":"AAAAW3%2F%2F7Ww%3D","updated":"2014-04-09 13:27:01.000000000","message":"Done","commit_id":"8585a2607a60ccc0d2163fd988e66d52399c50eb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"90f017b6122d0918750f95fb3636c641e851ba5a","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %s\u0027) % local_ip"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAW3%2F%2F7Qc%3D","line":1307,"in_reply_to":"AAAAW3%2F%2F7oQ%3D","updated":"2014-04-09 13:05:10.000000000","message":"Comma can only be used when the message is an argument to a log.","commit_id":"8585a2607a60ccc0d2163fd988e66d52399c50eb"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9a2358438c2a09faef40d74ddedc2d767d02937e","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %s\u0027) % local_ip"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAW3%2F%2F7Ww%3D","line":1307,"in_reply_to":"AAAAW3%2F%2F7oQ%3D","updated":"2014-04-09 12:54:00.000000000","message":"You should use:\n\nmsg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027\n\u0027address: %(local_ip)s\u0027) % {\u0027local_ip\u0027: local_ip}\n\nThen translators have a better context what they have to translate.","commit_id":"8585a2607a60ccc0d2163fd988e66d52399c50eb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e65bcc07d8d2eed119241c205ba91b8b18583fc5","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"def _validate_local_ip(local_ip):"},{"line_number":1300,"context_line":"    if not local_ip:"},{"line_number":1301,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local ip.\u0027)"},{"line_number":1302,"context_line":"        raise ValueError(msg)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAW3%2F%2Fi3Y%3D","line":1302,"updated":"2014-04-13 06:13:51.000000000","message":"any reason not to raise a neutron exception here?","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"72dd1bdd9b356a83c793ce78e2417961522607a1","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"def _validate_local_ip(local_ip):"},{"line_number":1300,"context_line":"    if not local_ip:"},{"line_number":1301,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local ip.\u0027)"},{"line_number":1302,"context_line":"        raise ValueError(msg)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAW3%2F%2Fiyg%3D","line":1302,"in_reply_to":"AAAAW3%2F%2Fi3Y%3D","updated":"2014-04-13 06:58:47.000000000","message":"The entire ovs_neutron_agent.py was not holding a neutron-exception, but ValueError exceptions - so I thought it is a good idea to keep things aligned.\nMaybe this could be done with a separated clean-up ticket? Changing all the ValueError to a neutron exception?","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2df2c27b0ca5203294749af3243a65e38a391a89","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"def _validate_local_ip(local_ip):"},{"line_number":1300,"context_line":"    if not local_ip:"},{"line_number":1301,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local ip.\u0027)"},{"line_number":1302,"context_line":"        raise ValueError(msg)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAW3%2F%2FhGA%3D","line":1302,"in_reply_to":"AAAAW3%2F%2Fiyg%3D","updated":"2014-04-14 02:17:28.000000000","message":"I think raising ValueError is okay in this case because it is used throughout the logic of checking configuration parameters.","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d10e7d9cdd3fc3936d76b080d5936b13c44eab4","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %(local_ip)s\u0027) % {\u0027local_ip\u0027: local_ip}"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAW3%2F%2F3ng%3D","line":1307,"updated":"2014-04-09 19:44:40.000000000","message":"Nit: %(local_ip)s -\u003e %s    because there is only one substitution.","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"72dd1bdd9b356a83c793ce78e2417961522607a1","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %(local_ip)s\u0027) % {\u0027local_ip\u0027: local_ip}"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAW3%2F%2FizQ%3D","line":1307,"in_reply_to":"AAAAW3%2F%2F3ng%3D","updated":"2014-04-13 06:58:47.000000000","message":"Tom asked me to put %(local_ip)s to keep a context for translators.","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"f3723712d54ed4fbae97c980f2d42f57b24eca48","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %(local_ip)s\u0027) % {\u0027local_ip\u0027: local_ip}"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_ee1c3a6d","line":1307,"in_reply_to":"AAAAW3%2F%2FhGI%3D","updated":"2014-10-19 12:43:59.000000000","message":"+1","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2df2c27b0ca5203294749af3243a65e38a391a89","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"    # IPv6 support for tunnel is not available yet in ovs-agent"},{"line_number":1305,"context_line":"    if not netaddr.valid_ipv4(local_ip):"},{"line_number":1306,"context_line":"        msg \u003d _(\u0027Tunneling requires a valid IPv4 local_ip. Invalid IPv4 \u0027"},{"line_number":1307,"context_line":"                \u0027address: %(local_ip)s\u0027) % {\u0027local_ip\u0027: local_ip}"},{"line_number":1308,"context_line":"        raise ValueError(msg)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAW3%2F%2FhGI%3D","line":1307,"in_reply_to":"AAAAW3%2F%2FizQ%3D","updated":"2014-04-14 02:17:28.000000000","message":"Using %s when we have a single substitution is recommended in OpenStack Hacking Guide: \nhttp://docs.openstack.org/developer/hacking/#internationalization-i18n-strings","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"20a3e4ddad848014e7432fb1438525bbb14a0bf3","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"            raise ValueError(msg)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    if kwargs[\u0027tunnel_types\u0027]:"},{"line_number":1346,"context_line":"        _validate_local_ip(kwargs[\u0027local_ip\u0027])"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"    return kwargs"},{"line_number":1349,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXX%2F%2F%2Be8%3D","line":1346,"updated":"2014-04-24 22:09:17.000000000","message":"This is not the correct place to do this.  We should create an IPv4 address type for the actual config option.","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"39e6814acfd0cb364d178801355ae5a12b7fcd7c","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"            raise ValueError(msg)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    if kwargs[\u0027tunnel_types\u0027]:"},{"line_number":1346,"context_line":"        _validate_local_ip(kwargs[\u0027local_ip\u0027])"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"    return kwargs"},{"line_number":1349,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad9bd40_df495732","line":1346,"in_reply_to":"AAAAXX%2F%2F%2Be8%3D","updated":"2014-05-06 16:38:08.000000000","message":"Based on this I proposed patch to oslo.config https://review.openstack.org/#/c/92396/3 implementing IP address options.","commit_id":"3beec2324d1f2031ec6c32c829e269c8cb5e82db"}],"neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"7a453d64ae9901b1e1ad3f646fd311e1a030ab97","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_create_agent_config_map_fails_for_invalid_localip_netaddr(self):"},{"line_number":79,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":80,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, None, group\u003d\u0027AGENT\u0027)"},{"line_number":81,"context_line":"        cfg.CONF.set_override(\u0027enable_tunneling\u0027, True, group\u003d\u0027OVS\u0027)"},{"line_number":82,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.256\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2F%2F2A%3D","line":79,"updated":"2014-03-02 19:00:22.000000000","message":"I believe this is being done in the setUp of the base class so it\u0027s not required. However, this is probably a bigger clean up across this module and others.","commit_id":"741054b16b8ca87247ed026006ffd382672b0d88"},{"author":{"_account_id":6670,"name":"Amir Sadoughi","email":"amir.sadoughi@rackspace.com","username":"amir-sadoughi"},"change_message_id":"20df5a3b7b01ca41d8b3a2f37282319d5df24901","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.256\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":83,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":84,"context_line":"            ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_agent_config_map_multiple_tunnel_types(self):"},{"line_number":87,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":88,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.10\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2FvQc%3D","line":85,"updated":"2014-02-28 16:55:09.000000000","message":"I\u0027d like to see an additional UT for a missing local_ip.","commit_id":"741054b16b8ca87247ed026006ffd382672b0d88"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"305e52729cd3f1ff9275aba2ed5731eeaa86a25c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.256\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":83,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":84,"context_line":"            ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_agent_config_map_multiple_tunnel_types(self):"},{"line_number":87,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":88,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.10\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2FrUg%3D","line":85,"in_reply_to":"AAAAVX%2F%2FvQc%3D","updated":"2014-03-01 06:07:24.000000000","message":"There are already two tests to check for a missing local_ip:\n\n---8\u003c---\n    def test_create_agent_config_map_fails_for_invalid_tunnel_config(self):\n        self.addCleanup(cfg.CONF.reset)\n        # An ip address is required for tunneling but there is no default,\n        # verify this for both gre and vxlan tunnels.\n        cfg.CONF.set_override(\u0027tunnel_types\u0027, [p_const.TYPE_GRE],\n                              group\u003d\u0027AGENT\u0027)\n        with testtools.ExpectedException(ValueError):\n            ovs_neutron_agent.create_agent_config_map(cfg.CONF)\n        cfg.CONF.set_override(\u0027tunnel_types\u0027, [p_const.TYPE_VXLAN],\n                              group\u003d\u0027AGENT\u0027)\n        with testtools.ExpectedException(ValueError):\n            ovs_neutron_agent.create_agent_config_map(cfg.CONF)\n[....]\n    def test_create_agent_config_map_fails_no_local_ip(self):\n        self.addCleanup(cfg.CONF.reset)\n        # An ip address is required for tunneling but there is no default\n        cfg.CONF.set_override(\u0027enable_tunneling\u0027, True, group\u003d\u0027OVS\u0027)\n        with testtools.ExpectedException(ValueError):\n            ovs_neutron_agent.create_agent_config_map(cfg.CONF)\n----\u003e8----\n\nThe only missing configuration combination I could be thing of would be:\n\n# enable_tunneling set and tunnel_types\nself.addCleanup(cfg.CONF.reset)\ncfg.CONF.set_override(\u0027enable_tunneling\u0027, True, group\u003d\u0027OVS\u0027)\ncfg.CONF.set_override(\u0027tunnel_types\u0027, [\u0027GRE\u0027], group\u003d\u0027AGENT\u0027) # default tunnel type\n\nBut this would be pretty much the same as: test_create_agent_config_map_fails_for_invalid_tunnel_config\n(since for enable_tunneling there are discussions to make it obsolete anyway)\n\n\nMaybe I missed something ... if so let me know ...\n\n\nThanks for reviewing!","commit_id":"741054b16b8ca87247ed026006ffd382672b0d88"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ce180a4044ee8e729ec27496e207edd1db7f912e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":80,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, None, group\u003d\u0027AGENT\u0027)"},{"line_number":81,"context_line":"        cfg.CONF.set_override(\u0027enable_tunneling\u0027, True, group\u003d\u0027OVS\u0027)"},{"line_number":82,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.256\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":83,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":84,"context_line":"            ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Bzd4%3D","line":82,"updated":"2014-03-24 07:49:27.000000000","message":"It looks better we have a case for IPv6 address too.","commit_id":"c11aa6e9621e16bdd457f34b466bb9ea37b804af"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"0ff0756b6bc35dc64a41a7667c90765b1d0308ca","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_create_agent_config_map_fails_for_invalid_localip_netaddr(self):"},{"line_number":75,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":76,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, None, group\u003d\u0027AGENT\u0027)"},{"line_number":77,"context_line":"        cfg.CONF.set_override(\u0027enable_tunneling\u0027, True, group\u003d\u0027OVS\u0027)"},{"line_number":78,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.256\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BzJY%3D","line":75,"updated":"2014-03-24 11:39:50.000000000","message":"I do not think you need addCleanup(cfg.CONF.reset)","commit_id":"43deee58571030e06e5a348379b4e8653501bc59"},{"author":{"_account_id":7909,"name":"Daniel Gollub","email":"dgollub@brocade.com","username":"dgollub"},"change_message_id":"1e10724d5abf2baea8d454ee3e819652d41330ad","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_create_agent_config_map_fails_for_invalid_localip_netaddr(self):"},{"line_number":75,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":76,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, None, group\u003d\u0027AGENT\u0027)"},{"line_number":77,"context_line":"        cfg.CONF.set_override(\u0027enable_tunneling\u0027, True, group\u003d\u0027OVS\u0027)"},{"line_number":78,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.256\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2ByMY%3D","line":75,"in_reply_to":"AAAAWH%2F%2BzJY%3D","updated":"2014-03-24 11:44:41.000000000","message":"Done","commit_id":"43deee58571030e06e5a348379b4e8653501bc59"}]}
