)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"06d69455a915f24998973f70d999d59faf5c7393","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     56bea066 (Merge \"Do not report ovs agent state if ovs is dead\")"},{"line_number":2,"context_line":"Author:     zhouhenglc \u003czhouhenglc@inspur.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2021-01-18 09:15:50 +0800"},{"line_number":4,"context_line":"Commit:     zhouhenglc \u003czhouhenglc@inspur.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"88334234_552c2a1f","line":1,"updated":"2021-01-20 21:46:17.000000000","message":"A NIT about this comment does not add up. Could it be that you are missing this fix in ovsdbapp library:  https://github.com/openstack/ovsdbapp/commit/8cb3b56fa9022254d60a15125f86f6e8a7e16041   ?\n\nDangling weak references should automatically be cleaned up.","commit_id":"646be8843a86412063910af486b9a9970c752e72"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ac6669870de60db09ba709ad842be696eda3b497","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the last vip is deleted, the load balancer will be deleted."},{"line_number":10,"context_line":"However, router has weak ref to the lb, it will cause deletion to"},{"line_number":11,"context_line":"fail, causing transaction execution failure, and vip will not be"},{"line_number":12,"context_line":"deleted, resulting in vip residue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"At present, when there is no port forwarding in the floating IP, will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b225318c_02cde9b0","line":11,"updated":"2021-01-20 21:53:05.000000000","message":"As flavio mentions, from ovsdb rfc https://tools.ietf.org/html/rfc7047#section-3.2 :\n\n    If \"refType\" is \"weak\", then any UUIDs are allowed, but\n    UUIDs that do not correspond to rows in the named table will\n    be automatically deleted.  When this situation arises in a\n    map, both the key and the value will be deleted from the\n    map.\n\nSo it seems like that lb reference should disappear if the lb is deleted.","commit_id":"646be8843a86412063910af486b9a9970c752e72"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"3818070a415da992b791e3dd69c0690d36d7416c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the last vip is deleted, the load balancer will be deleted."},{"line_number":10,"context_line":"However, router has weak ref to the lb, it will cause deletion to"},{"line_number":11,"context_line":"fail, causing transaction execution failure, and vip will not be"},{"line_number":12,"context_line":"deleted, resulting in vip residue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"At present, when there is no port forwarding in the floating IP, will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e64e8856_1a811be7","line":11,"in_reply_to":"b225318c_02cde9b0","updated":"2021-01-21 00:24:22.000000000","message":"thanks Terry, The problematic version of ovn is 2.11. After testing, the new version(20.09 20.12) of ovn is no problem. It\u0027s really a weak ref.","commit_id":"646be8843a86412063910af486b9a9970c752e72"}],"neutron/services/portforwarding/drivers/ovn/driver.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"faa5d70ac6be7a59e48bd72c3ed4a3f96b90a6b2","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                        context, pf_payload.original_pf.floatingip_id)"},{"line_number":192,"context_line":"                    self._handler.port_forwarding_deleted(ovn_txn, ovn_nb,"},{"line_number":193,"context_line":"                        pf_payload.original_pf,"},{"line_number":194,"context_line":"                        dissociate_router\u003dnot pfs)"},{"line_number":195,"context_line":"                    if not pfs:"},{"line_number":196,"context_line":"                        self._l3_plugin.update_floatingip_status("},{"line_number":197,"context_line":"                            context, pf_payload.original_pf.floatingip_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f92ef4ea_865853fb","line":194,"range":{"start_line":194,"start_character":42,"end_line":194,"end_character":49},"updated":"2021-01-20 22:23:07.000000000","message":"NIT: It is possible that all UDP PFs are removed, but not all TCP PFs for the same FIP are removed -- or vice versa. In such cases, you may also want to dissociate the LB for the protocol that is no longer used. So there is a corner case here where dissociate_router should be True for one of the 2 protocols. Take a look at _get_lb_attributes() for how the lb_name is derived.\nIt is very possible that if this is not working for you, you are missing the ovsdbapp fixes for \nLbDelCommand, in https://github.com/openstack/ovsdbapp/commit/8cb3b56fa9022254d60a15125f86f6e8a7e16041","commit_id":"646be8843a86412063910af486b9a9970c752e72"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"b0dc0b9b04110341c502a05871ddcfbc58c3f511","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                        context, pf_payload.original_pf.floatingip_id)"},{"line_number":192,"context_line":"                    self._handler.port_forwarding_deleted(ovn_txn, ovn_nb,"},{"line_number":193,"context_line":"                        pf_payload.original_pf,"},{"line_number":194,"context_line":"                        dissociate_router\u003dnot pfs)"},{"line_number":195,"context_line":"                    if not pfs:"},{"line_number":196,"context_line":"                        self._l3_plugin.update_floatingip_status("},{"line_number":197,"context_line":"                            context, pf_payload.original_pf.floatingip_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cef6d558_f338e5b9","line":194,"range":{"start_line":194,"start_character":42,"end_line":194,"end_character":49},"in_reply_to":"6712af71_b883bdb7","updated":"2021-01-21 19:25:06.000000000","message":"cool beans! Thank _you_ for looking at this.","commit_id":"646be8843a86412063910af486b9a9970c752e72"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"3818070a415da992b791e3dd69c0690d36d7416c","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                        context, pf_payload.original_pf.floatingip_id)"},{"line_number":192,"context_line":"                    self._handler.port_forwarding_deleted(ovn_txn, ovn_nb,"},{"line_number":193,"context_line":"                        pf_payload.original_pf,"},{"line_number":194,"context_line":"                        dissociate_router\u003dnot pfs)"},{"line_number":195,"context_line":"                    if not pfs:"},{"line_number":196,"context_line":"                        self._l3_plugin.update_floatingip_status("},{"line_number":197,"context_line":"                            context, pf_payload.original_pf.floatingip_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6712af71_b883bdb7","line":194,"range":{"start_line":194,"start_character":42,"end_line":194,"end_character":49},"in_reply_to":"f92ef4ea_865853fb","updated":"2021-01-21 00:24:22.000000000","message":"thanks Flavio, After testing, the new version(20.09, 20.12) of ovn, The problem does not recur.","commit_id":"646be8843a86412063910af486b9a9970c752e72"}]}