)]}'
{"neutron/db/dns_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"acf145026fdd2826913ec1ea3a0cddd32743fcd3","unresolved":true,"context_lines":[{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            self._delete_floatingip_from_external_dns_service("},{"line_number":192,"context_line":"                context, None, None,"},{"line_number":193,"context_line":"                [floatingip_data[\u0027floating_ip_address\u0027]])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _validate_floatingip_dns(self, dns_name, dns_domain):"},{"line_number":196,"context_line":"        if dns_domain and not dns_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d65f9608_1bc70513","line":193,"updated":"2021-01-21 10:24:21.000000000","message":"just nit: IMHO easier to read would be something like:\n\n    dns_domain \u003d None\n    dns_name \u003d None\n    if dns_data_db:\n        dns_domain \u003d dns_data_db[\u0027published_dns_domain\u0027]\n        dns_name \u003d dns_data_db[\u0027published_dns_name\u0027]\n    self._delete_floatingip_from_external_dns_service(\n        context, dns_domain, dns_name,\n        [floatingip_data[\u0027floating_ip_address\u0027]])","commit_id":"0cecef10cd59b0377ec29a4f0e4d09ebe761ee01"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8f1c90be7b2724a4c233ed2c13631afc950bb6fa","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            self._delete_floatingip_from_external_dns_service("},{"line_number":192,"context_line":"                context, None, None,"},{"line_number":193,"context_line":"                [floatingip_data[\u0027floating_ip_address\u0027]])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _validate_floatingip_dns(self, dns_name, dns_domain):"},{"line_number":196,"context_line":"        if dns_domain and not dns_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d28cc92_4d9201d8","line":193,"in_reply_to":"d65f9608_1bc70513","updated":"2021-01-22 06:23:22.000000000","message":"Done","commit_id":"0cecef10cd59b0377ec29a4f0e4d09ebe761ee01"}],"neutron/services/externaldns/drivers/designate/driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"acf145026fdd2826913ec1ea3a0cddd32743fcd3","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                                   endpoint_override\u003dCONF.designate.url,"},{"line_number":91,"context_line":"                                   all_projects\u003dTrue,"},{"line_number":92,"context_line":"                                   edit_managed\u003dedit_managed)"},{"line_number":93,"context_line":"    return client, admin_client"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class Designate(driver.ExternalDNSService):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b72b3_ea1cef05","line":93,"updated":"2021-01-21 10:24:21.000000000","message":"this function is almost the same as function above, the only difference is that here You are passing \"all_projects\" and \"edit_managed\" parameters to d_client.Client().\nMaybe You can refactor above function to add those parameters there and then use same function in all cases?","commit_id":"0cecef10cd59b0377ec29a4f0e4d09ebe761ee01"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8f1c90be7b2724a4c233ed2c13631afc950bb6fa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                   endpoint_override\u003dCONF.designate.url,"},{"line_number":91,"context_line":"                                   all_projects\u003dTrue,"},{"line_number":92,"context_line":"                                   edit_managed\u003dedit_managed)"},{"line_number":93,"context_line":"    return client, admin_client"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class Designate(driver.ExternalDNSService):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0efe5942_dda3dca6","line":93,"in_reply_to":"da9b72b3_ea1cef05","updated":"2021-01-22 06:23:22.000000000","message":"Done","commit_id":"0cecef10cd59b0377ec29a4f0e4d09ebe761ee01"}]}