)]}'
{"neutron/tests/unit/extensions/test_floating_ip_port_forwarding.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4ea895ad3dbfe4da08c893a3060a13c67bad2342","unresolved":true,"context_lines":[{"line_number":77,"context_line":"                                    external_port\u003dNone,"},{"line_number":78,"context_line":"                                    internal_port\u003dNone,"},{"line_number":79,"context_line":"                                    protocol\u003dNone,"},{"line_number":80,"context_line":"                                    internal_ip_address\u003dNone,"},{"line_number":81,"context_line":"                                    internal_port_id\u003dNone,"},{"line_number":82,"context_line":"                                    tenant_id\u003dNone, description\u003dNone):"},{"line_number":83,"context_line":"        tenant_id \u003d tenant_id or _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4ef8ca0_a5d4183b","line":80,"updated":"2021-01-21 15:26:52.000000000","message":"Think this should just be **kwargs for all the optional arguments, then below something like:\n\nfor k, v in kwargs.items():\n    port_forwarding[k] \u003d v\n\nThere might even be some more pythonic way to do that.\n\nThat way anything can be passed and this code never needs to change to support a new value.","commit_id":"824c98a0671d7b399e788f919f9fd25129ad618e"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"b2cc5e7917cc6c5607f09b3f5dab62ae3805bdef","unresolved":true,"context_lines":[{"line_number":77,"context_line":"                                    external_port\u003dNone,"},{"line_number":78,"context_line":"                                    internal_port\u003dNone,"},{"line_number":79,"context_line":"                                    protocol\u003dNone,"},{"line_number":80,"context_line":"                                    internal_ip_address\u003dNone,"},{"line_number":81,"context_line":"                                    internal_port_id\u003dNone,"},{"line_number":82,"context_line":"                                    tenant_id\u003dNone, description\u003dNone):"},{"line_number":83,"context_line":"        tenant_id \u003d tenant_id or _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9dee9f57_1d092279","line":80,"in_reply_to":"d4ef8ca0_a5d4183b","updated":"2021-01-22 12:02:40.000000000","message":"thx","commit_id":"824c98a0671d7b399e788f919f9fd25129ad618e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4ea895ad3dbfe4da08c893a3060a13c67bad2342","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                                    internal_ip_address\u003dNone,"},{"line_number":81,"context_line":"                                    internal_port_id\u003dNone,"},{"line_number":82,"context_line":"                                    tenant_id\u003dNone, description\u003dNone):"},{"line_number":83,"context_line":"        tenant_id \u003d tenant_id or _uuid()"},{"line_number":84,"context_line":"        port_forwarding \u003d {}"},{"line_number":85,"context_line":"        if external_port:"},{"line_number":86,"context_line":"            port_forwarding[\u0027external_port\u0027] \u003d external_port"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6e101a5_7d5ee45f","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":40},"updated":"2021-01-21 15:26:52.000000000","message":"Shouldn\u0027t this be the tenant_id from the created object?  Or is it even required since this is a PUT?","commit_id":"824c98a0671d7b399e788f919f9fd25129ad618e"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"b2cc5e7917cc6c5607f09b3f5dab62ae3805bdef","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                                    internal_ip_address\u003dNone,"},{"line_number":81,"context_line":"                                    internal_port_id\u003dNone,"},{"line_number":82,"context_line":"                                    tenant_id\u003dNone, description\u003dNone):"},{"line_number":83,"context_line":"        tenant_id \u003d tenant_id or _uuid()"},{"line_number":84,"context_line":"        port_forwarding \u003d {}"},{"line_number":85,"context_line":"        if external_port:"},{"line_number":86,"context_line":"            port_forwarding[\u0027external_port\u0027] \u003d external_port"}],"source_content_type":"text/x-python","patch_set":1,"id":"83aea28c_fb6efbea","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":40},"in_reply_to":"c6e101a5_7d5ee45f","updated":"2021-01-22 12:02:40.000000000","message":"Oh, this is my mistake, it is redundant.","commit_id":"824c98a0671d7b399e788f919f9fd25129ad618e"}]}