)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b0d499cee12ef878684bd8f1eea506e4e7f81a2c","unresolved":true,"context_lines":[{"line_number":2033,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", detail[\u0027device\u0027])"},{"line_number":2034,"context_line":"        return failed_devices"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    # TODO(uchenily): this method is no longer used since skipped devices has"},{"line_number":2037,"context_line":"    # been merged into port_info[\u0027removed\u0027], we may delete this code in future."},{"line_number":2038,"context_line":"    def treat_devices_skipped(self, devices):"},{"line_number":2039,"context_line":"        LOG.info(\"Ports %s skipped, changing status to down\", devices)"},{"line_number":2040,"context_line":"        devices_down \u003d self.plugin_rpc.update_device_list(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fcbb00f_093fbac0","line":2037,"range":{"start_line":2036,"start_character":4,"end_line":2037,"end_character":79},"updated":"2021-01-22 06:04:12.000000000","message":"I think the method should be removed as part of this patch, so we\u0027ll clearly see it\u0027s not used and CI is ok with that.","commit_id":"0f59779cbd848e29afbcf6837f1c612a43f59f16"},{"author":{"_account_id":30744,"name":"uchenily","email":"uchenily@gmail.com","username":"uchenily"},"change_message_id":"886167952444cd7afd3e0554fa0f6069fcc01adb","unresolved":false,"context_lines":[{"line_number":2033,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", detail[\u0027device\u0027])"},{"line_number":2034,"context_line":"        return failed_devices"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    # TODO(uchenily): this method is no longer used since skipped devices has"},{"line_number":2037,"context_line":"    # been merged into port_info[\u0027removed\u0027], we may delete this code in future."},{"line_number":2038,"context_line":"    def treat_devices_skipped(self, devices):"},{"line_number":2039,"context_line":"        LOG.info(\"Ports %s skipped, changing status to down\", devices)"},{"line_number":2040,"context_line":"        devices_down \u003d self.plugin_rpc.update_device_list(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"87e16359_0c3849c0","line":2037,"range":{"start_line":2036,"start_character":4,"end_line":2037,"end_character":79},"in_reply_to":"4fcbb00f_093fbac0","updated":"2021-01-22 10:26:02.000000000","message":"Done","commit_id":"0f59779cbd848e29afbcf6837f1c612a43f59f16"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b0d499cee12ef878684bd8f1eea506e4e7f81a2c","unresolved":true,"context_lines":[{"line_number":982,"context_line":"            self.assertEqual("},{"line_number":983,"context_line":"                ([\u0027the_skipped_one\u0027], set(), [], set(), set(), set()),"},{"line_number":984,"context_line":"                skip_devs)"},{"line_number":985,"context_line":"            ext_mgr_delete_port.assert_called_once_with("},{"line_number":986,"context_line":"                self.agent.context, {\u0027port_id\u0027: \u0027the_skipped_one\u0027})"},{"line_number":987,"context_line":"            treat_vif_port.assert_not_called()"},{"line_number":988,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"16a853a3_459e2f29","side":"PARENT","line":985,"range":{"start_line":985,"start_character":12,"end_line":985,"end_character":55},"updated":"2021-01-22 06:04:12.000000000","message":"this one will be called in treat_devices_removed. Why removing this assert then?","commit_id":"4184bae651b459a3006d260382266f19cf9026e0"},{"author":{"_account_id":30744,"name":"uchenily","email":"uchenily@gmail.com","username":"uchenily"},"change_message_id":"886167952444cd7afd3e0554fa0f6069fcc01adb","unresolved":true,"context_lines":[{"line_number":982,"context_line":"            self.assertEqual("},{"line_number":983,"context_line":"                ([\u0027the_skipped_one\u0027], set(), [], set(), set(), set()),"},{"line_number":984,"context_line":"                skip_devs)"},{"line_number":985,"context_line":"            ext_mgr_delete_port.assert_called_once_with("},{"line_number":986,"context_line":"                self.agent.context, {\u0027port_id\u0027: \u0027the_skipped_one\u0027})"},{"line_number":987,"context_line":"            treat_vif_port.assert_not_called()"},{"line_number":988,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"78d2d047_83bd1990","side":"PARENT","line":985,"range":{"start_line":985,"start_character":12,"end_line":985,"end_character":55},"in_reply_to":"16a853a3_459e2f29","updated":"2021-01-22 10:26:02.000000000","message":"This method will not be called in test_treat_devices_added_updated_skips_if_port_not_found, so I removed this assert.\ntest_treat_devices_removed_ext_delete_port will check delete_port method of ext_mgr, so I think we can remove it safely.","commit_id":"4184bae651b459a3006d260382266f19cf9026e0"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5bed67b3914cdcc9d19a1281e27234b02b892927","unresolved":true,"context_lines":[{"line_number":982,"context_line":"            self.assertEqual("},{"line_number":983,"context_line":"                ([\u0027the_skipped_one\u0027], set(), [], set(), set(), set()),"},{"line_number":984,"context_line":"                skip_devs)"},{"line_number":985,"context_line":"            ext_mgr_delete_port.assert_called_once_with("},{"line_number":986,"context_line":"                self.agent.context, {\u0027port_id\u0027: \u0027the_skipped_one\u0027})"},{"line_number":987,"context_line":"            treat_vif_port.assert_not_called()"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    def test_treat_devices_added_failed_devices(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fd15d82_54791319","side":"PARENT","line":986,"range":{"start_line":985,"start_character":13,"end_line":986,"end_character":65},"updated":"2021-01-22 10:55:20.000000000","message":"please check my comment on PS1","commit_id":"4184bae651b459a3006d260382266f19cf9026e0"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cd37290112ed0055d27df42689f89c1f50cda421","unresolved":true,"context_lines":[{"line_number":982,"context_line":"            self.assertEqual("},{"line_number":983,"context_line":"                ([\u0027the_skipped_one\u0027], set(), [], set(), set(), set()),"},{"line_number":984,"context_line":"                skip_devs)"},{"line_number":985,"context_line":"            ext_mgr_delete_port.assert_called_once_with("},{"line_number":986,"context_line":"                self.agent.context, {\u0027port_id\u0027: \u0027the_skipped_one\u0027})"},{"line_number":987,"context_line":"            treat_vif_port.assert_not_called()"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"    def test_treat_devices_added_failed_devices(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9563fb29_7766570d","side":"PARENT","line":986,"range":{"start_line":985,"start_character":13,"end_line":986,"end_character":65},"in_reply_to":"4fd15d82_54791319","updated":"2021-01-22 10:56:48.000000000","message":"ah, ignore, I see your replies","commit_id":"4184bae651b459a3006d260382266f19cf9026e0"}]}