)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af94d9f6fa565227778d7c6ae7177eb8fb469be1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Allow sharing of address groups via RBAC mechanism"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9d9e2bd4add5bb6fa4105352bfda739340932571"},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/774929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"68453161_1a532627","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"updated":"2021-02-25 09:18:13.000000000","message":"Now this is released, you can remove it and bump n-lib to 2.9.0","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"83cd1a5cfc6df8eb623401093d6eb6d655444c3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Allow sharing of address groups via RBAC mechanism"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9d9e2bd4add5bb6fa4105352bfda739340932571"},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/774929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"75e8a002_d2814f95","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"68453161_1a532627","updated":"2021-02-26 00:11:37.000000000","message":"Done","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"}],"neutron/conf/policies/address_group.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f7424ee223f855bec2ef69799957a0593f8e655","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    ),"},{"line_number":28,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":29,"context_line":"        name\u003d\u0027get_address_group\u0027,"},{"line_number":30,"context_line":"        check_str\u003dbase.policy_or(base.RULE_ADMIN_OR_OWNER,"},{"line_number":31,"context_line":"                                 \u0027rule:shared_address_groups\u0027),"},{"line_number":32,"context_line":"        description\u003d\u0027Get an address group\u0027,"},{"line_number":33,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":7,"id":"d593cf8c_f3a705ac","line":30,"updated":"2021-02-15 15:22:34.000000000","message":"can we use new \"secure-rbac\" rules already here?","commit_id":"05ec5102be721ff020bbac48aea8904d8ed1554f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"749adfa9b546ae13ffeaf4828a805c2227a57701","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    ),"},{"line_number":28,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":29,"context_line":"        name\u003d\u0027get_address_group\u0027,"},{"line_number":30,"context_line":"        check_str\u003dbase.policy_or(base.RULE_ADMIN_OR_OWNER,"},{"line_number":31,"context_line":"                                 \u0027rule:shared_address_groups\u0027),"},{"line_number":32,"context_line":"        description\u003d\u0027Get an address group\u0027,"},{"line_number":33,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":7,"id":"9af5dbb2_c4f1310f","line":30,"in_reply_to":"d593cf8c_f3a705ac","updated":"2021-02-18 02:12:57.000000000","message":"Done","commit_id":"05ec5102be721ff020bbac48aea8904d8ed1554f"}],"neutron/db/migration/alembic_migrations/versions/wallaby/expand/6135a7bd4425_add_rbac_support_for_address_group.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af94d9f6fa565227778d7c6ae7177eb8fb469be1","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        sa.Column(\u0027object_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":39,"context_line":"        sa.ForeignKeyConstraint([\u0027object_id\u0027], [\u0027address_groups.id\u0027],"},{"line_number":40,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":41,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":42,"context_line":"        sa.UniqueConstraint(\u0027target_tenant\u0027, \u0027object_id\u0027, \u0027action\u0027,"},{"line_number":43,"context_line":"                            name\u003d\u0027uniq_address_groups_rbacs0\u0027"},{"line_number":44,"context_line":"                                 \u0027target_tenant0object_id0action\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"71a2fa71_9a510a1d","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":10},"updated":"2021-02-25 09:18:13.000000000","message":"nit: this could be set in \"id\" column definition:\n\nsa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse, primary_key\u003dTrue),","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"83cd1a5cfc6df8eb623401093d6eb6d655444c3d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        sa.Column(\u0027object_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":39,"context_line":"        sa.ForeignKeyConstraint([\u0027object_id\u0027], [\u0027address_groups.id\u0027],"},{"line_number":40,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":41,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":42,"context_line":"        sa.UniqueConstraint(\u0027target_tenant\u0027, \u0027object_id\u0027, \u0027action\u0027,"},{"line_number":43,"context_line":"                            name\u003d\u0027uniq_address_groups_rbacs0\u0027"},{"line_number":44,"context_line":"                                 \u0027target_tenant0object_id0action\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1c155670_a9e8816d","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":10},"in_reply_to":"71a2fa71_9a510a1d","updated":"2021-02-26 00:11:37.000000000","message":"Done","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af94d9f6fa565227778d7c6ae7177eb8fb469be1","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                                 \u0027target_tenant0object_id0action\u0027)"},{"line_number":45,"context_line":"    )"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.create_index(op.f(\u0027ix_addressgrouprbacs_project_id\u0027),"},{"line_number":48,"context_line":"                    \u0027addressgrouprbacs\u0027, [\u0027project_id\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"730ae5e3_6b050e5c","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":6},"updated":"2021-02-25 09:18:13.000000000","message":"nit: same in \"project_id\" column definition:\n\nsa.Column(\u0027object_id\u0027, sa.String(length\u003d36), nullable\u003dFalse, index\u003dTrue),","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"83cd1a5cfc6df8eb623401093d6eb6d655444c3d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                 \u0027target_tenant0object_id0action\u0027)"},{"line_number":45,"context_line":"    )"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.create_index(op.f(\u0027ix_addressgrouprbacs_project_id\u0027),"},{"line_number":48,"context_line":"                    \u0027addressgrouprbacs\u0027, [\u0027project_id\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"63a5c013_b58fac46","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":6},"in_reply_to":"730ae5e3_6b050e5c","updated":"2021-02-26 00:11:37.000000000","message":"Done","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"}],"neutron/extensions/_address_group_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f7424ee223f855bec2ef69799957a0593f8e655","unresolved":true,"context_lines":[{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":90,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"cab2416a_a2c8680b","line":90,"updated":"2021-02-15 15:22:34.000000000","message":"shouldn\u0027t this file be moved to the neutron-lib?","commit_id":"05ec5102be721ff020bbac48aea8904d8ed1554f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"749adfa9b546ae13ffeaf4828a805c2227a57701","unresolved":false,"context_lines":[{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":90,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3512a5bf_a0e4d0cd","line":90,"in_reply_to":"cab2416a_a2c8680b","updated":"2021-02-18 02:12:57.000000000","message":"Yes, as soon as we release neutron-lib with the latest changes I made, this file won\u0027t be necessary","commit_id":"05ec5102be721ff020bbac48aea8904d8ed1554f"}],"neutron/extensions/address_group.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f7424ee223f855bec2ef69799957a0593f8e655","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.api import extensions"},{"line_number":20,"context_line":"from neutron.api.v2 import base"},{"line_number":21,"context_line":"from neutron.extensions import _address_group_lib as apidef"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Address_group(api_extensions.APIExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f7d44660_a0066628","line":21,"updated":"2021-02-15 15:22:34.000000000","message":"I guess this is just to make tests passing now, right?","commit_id":"05ec5102be721ff020bbac48aea8904d8ed1554f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"749adfa9b546ae13ffeaf4828a805c2227a57701","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.api import extensions"},{"line_number":20,"context_line":"from neutron.api.v2 import base"},{"line_number":21,"context_line":"from neutron.extensions import _address_group_lib as apidef"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Address_group(api_extensions.APIExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":7,"id":"a6fdb8e4_9497f111","line":21,"in_reply_to":"f7d44660_a0066628","updated":"2021-02-18 02:12:57.000000000","message":"Yes, as soon as we release neutron-lib with the latest changes I made","commit_id":"05ec5102be721ff020bbac48aea8904d8ed1554f"}],"neutron/tests/unit/objects/test_address_group.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af94d9f6fa565227778d7c6ae7177eb8fb469be1","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        self.objs[0].create()"},{"line_number":35,"context_line":"        return self.objs[0]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_object_version_degradation_1_1_to_1_0_no_standard_attrs(self):"},{"line_number":38,"context_line":"        ag_obj \u003d self._create_test_address_group()"},{"line_number":39,"context_line":"        ag_obj_1_0 \u003d ag_obj.obj_to_primitive(\u00271.0\u0027)"},{"line_number":40,"context_line":"        self.assertNotIn(\u0027revision_number\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a2dfd2a_433d9b5d","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"updated":"2021-02-25 09:18:13.000000000","message":"You should add another test for 1.2-\u003e1.1","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"83cd1a5cfc6df8eb623401093d6eb6d655444c3d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.objs[0].create()"},{"line_number":35,"context_line":"        return self.objs[0]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_object_version_degradation_1_1_to_1_0_no_standard_attrs(self):"},{"line_number":38,"context_line":"        ag_obj \u003d self._create_test_address_group()"},{"line_number":39,"context_line":"        ag_obj_1_0 \u003d ag_obj.obj_to_primitive(\u00271.0\u0027)"},{"line_number":40,"context_line":"        self.assertNotIn(\u0027revision_number\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8cb20805_bc3b23e5","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"in_reply_to":"9a2dfd2a_433d9b5d","updated":"2021-02-26 00:11:37.000000000","message":"Done","commit_id":"7571925dd9be98d2af9f36af03a42404b0c45350"}]}