)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"59a770583bc9e5d78aee2b5da64ca8738bd9a8fe","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027timeout\u0027 parameter needs to be passed to wait_until_true"},{"line_number":10,"context_line":"to make it meaningful and change it to 60 as a default timeout."},{"line_number":11,"context_line":"In fact 60sec was used till now, 5sec can break things."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Yalei Li \u003cliyl43@chinatelecom.cn\u003e"},{"line_number":14,"context_line":"Change-Id: I2881647e126ab48fa3381543a785ec037866de64"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"db1a0946_e71d3cc6","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":54},"updated":"2021-01-28 09:25:13.000000000","message":"This comment does not make sense unless you review the patch history.","commit_id":"f7461cf100a212f8e676314d2e214b486e622088"}],"neutron/agent/common/ovsdb_monitor.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3dcfc67faa11b6e07df160c90f49ccfb9c43794b","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.new_events \u003d {\u0027added\u0027: [], \u0027removed\u0027: [], \u0027modified\u0027: []}"},{"line_number":63,"context_line":"        return events"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self, block\u003dFalse, timeout\u003d5):"},{"line_number":66,"context_line":"        super(OvsdbMonitor, self).start()"},{"line_number":67,"context_line":"        if block:"},{"line_number":68,"context_line":"            utils.wait_until_true(self.is_active)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ec224ea_cbafc4b6","side":"PARENT","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":42},"updated":"2021-01-28 05:35:25.000000000","message":"please don\u0027t change method signature, just pass timeout where needed","commit_id":"efeb5bb99729bfde8ad5948c74c51bf7b6581382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"59a770583bc9e5d78aee2b5da64ca8738bd9a8fe","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.new_events \u003d {\u0027added\u0027: [], \u0027removed\u0027: [], \u0027modified\u0027: []}"},{"line_number":63,"context_line":"        return events"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self, block\u003dFalse, timeout\u003d5):"},{"line_number":66,"context_line":"        super(OvsdbMonitor, self).start()"},{"line_number":67,"context_line":"        if block:"},{"line_number":68,"context_line":"            utils.wait_until_true(self.is_active)"}],"source_content_type":"text/x-python","patch_set":2,"id":"665b98af_3a74ce6f","side":"PARENT","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":42},"in_reply_to":"5ec224ea_cbafc4b6","updated":"2021-01-28 09:25:13.000000000","message":"Actually this \"timeout\" parameter is modifying the parent method signature (AsyncProcess.start).\n\nThis class method is used in InterfacePollingMinimizer:\n  self._monitor.start(block\u003dTrue)\n\nand \"timeout\" is not used.","commit_id":"efeb5bb99729bfde8ad5948c74c51bf7b6581382"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9199eb694ad332ddfa26d46bfeea39e18d57cfeb","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.new_events \u003d {\u0027added\u0027: [], \u0027removed\u0027: [], \u0027modified\u0027: []}"},{"line_number":63,"context_line":"        return events"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self, block\u003dFalse, timeout\u003d5):"},{"line_number":66,"context_line":"        super(OvsdbMonitor, self).start()"},{"line_number":67,"context_line":"        if block:"},{"line_number":68,"context_line":"            utils.wait_until_true(self.is_active, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ae21160_59a1044a","line":65,"range":{"start_line":65,"start_character":41,"end_line":65,"end_character":42},"updated":"2021-01-28 06:15:26.000000000","message":"makes sense to change it to 60 as it\u0027s default timeout in wait_until_true and in fact was used till now.\nOtherwise we may break some slow deployments/testbeds.\nLet\u0027s wait what others say before new patchset.","commit_id":"2fc465442926ed57029ddbe2046c71bda9b87b19"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"53966749020b540abc3338a79213c0d964768cbe","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.new_events \u003d {\u0027added\u0027: [], \u0027removed\u0027: [], \u0027modified\u0027: []}"},{"line_number":63,"context_line":"        return events"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self, block\u003dFalse, timeout\u003d5):"},{"line_number":66,"context_line":"        super(OvsdbMonitor, self).start()"},{"line_number":67,"context_line":"        if block:"},{"line_number":68,"context_line":"            utils.wait_until_true(self.is_active, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c536398_c2170229","line":65,"range":{"start_line":65,"start_character":41,"end_line":65,"end_character":42},"in_reply_to":"7ae21160_59a1044a","updated":"2021-01-28 07:54:01.000000000","message":"Agree, wait_until_true defaults timeout to 60sec (https://opendev.org/openstack/neutron/src/branch/master/neutron/common/utils.py#L691 ) so changing it to 5sec can break things","commit_id":"2fc465442926ed57029ddbe2046c71bda9b87b19"}]}