)]}'
{"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18e24eb6924e4eafcb956a72a63a25c041425f07","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _init_firewall_callback(self, resource, event, trigger, payload\u003dNone):"},{"line_number":494,"context_line":"        LOG.info(\"Reinitialize Openvswitch firewall after OVS restart.\")"},{"line_number":495,"context_line":"        self.conj_ip_manager \u003d ConjIPFlowManager(self)"},{"line_number":496,"context_line":"        self._initialize_firewall()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def _initialize_firewall(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"52ff0f6a_f44bcb3f","line":495,"updated":"2021-02-02 10:05:28.000000000","message":"This is not enough to initialize again the FW. You need also to reset self.sg_port_map and self.sg_to_delete.\n\nI tried with this:\n    def _init_firewall_callback(self, resource, event, trigger, payload\u003dNone):\n        LOG.info(\"Reinitialize Openvswitch firewall after OVS restart.\")\n        self.sg_port_map \u003d SGPortMap()\n        self.conj_ip_manager \u003d ConjIPFlowManager(self)\n        self.sg_to_delete \u003d set()\n        self._initialize_firewall()\n\n\nand now I see how the conj flows are added again to the flow table when OVS is restarted. I compared both tables, before and after, and look the same.","commit_id":"40f97111cc13a64cda2f41d1b2c6b7a57505b435"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"edd110ca2ec2d83a817b512f952458e36d3d7f2a","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _init_firewall_callback(self, resource, event, trigger, payload\u003dNone):"},{"line_number":494,"context_line":"        LOG.info(\"Reinitialize Openvswitch firewall after OVS restart.\")"},{"line_number":495,"context_line":"        self.conj_ip_manager \u003d ConjIPFlowManager(self)"},{"line_number":496,"context_line":"        self._initialize_firewall()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def _initialize_firewall(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf375a5a_57af268c","line":495,"in_reply_to":"52ff0f6a_f44bcb3f","updated":"2021-02-02 13:44:09.000000000","message":"Done","commit_id":"40f97111cc13a64cda2f41d1b2c6b7a57505b435"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"34e1a14da1f821935fda7009cd37bcbefab1148d","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _init_firewall_callback(self, resource, event, trigger, payload\u003dNone):"},{"line_number":494,"context_line":"        LOG.info(\"Reinitialize Openvswitch firewall after OVS restart.\")"},{"line_number":495,"context_line":"        self.sg_port_map \u003d SGPortMap()"},{"line_number":496,"context_line":"        self.conj_ip_manager \u003d ConjIPFlowManager(self)"},{"line_number":497,"context_line":"        self.sg_to_delete \u003d set()"},{"line_number":498,"context_line":"        self._initialize_firewall()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fbc12f0c_5a6e15be","line":495,"updated":"2021-02-02 21:37:33.000000000","message":"those are the same lines which You added below. Maybe You can move it to some new small method and call it in both places?","commit_id":"0e40a6c74a43aa1574641d1283dc26f564c91c3c"}]}