)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64a4a376c898e0d3a26ed367bf9a23a791b2a47b","unresolved":true,"context_lines":[{"line_number":431,"context_line":"            vlan_to_use \u003d lvm.segmentation_id"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        subnet_info \u003d ldm.get_subnet_info()"},{"line_number":434,"context_line":"        ip_version \u003d subnet_info[\u0027ip_version\u0027]"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        if self.firewall and isinstance(self.firewall,"},{"line_number":437,"context_line":"                                        ovs_firewall.OVSFirewallDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4af45337_5ec12406","line":434,"updated":"2021-02-02 14:40:22.000000000","message":"ip_version was already initialized here, so can just be used below.","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"71369e1693889f07347fab08991f9146b6bf5519","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            vlan_to_use \u003d lvm.segmentation_id"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        subnet_info \u003d ldm.get_subnet_info()"},{"line_number":434,"context_line":"        ip_version \u003d subnet_info[\u0027ip_version\u0027]"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        if self.firewall and isinstance(self.firewall,"},{"line_number":437,"context_line":"                                        ovs_firewall.OVSFirewallDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc4a85e4_cbac3b28","line":434,"in_reply_to":"4af45337_5ec12406","updated":"2021-02-03 05:10:22.000000000","message":"Done","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64a4a376c898e0d3a26ed367bf9a23a791b2a47b","unresolved":true,"context_lines":[{"line_number":516,"context_line":"        ldm.add_dvr_ofport(port.vif_id, port.ofport)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if (subnet_info.get(\u0027ip_version\u0027) \u003d\u003d 4 and"},{"line_number":519,"context_line":"                subnet_info.get(\u0027gateway_mac\u0027)):"},{"line_number":520,"context_line":"            # Change ARP reply destination MAC address from"},{"line_number":521,"context_line":"            # dvr_host_mac to gateway_mac."},{"line_number":522,"context_line":"            self.int_br.change_arp_destination_mac("}],"source_content_type":"text/x-python","patch_set":1,"id":"38ce8d75_c947a1fc","line":519,"updated":"2021-02-02 14:40:22.000000000","message":"See above.","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"71369e1693889f07347fab08991f9146b6bf5519","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        ldm.add_dvr_ofport(port.vif_id, port.ofport)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if (subnet_info.get(\u0027ip_version\u0027) \u003d\u003d 4 and"},{"line_number":519,"context_line":"                subnet_info.get(\u0027gateway_mac\u0027)):"},{"line_number":520,"context_line":"            # Change ARP reply destination MAC address from"},{"line_number":521,"context_line":"            # dvr_host_mac to gateway_mac."},{"line_number":522,"context_line":"            self.int_br.change_arp_destination_mac("}],"source_content_type":"text/x-python","patch_set":1,"id":"e096a4e3_7831f788","line":519,"in_reply_to":"38ce8d75_c947a1fc","updated":"2021-02-03 05:10:22.000000000","message":"Done","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb60e5f9b8901aeb33b5bf80a4bfd4431d2a8615","unresolved":true,"context_lines":[{"line_number":3177,"context_line":"                ),"},{"line_number":3178,"context_line":"            ] + self._expected_port_bound(self._port, lvid,"},{"line_number":3179,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3180,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":3181,"context_line":"                expected_on_int_br +\u003d ["},{"line_number":3182,"context_line":"                    mock.call.change_arp_destination_mac("},{"line_number":3183,"context_line":"                        target_mac_address\u003dgateway_mac,"}],"source_content_type":"text/x-python","patch_set":1,"id":"643e1476_3b63fc55","line":3180,"range":{"start_line":3180,"start_character":29,"end_line":3180,"end_character":30},"updated":"2021-02-02 10:47:13.000000000","message":"we have constant for that in neutron_lib, please use it","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"71369e1693889f07347fab08991f9146b6bf5519","unresolved":false,"context_lines":[{"line_number":3177,"context_line":"                ),"},{"line_number":3178,"context_line":"            ] + self._expected_port_bound(self._port, lvid,"},{"line_number":3179,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3180,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":3181,"context_line":"                expected_on_int_br +\u003d ["},{"line_number":3182,"context_line":"                    mock.call.change_arp_destination_mac("},{"line_number":3183,"context_line":"                        target_mac_address\u003dgateway_mac,"}],"source_content_type":"text/x-python","patch_set":1,"id":"64861a2a_ef34a9f9","line":3180,"range":{"start_line":3180,"start_character":29,"end_line":3180,"end_character":30},"in_reply_to":"643e1476_3b63fc55","updated":"2021-02-03 05:10:22.000000000","message":"Done","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb60e5f9b8901aeb33b5bf80a4bfd4431d2a8615","unresolved":true,"context_lines":[{"line_number":3256,"context_line":"            lvid \u003d self.agent.vlan_manager.get(self._net_uuid).vlan"},{"line_number":3257,"context_line":"            expected_on_int_br \u003d self._expected_port_bound("},{"line_number":3258,"context_line":"                self._port, lvid)"},{"line_number":3259,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":3260,"context_line":"                expected_on_int_br +\u003d ["},{"line_number":3261,"context_line":"                    mock.call.change_arp_destination_mac("},{"line_number":3262,"context_line":"                        target_mac_address\u003dgateway_mac,"}],"source_content_type":"text/x-python","patch_set":1,"id":"34e4399c_e97a9421","line":3259,"range":{"start_line":3259,"start_character":29,"end_line":3259,"end_character":30},"updated":"2021-02-02 10:47:13.000000000","message":"same here","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"71369e1693889f07347fab08991f9146b6bf5519","unresolved":false,"context_lines":[{"line_number":3256,"context_line":"            lvid \u003d self.agent.vlan_manager.get(self._net_uuid).vlan"},{"line_number":3257,"context_line":"            expected_on_int_br \u003d self._expected_port_bound("},{"line_number":3258,"context_line":"                self._port, lvid)"},{"line_number":3259,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":3260,"context_line":"                expected_on_int_br +\u003d ["},{"line_number":3261,"context_line":"                    mock.call.change_arp_destination_mac("},{"line_number":3262,"context_line":"                        target_mac_address\u003dgateway_mac,"}],"source_content_type":"text/x-python","patch_set":1,"id":"54522ec1_fe6a20f7","line":3259,"range":{"start_line":3259,"start_character":29,"end_line":3259,"end_character":30},"in_reply_to":"34e4399c_e97a9421","updated":"2021-02-03 05:10:22.000000000","message":"Done","commit_id":"161e0d52ec30361d563a855c665103b685d44c71"}]}
