)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/commands.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"fd4703fc5dff2b0dc8d4ed7781905d210a8343e0","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                lrouter \u003d idlutils.row_by_value(self.api.idl, \u0027Logical_Router\u0027,"},{"line_number":242,"context_line":"                                                \u0027name\u0027, self.name, None)"},{"line_number":243,"context_line":"                if lrouter:"},{"line_number":244,"context_line":"                    return"},{"line_number":245,"context_line":"            except idlutils.RowNotFound:"},{"line_number":246,"context_line":"                pass"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3687a438_986a2a75","line":244,"range":{"start_line":243,"start_character":0,"end_line":244,"end_character":26},"updated":"2021-02-15 15:27:31.000000000","message":"Do we need this then? ie. if it\u0027s not found aren\u0027t we going to hit L245 straight away?","commit_id":"db86089c794891d09a046a2761989c756ba49184"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9bdc1bd4d314262f9338068d7ed8b9a17806db3e","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                lrouter \u003d idlutils.row_by_value(self.api.idl, \u0027Logical_Router\u0027,"},{"line_number":242,"context_line":"                                                \u0027name\u0027, self.name, None)"},{"line_number":243,"context_line":"                if lrouter:"},{"line_number":244,"context_line":"                    return"},{"line_number":245,"context_line":"            except idlutils.RowNotFound:"},{"line_number":246,"context_line":"                pass"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fdbb1770_6c610821","line":244,"range":{"start_line":243,"start_character":0,"end_line":244,"end_character":26},"in_reply_to":"3687a438_986a2a75","updated":"2021-02-15 15:29:48.000000000","message":"We could remove the if condition there, cause if the object does not exist it will raise RowNotFound and we going to create it, otherwise we should just return.\n\nIt\u0027s a nit but I can fix it if u think it\u0027s necessary.","commit_id":"db86089c794891d09a046a2761989c756ba49184"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"24154885fc87af690b62e6f8dac4823b17e54708","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                lrouter \u003d idlutils.row_by_value(self.api.idl, \u0027Logical_Router\u0027,"},{"line_number":242,"context_line":"                                                \u0027name\u0027, self.name)"},{"line_number":243,"context_line":"                return"},{"line_number":244,"context_line":"            except idlutils.RowNotFound:"},{"line_number":245,"context_line":"                pass"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        row \u003d txn.insert(self.api._tables[\u0027Logical_Router\u0027])"},{"line_number":248,"context_line":"        row.name \u003d self.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"1dd81919_0f56788b","line":245,"range":{"start_line":244,"start_character":5,"end_line":245,"end_character":20},"updated":"2021-02-15 16:57:56.000000000","message":"It was a nit but less code to maintain and IMHO it is much clearer now.\nAlso good stuff removing the last parameter.\nThanks!!!","commit_id":"9292f892f5d553f08021b4d17a0ab6bf9b450b8d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4850ba689f06e13da71f6863df90b6aa246b6e6a","unresolved":true,"context_lines":[{"line_number":236,"context_line":"        self.may_exist \u003d may_exist"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def run_idl(self, txn):"},{"line_number":239,"context_line":"        if self.may_exist:"},{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                idlutils.row_by_value(self.api.idl, \u0027Logical_Router\u0027,"},{"line_number":242,"context_line":"                                      \u0027name\u0027, self.name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"920d6c94_2bf8f3ec","line":239,"updated":"2021-02-17 08:51:49.000000000","message":"The logic is ok but the rest of the code uses default\u003dNone instead of using the try/catch context:\n\nif self.may_exist:\n    if idlutils.row_by_value(self.api.idl, \u0027Logical_Router\u0027, \u0027name\u0027, self.name,\n                             default\u003dNone)\n        return","commit_id":"abca2bae19f8794bb643519518342b7acfbaec5e"}]}