)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"d0d02993be28bfa9a22bd8e41068b88f3d6eed3e","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        try:"},{"line_number":951,"context_line":"            with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":952,"context_line":"                self._delete_floatingip(floatingip, lrouter, txn\u003dtxn)"},{"line_number":953,"context_line":"                self._qos_driver.delete_floatingip(txn, floatingip)"},{"line_number":954,"context_line":"        except Exception as e:"},{"line_number":955,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":956,"context_line":"                LOG.error(\u0027Unable to disassociate floating ip in gateway \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"38fd724b_dd8916af","line":953,"range":{"start_line":953,"start_character":0,"end_line":953,"end_character":2},"updated":"2021-02-22 17:33:42.000000000","message":"Maybe using the \"disassociate_floatingip\" function in the qos_driver would be better? Either using it or removing it in qos.py, because I don\u0027t see that function being used anywhere else. It\u0027s just a suggestion, since both functions do the same thing. (And please do not hesitate to correct me if I\u0027m wrong!!)","commit_id":"ed05003596ecd8382741d6d72bcd62a209f0aab0"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"0a223e437bb75a512b3478ebd1a1ea08dccfacea","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        try:"},{"line_number":951,"context_line":"            with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":952,"context_line":"                self._delete_floatingip(floatingip, lrouter, txn\u003dtxn)"},{"line_number":953,"context_line":"                self._qos_driver.delete_floatingip(txn, floatingip)"},{"line_number":954,"context_line":"        except Exception as e:"},{"line_number":955,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":956,"context_line":"                LOG.error(\u0027Unable to disassociate floating ip in gateway \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6743482_ef664176","line":953,"range":{"start_line":953,"start_character":0,"end_line":953,"end_character":2},"in_reply_to":"1177bc61_91f32097","updated":"2021-02-23 09:31:42.000000000","message":"I\u0027m sorry, I did not explain myself correctly. I was just referring to changing L953 from self._qos_driver.delete_floatingip(...) to self._qos_driver.disassociate_floatingip(...)","commit_id":"ed05003596ecd8382741d6d72bcd62a209f0aab0"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"65db9b485cc54e622d3da945fe0ce2e13a8f317b","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        try:"},{"line_number":951,"context_line":"            with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":952,"context_line":"                self._delete_floatingip(floatingip, lrouter, txn\u003dtxn)"},{"line_number":953,"context_line":"                self._qos_driver.delete_floatingip(txn, floatingip)"},{"line_number":954,"context_line":"        except Exception as e:"},{"line_number":955,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":956,"context_line":"                LOG.error(\u0027Unable to disassociate floating ip in gateway \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbcc6d54_914e1151","line":953,"range":{"start_line":953,"start_character":0,"end_line":953,"end_character":2},"in_reply_to":"1ec64fdc_a434763a","updated":"2021-02-23 15:26:47.000000000","message":"Ok! LGTM then","commit_id":"ed05003596ecd8382741d6d72bcd62a209f0aab0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79b0794144ae7a459833c1ba70f77252c2c22b35","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        try:"},{"line_number":951,"context_line":"            with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":952,"context_line":"                self._delete_floatingip(floatingip, lrouter, txn\u003dtxn)"},{"line_number":953,"context_line":"                self._qos_driver.delete_floatingip(txn, floatingip)"},{"line_number":954,"context_line":"        except Exception as e:"},{"line_number":955,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":956,"context_line":"                LOG.error(\u0027Unable to disassociate floating ip in gateway \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1177bc61_91f32097","line":953,"range":{"start_line":953,"start_character":0,"end_line":953,"end_character":2},"in_reply_to":"38fd724b_dd8916af","updated":"2021-02-23 08:54:54.000000000","message":"I\u0027m not sure about your comment or suggestion here.\n\n\"OVNClient.disassociate_floatingip\" is called from \"OVNL3RouterPlugin.disassociate_floatingips\", that is called from \"ML2plugin.delete_port\".\n\nAbout \"OVNClient._delete_floatingip\", this is in charge of deleting the OVN FIP references; the QoS plugin method is in charge of deleting the QoS registers. Both methods have different goals.\n\nNOTE: maybe the QoS plugin should have been implemented using subscriptions to events (delete port, update network, etc). The way it was implemented, being called synchronously from the OVN client is not the most elegant one. But you need to remember the goal of QoS plugin is to abstract any OVN QoS operation.","commit_id":"ed05003596ecd8382741d6d72bcd62a209f0aab0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c4c72184d29bfa429aaad5093d0c06b0ab99ccd1","unresolved":true,"context_lines":[{"line_number":950,"context_line":"        try:"},{"line_number":951,"context_line":"            with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":952,"context_line":"                self._delete_floatingip(floatingip, lrouter, txn\u003dtxn)"},{"line_number":953,"context_line":"                self._qos_driver.delete_floatingip(txn, floatingip)"},{"line_number":954,"context_line":"        except Exception as e:"},{"line_number":955,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":956,"context_line":"                LOG.error(\u0027Unable to disassociate floating ip in gateway \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ec64fdc_a434763a","line":953,"range":{"start_line":953,"start_character":0,"end_line":953,"end_character":2},"in_reply_to":"f6743482_ef664176","updated":"2021-02-23 10:12:58.000000000","message":"Right, this could be a good option. But I\u0027ll keep the same OVN client terms: when a FIP is disassociated in Neutron, is deleted in OVN.","commit_id":"ed05003596ecd8382741d6d72bcd62a209f0aab0"}]}