)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"661e2bc609f3024da5f4eeb6819f29eca84d76fc","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-02-24 18:50:14 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Routed provider nets: Fix subnet allocation logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tempest Test: https://review.opendev.org/c/openstack/tempest/+/665155"},{"line_number":10,"context_line":"Closes-Bug: #1916276"},{"line_number":11,"context_line":"Change-Id: Ib8ffb47bebd08a58f6583f1ea873000b33db5e42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e3842c47_ad8e7396","line":8,"updated":"2021-02-25 12:16:23.000000000","message":"TODO: fix unit tests","commit_id":"efd946d537d82e487d6f92c95ec53122c3f8f3b2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c1f009bf420624053c98ed28088877f5e435b111","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-04-19 14:29:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Routed provider nets: Fix subnet allocation logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tempest Test: https://review.opendev.org/c/openstack/tempest/+/665155"},{"line_number":10,"context_line":"Closes-Bug: #1916276"},{"line_number":11,"context_line":"Change-Id: Ib8ffb47bebd08a58f6583f1ea873000b33db5e42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"febcc720_68f6d8c9","line":8,"updated":"2021-04-20 08:00:17.000000000","message":"Please briefly describe the fix","commit_id":"0a5138e830a525a907372671a660627367141ebd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d6facae0cd35e3e187e9d9bf6113e6c1bc88393d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3ff86f5a_1cd83a17","updated":"2022-12-19 14:05:33.000000000","message":"I had some time finally to come back to this patch","commit_id":"3749c57d53d2266c84f71f1b999e35a4d0fb0c66"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6791479537a68b6393938e315867983aa21d56db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c0da7e54_0e3cd5f6","updated":"2023-02-28 18:19:38.000000000","message":"Please, rebase the tempest patch.","commit_id":"3749c57d53d2266c84f71f1b999e35a4d0fb0c66"}],"neutron/services/segments/plugin.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fc20637b338b08f1b5b2c466eda0a84252b66929","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                               segment_host_mappings):"},{"line_number":275,"context_line":"        name \u003d SEGMENT_NAME_STUB % segment_id"},{"line_number":276,"context_line":"        resource_provider \u003d {\u0027name\u0027: name, \u0027uuid\u0027: segment_id}"},{"line_number":277,"context_line":"        try:"},{"line_number":278,"context_line":"            self.p_client.create_resource_provider(resource_provider)"},{"line_number":279,"context_line":"        except placement_exc.PlacementClientError as e:"},{"line_number":280,"context_line":"            if \"Conflicting resource provider uuid\" in e.message:"}],"source_content_type":"text/x-python","patch_set":6,"id":"2f996452_fd08e4ab","line":277,"updated":"2022-11-25 09:09:59.000000000","message":"Have you noticed path when this can happen? Perhaps we should avoid calling create_nova_inventory at all?\n\nMore errors can probably happen if we try to create aggregate that does already exist, right?\n\nBesides that, can I suggest you to create a specific commit addressing this part?","commit_id":"3749c57d53d2266c84f71f1b999e35a4d0fb0c66"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cfcd5ddc6f87aadfff92e1a8ea7c2775eda3da00","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                               segment_host_mappings):"},{"line_number":275,"context_line":"        name \u003d SEGMENT_NAME_STUB % segment_id"},{"line_number":276,"context_line":"        resource_provider \u003d {\u0027name\u0027: name, \u0027uuid\u0027: segment_id}"},{"line_number":277,"context_line":"        try:"},{"line_number":278,"context_line":"            self.p_client.create_resource_provider(resource_provider)"},{"line_number":279,"context_line":"        except placement_exc.PlacementClientError as e:"},{"line_number":280,"context_line":"            if \"Conflicting resource provider uuid\" in e.message:"}],"source_content_type":"text/x-python","patch_set":6,"id":"c6b4ca85_da1adad3","line":277,"in_reply_to":"2f996452_fd08e4ab","updated":"2022-12-19 14:05:13.000000000","message":"the nova/placement inventory is intended to track the used ipv4 addresses and based on that scheduling can be done, at least I would expect it should work that way (https://docs.openstack.org/neutron/latest/admin/config-routed-networks.html#create-a-routed-provider-network )\n\nI will check the aggregate question","commit_id":"3749c57d53d2266c84f71f1b999e35a4d0fb0c66"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fc20637b338b08f1b5b2c466eda0a84252b66929","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        if not (does_original_port_require_nova_inventory_update or"},{"line_number":455,"context_line":"                does_port_require_nova_inventory_update):"},{"line_number":456,"context_line":"            return"},{"line_number":457,"context_line":"        original_port_ipv4_subnets_number, orig_segment_id \u003d ("},{"line_number":458,"context_line":"            self._get_ipv4_subnets_number_and_segment_id(original_port,"},{"line_number":459,"context_line":"                                                         context))"},{"line_number":460,"context_line":"        port_ipv4_subnets_number, segment_id \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"6ac998f5_1c4b7823","line":457,"updated":"2022-11-25 09:09:59.000000000","message":"Can you explain a bit what was bad before and how your change is fixing it?","commit_id":"3749c57d53d2266c84f71f1b999e35a4d0fb0c66"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cfcd5ddc6f87aadfff92e1a8ea7c2775eda3da00","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        if not (does_original_port_require_nova_inventory_update or"},{"line_number":455,"context_line":"                does_port_require_nova_inventory_update):"},{"line_number":456,"context_line":"            return"},{"line_number":457,"context_line":"        original_port_ipv4_subnets_number, orig_segment_id \u003d ("},{"line_number":458,"context_line":"            self._get_ipv4_subnets_number_and_segment_id(original_port,"},{"line_number":459,"context_line":"                                                         context))"},{"line_number":460,"context_line":"        port_ipv4_subnets_number, segment_id \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae69728_bd01ab32","line":457,"in_reply_to":"6ac998f5_1c4b7823","updated":"2022-12-19 14:05:13.000000000","message":"The issue which I see is that on nova/placement side there should be reserved allocation for the IPV4_ADDRESSes, at least I would expect it to be reserved and that is something which based on nova can decide about scheduling.","commit_id":"3749c57d53d2266c84f71f1b999e35a4d0fb0c66"}]}