)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2b89c2ef802f2fecf9ca34f78b230130ca5c5f29","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OVN] Fix RowNotFound: Cannot find Logical_Router"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The execute() method in ovsdbapp has the log_error parameter set to True"},{"line_number":10,"context_line":"by default; this was causing the RowNotFound error to be logged as part"},{"line_number":11,"context_line":"of get_lrouter() even tho that exception was being handled correct (it\u0027s"},{"line_number":12,"context_line":"part of the logic of that method to return None if the lrouter does not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6695a5ec_0dec7e06","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":50},"updated":"2021-02-25 14:05:18.000000000","message":"nit: log_errors","commit_id":"f0f6d6189a6f8d17b411e82337a97ec7cddd999a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bb4513842ab85929ed86fefeb1709fdad2f8cec5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OVN] Fix RowNotFound: Cannot find Logical_Router"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The execute() method in ovsdbapp has the log_error parameter set to True"},{"line_number":10,"context_line":"by default; this was causing the RowNotFound error to be logged as part"},{"line_number":11,"context_line":"of get_lrouter() even tho that exception was being handled correct (it\u0027s"},{"line_number":12,"context_line":"part of the logic of that method to return None if the lrouter does not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e9bbc7e7_410dfa3d","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":50},"in_reply_to":"6695a5ec_0dec7e06","updated":"2021-02-25 15:29:50.000000000","message":"Oops thanks for pointing this out. I will update it in case I need a new patch-set.","commit_id":"f0f6d6189a6f8d17b411e82337a97ec7cddd999a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2b89c2ef802f2fecf9ca34f78b230130ca5c5f29","unresolved":true,"context_lines":[{"line_number":12,"context_line":"part of the logic of that method to return None if the lrouter does not"},{"line_number":13,"context_line":"exist)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch sets log_error to False in the execute() call. Note that,"},{"line_number":16,"context_line":"check_error is still True, so any exception other than RowNotFound would"},{"line_number":17,"context_line":"still bubble up from that method because it\u0027s not handled, that means"},{"line_number":18,"context_line":"that we won\u0027t miss any other exception with log_error being False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1728ec2b_d9a80857","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":25},"updated":"2021-02-25 14:05:18.000000000","message":"same","commit_id":"f0f6d6189a6f8d17b411e82337a97ec7cddd999a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bb4513842ab85929ed86fefeb1709fdad2f8cec5","unresolved":true,"context_lines":[{"line_number":12,"context_line":"part of the logic of that method to return None if the lrouter does not"},{"line_number":13,"context_line":"exist)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch sets log_error to False in the execute() call. Note that,"},{"line_number":16,"context_line":"check_error is still True, so any exception other than RowNotFound would"},{"line_number":17,"context_line":"still bubble up from that method because it\u0027s not handled, that means"},{"line_number":18,"context_line":"that we won\u0027t miss any other exception with log_error being False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0e95a115_e855df4e","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":25},"in_reply_to":"1728ec2b_d9a80857","updated":"2021-02-25 15:29:50.000000000","message":"Oops thanks for pointing this out. I will update it in case I need a new patch-set.","commit_id":"f0f6d6189a6f8d17b411e82337a97ec7cddd999a"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2b89c2ef802f2fecf9ca34f78b230130ca5c5f29","unresolved":true,"context_lines":[{"line_number":674,"context_line":"            lrouter_name \u003d utils.ovn_name(lrouter_name)"},{"line_number":675,"context_line":"        try:"},{"line_number":676,"context_line":"            return self.lr_get(lrouter_name).execute(log_errors\u003dFalse,"},{"line_number":677,"context_line":"                                                     check_error\u003dTrue)"},{"line_number":678,"context_line":"        except idlutils.RowNotFound:"},{"line_number":679,"context_line":"            return None"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e1428fd9_4bea5ceb","line":677,"updated":"2021-02-25 14:05:18.000000000","message":"Wonder if there\u0027s a unit test that will fail now?","commit_id":"f0f6d6189a6f8d17b411e82337a97ec7cddd999a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bb4513842ab85929ed86fefeb1709fdad2f8cec5","unresolved":true,"context_lines":[{"line_number":674,"context_line":"            lrouter_name \u003d utils.ovn_name(lrouter_name)"},{"line_number":675,"context_line":"        try:"},{"line_number":676,"context_line":"            return self.lr_get(lrouter_name).execute(log_errors\u003dFalse,"},{"line_number":677,"context_line":"                                                     check_error\u003dTrue)"},{"line_number":678,"context_line":"        except idlutils.RowNotFound:"},{"line_number":679,"context_line":"            return None"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"897b4e5f_fe027520","line":677,"in_reply_to":"e1428fd9_4bea5ceb","updated":"2021-02-25 15:29:50.000000000","message":"I ran the unit tests locally and I think we are good:\n\n  py39: commands succeeded\n  congratulations :)","commit_id":"f0f6d6189a6f8d17b411e82337a97ec7cddd999a"}]}