)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b41b982434ebb54d6ca8d09673100657769668b8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The initial router state method is now a thread that is executed"},{"line_number":10,"context_line":"in parallel with the \"ip monitor\" thread. If by any circumstance"},{"line_number":11,"context_line":"this thread do not read the interface IP addresses on time, the"},{"line_number":12,"context_line":"state of the router will be defined as \"backup\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1917793"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9f6f734_f9129bf1","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":18},"updated":"2021-03-23 17:13:34.000000000","message":"nit: does not","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"92375cf8f2c7adec021680cf63e3de957a404458","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The initial router state method is now a thread that is executed"},{"line_number":10,"context_line":"in parallel with the \"ip monitor\" thread. If by any circumstance"},{"line_number":11,"context_line":"this thread do not read the interface IP addresses on time, the"},{"line_number":12,"context_line":"state of the router will be defined as \"backup\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1917793"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"13468ed1_d1f310e2","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":18},"in_reply_to":"c9f6f734_f9129bf1","updated":"2021-03-30 16:47:53.000000000","message":"Done","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"}],"neutron/agent/l3/keepalived_state_change.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b41b982434ebb54d6ca8d09673100657769668b8","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    @initial_state.setter"},{"line_number":70,"context_line":"    def initial_state(self, state):"},{"line_number":71,"context_line":"        if not self._initial_state:"},{"line_number":72,"context_line":"            LOG.debug(\u0027Initial status of router %s is %s\u0027, self.router_id,"},{"line_number":73,"context_line":"                      state)"},{"line_number":74,"context_line":"            self._initial_state \u003d state"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def run(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"cd7f9f10_4cbdf6ea","line":73,"range":{"start_line":72,"start_character":12,"end_line":73,"end_character":28},"updated":"2021-03-23 17:13:34.000000000","message":"There\u0027s a log.debug for the same at L142, perhaps we can live without this","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"49f4b074bba90ea93d30bf99bb0d8daf412b982e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @initial_state.setter"},{"line_number":70,"context_line":"    def initial_state(self, state):"},{"line_number":71,"context_line":"        if not self._initial_state:"},{"line_number":72,"context_line":"            LOG.debug(\u0027Initial status of router %s is %s\u0027, self.router_id,"},{"line_number":73,"context_line":"                      state)"},{"line_number":74,"context_line":"            self._initial_state \u003d state"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def run(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ccb448e3_5fbef252","line":73,"range":{"start_line":72,"start_character":12,"end_line":73,"end_character":28},"in_reply_to":"4c8afca1_4142a9b1","updated":"2021-03-31 12:39:16.000000000","message":"Ack","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"92375cf8f2c7adec021680cf63e3de957a404458","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    @initial_state.setter"},{"line_number":70,"context_line":"    def initial_state(self, state):"},{"line_number":71,"context_line":"        if not self._initial_state:"},{"line_number":72,"context_line":"            LOG.debug(\u0027Initial status of router %s is %s\u0027, self.router_id,"},{"line_number":73,"context_line":"                      state)"},{"line_number":74,"context_line":"            self._initial_state \u003d state"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def run(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c8afca1_4142a9b1","line":73,"range":{"start_line":72,"start_character":12,"end_line":73,"end_character":28},"in_reply_to":"cd7f9f10_4cbdf6ea","updated":"2021-03-30 16:47:53.000000000","message":"But this is only for the initial status, the first time we read the router status. It is important to know what the initial router status was.","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b41b982434ebb54d6ca8d09673100657769668b8","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        # timeout, \"backup\" state is set."},{"line_number":92,"context_line":"        self._thread_initial_state.join(timeout\u003dINITIAL_STATE_READ_TIMEOUT)"},{"line_number":93,"context_line":"        if not self.initial_state:"},{"line_number":94,"context_line":"            LOG.error(\u0027Timeout reading the initial status of router %s\u0027,"},{"line_number":95,"context_line":"                      self.router_id)"},{"line_number":96,"context_line":"            self.write_state_change(\u0027backup\u0027)"},{"line_number":97,"context_line":"            self.notify_agent(\u0027backup\u0027)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"11bff00f_7fe20f41","line":95,"range":{"start_line":94,"start_character":12,"end_line":95,"end_character":37},"updated":"2021-03-23 17:13:34.000000000","message":"- doesn\u0027t it enough to have a warning here?\n- Add please a word that the state is set to backup: \"Timeout reading the initial status of router %s, state is changed to backup\"\nor similar.","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"92375cf8f2c7adec021680cf63e3de957a404458","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        # timeout, \"backup\" state is set."},{"line_number":92,"context_line":"        self._thread_initial_state.join(timeout\u003dINITIAL_STATE_READ_TIMEOUT)"},{"line_number":93,"context_line":"        if not self.initial_state:"},{"line_number":94,"context_line":"            LOG.error(\u0027Timeout reading the initial status of router %s\u0027,"},{"line_number":95,"context_line":"                      self.router_id)"},{"line_number":96,"context_line":"            self.write_state_change(\u0027backup\u0027)"},{"line_number":97,"context_line":"            self.notify_agent(\u0027backup\u0027)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d1afad08_cc3d1c5a","line":95,"range":{"start_line":94,"start_character":12,"end_line":95,"end_character":37},"in_reply_to":"11bff00f_7fe20f41","updated":"2021-03-30 16:47:53.000000000","message":"1) Yeah, maybe a warning is enough.\n2) Right, agree on saying that we are manually setting the value to \"backup\".","commit_id":"8a18d84b39f6cfbccd12b24510eba2c178d0d999"}]}