)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"049e05d285fc3ead0a872fa5fd92bbc0c23c1391","unresolved":true,"context_lines":[{"line_number":670,"context_line":"        cmds \u003d []"},{"line_number":671,"context_line":"        for port in self._nb_idl.lsp_list().execute(check_error\u003dTrue):"},{"line_number":672,"context_line":"            port_type \u003d port.type.strip()"},{"line_number":673,"context_line":"            if port_type in (\"vtep\", \"localport\", \"router\"):"},{"line_number":674,"context_line":"                continue"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"            options \u003d port.options"}],"source_content_type":"text/x-python","patch_set":4,"id":"7569807e_711ac788","line":673,"range":{"start_line":673,"start_character":29,"end_line":673,"end_character":58},"updated":"2021-03-09 10:36:54.000000000","message":"nit: Shouldn\u0027t these be constants like L681?","commit_id":"b04d64b90f2822222f96ddd726d379a2f19b539e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3b0b39d4af95a8bd706a209d5d6f3d2a1ce2ef85","unresolved":true,"context_lines":[{"line_number":670,"context_line":"        cmds \u003d []"},{"line_number":671,"context_line":"        for port in self._nb_idl.lsp_list().execute(check_error\u003dTrue):"},{"line_number":672,"context_line":"            port_type \u003d port.type.strip()"},{"line_number":673,"context_line":"            if port_type in (\"vtep\", \"localport\", \"router\"):"},{"line_number":674,"context_line":"                continue"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"            options \u003d port.options"}],"source_content_type":"text/x-python","patch_set":4,"id":"781be9ec_8e11eea3","line":673,"range":{"start_line":673,"start_character":29,"end_line":673,"end_character":58},"in_reply_to":"7569807e_711ac788","updated":"2021-03-09 10:47:16.000000000","message":"Yeah, constants would be better indeed. Unfortunately they do not exist in the constants.py file at the moment.\n\nI thought about creating it in this patch but then I would need to update parts of the code to use the constants which are unrelated to this change. Perhaps it would be better done in a separated patch after this one. What u think ?","commit_id":"b04d64b90f2822222f96ddd726d379a2f19b539e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b9d5df1afcb470042b5b839697defb2a03a1f2db","unresolved":true,"context_lines":[{"line_number":670,"context_line":"        cmds \u003d []"},{"line_number":671,"context_line":"        for port in self._nb_idl.lsp_list().execute(check_error\u003dTrue):"},{"line_number":672,"context_line":"            port_type \u003d port.type.strip()"},{"line_number":673,"context_line":"            if port_type in (\"vtep\", \"localport\", \"router\"):"},{"line_number":674,"context_line":"                continue"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"            options \u003d port.options"}],"source_content_type":"text/x-python","patch_set":4,"id":"dc87342c_57d4162b","line":673,"range":{"start_line":673,"start_character":29,"end_line":673,"end_character":58},"in_reply_to":"781be9ec_8e11eea3","updated":"2021-03-10 08:45:45.000000000","message":"+1 for follow up patch","commit_id":"b04d64b90f2822222f96ddd726d379a2f19b539e"}]}