)]}'
{"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"96a7ab87c6fdbe8b1e8af3386fa8d31ace327f2a","unresolved":true,"context_lines":[{"line_number":64,"context_line":"                     portbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":65,"context_line":"                     portbindings.VNIC_ACCELERATOR_DIRECT,"},{"line_number":66,"context_line":"                     portbindings.VNIC_ACCELERATOR_DIRECT_PHYSICAL,"},{"line_number":67,"context_line":"                 ]):"},{"line_number":68,"context_line":"        \"\"\"Initialize base class for SriovNicSwitch L2 agent type."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param agent_type: Constant identifying agent type in agents_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"e017d3e7_e8f3d8f4","line":67,"updated":"2021-03-09 00:32:10.000000000","message":"is sriov_nic_agent.py need it this too?","commit_id":"1e16a2b1c3e3b81813c399678b7f1fb234411ed3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"4679061cd9c78e1e8ea58134e243cf5cabeba0cf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                     portbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":65,"context_line":"                     portbindings.VNIC_ACCELERATOR_DIRECT,"},{"line_number":66,"context_line":"                     portbindings.VNIC_ACCELERATOR_DIRECT_PHYSICAL,"},{"line_number":67,"context_line":"                 ]):"},{"line_number":68,"context_line":"        \"\"\"Initialize base class for SriovNicSwitch L2 agent type."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param agent_type: Constant identifying agent type in agents_db"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfe09b7d_d33914af","line":67,"in_reply_to":"e017d3e7_e8f3d8f4","updated":"2021-03-09 03:25:12.000000000","message":"we don\u0027t need change sriov_nic_agent.py at all.","commit_id":"1e16a2b1c3e3b81813c399678b7f1fb234411ed3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"efcd3b4d91f67547d7739a5c815375e8c53304bf","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        # NOTE(ndipanov): PF passthrough requires a different vif type"},{"line_number":85,"context_line":"        self.vnic_type_for_vif_type \u003d ("},{"line_number":86,"context_line":"            {vtype: portbindings.VIF_TYPE_HOSTDEV_PHY"},{"line_number":87,"context_line":"                if vtype \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL"},{"line_number":88,"context_line":"                else portbindings.VIF_TYPE_HW_VEB"},{"line_number":89,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":90,"context_line":"        self.vif_details \u003d vif_details"}],"source_content_type":"text/x-python","patch_set":2,"id":"664c316c_e403ff3f","line":87,"updated":"2021-03-09 12:12:32.000000000","message":"Do we need to adapt this to the new vnic_types? I guess ACCELERATOR_DIRECT_PHYSICAL is similar to DIRECT_PHYSICAL","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3f8a80e74021f94034df830ad6ac727cb293d120","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # NOTE(ndipanov): PF passthrough requires a different vif type"},{"line_number":85,"context_line":"        self.vnic_type_for_vif_type \u003d ("},{"line_number":86,"context_line":"            {vtype: portbindings.VIF_TYPE_HOSTDEV_PHY"},{"line_number":87,"context_line":"                if vtype \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL"},{"line_number":88,"context_line":"                else portbindings.VIF_TYPE_HW_VEB"},{"line_number":89,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":90,"context_line":"        self.vif_details \u003d vif_details"}],"source_content_type":"text/x-python","patch_set":2,"id":"caf69d52_3e2f3a22","line":87,"in_reply_to":"42e371a8_f3cbe474","updated":"2021-03-09 13:58:31.000000000","message":"Refer to spec: https://review.opendev.org/c/openstack/nova-specs/+/742785/15/specs/wallaby/approved/support-sriov-smartnic.rst#16","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a28465c74dae76f4d009ca6436b62c6401033f3a","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        # NOTE(ndipanov): PF passthrough requires a different vif type"},{"line_number":85,"context_line":"        self.vnic_type_for_vif_type \u003d ("},{"line_number":86,"context_line":"            {vtype: portbindings.VIF_TYPE_HOSTDEV_PHY"},{"line_number":87,"context_line":"                if vtype \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL"},{"line_number":88,"context_line":"                else portbindings.VIF_TYPE_HW_VEB"},{"line_number":89,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":90,"context_line":"        self.vif_details \u003d vif_details"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2cdc06d_34b99f20","line":87,"in_reply_to":"664c316c_e403ff3f","updated":"2021-03-09 13:38:29.000000000","message":"based on the RFE (https://bugs.launchpad.net/neutron/+bug/1909100 ) it\u0027s true, ralonsoh, Yongli He could you answer these comments","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"4e7ff66b5bf60e7a98aaa70dc8ccc9a48ae9e574","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # NOTE(ndipanov): PF passthrough requires a different vif type"},{"line_number":85,"context_line":"        self.vnic_type_for_vif_type \u003d ("},{"line_number":86,"context_line":"            {vtype: portbindings.VIF_TYPE_HOSTDEV_PHY"},{"line_number":87,"context_line":"                if vtype \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL"},{"line_number":88,"context_line":"                else portbindings.VIF_TYPE_HW_VEB"},{"line_number":89,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":90,"context_line":"        self.vif_details \u003d vif_details"}],"source_content_type":"text/x-python","patch_set":2,"id":"42e371a8_f3cbe474","line":87,"in_reply_to":"a2cdc06d_34b99f20","updated":"2021-03-09 13:49:19.000000000","message":"We not supported ACCELERATOR_DIRECT_PHYSICAL yet. if we add it, it\u0027s prepare for future. I would rather leave it untouched.","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f40fe5d12c0c45791faa4af7bc67499c9c4e014a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # NOTE(ndipanov): PF passthrough requires a different vif type"},{"line_number":85,"context_line":"        self.vnic_type_for_vif_type \u003d ("},{"line_number":86,"context_line":"            {vtype: portbindings.VIF_TYPE_HOSTDEV_PHY"},{"line_number":87,"context_line":"                if vtype \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL"},{"line_number":88,"context_line":"                else portbindings.VIF_TYPE_HW_VEB"},{"line_number":89,"context_line":"             for vtype in self.supported_vnic_types})"},{"line_number":90,"context_line":"        self.vif_details \u003d vif_details"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e128fec_6e40bd38","line":87,"in_reply_to":"caf69d52_3e2f3a22","updated":"2021-03-09 14:11:09.000000000","message":"You are right here. For direct ports (PF) we need to change the vif type.\n\nAlthough this VNIC type is not supported, we can provide this support here in the SRIOV code.","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"efcd3b4d91f67547d7739a5c815375e8c53304bf","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        capabilities \u003d []"},{"line_number":125,"context_line":"        if profile:"},{"line_number":126,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":127,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":128,"context_line":"                \u0027switchdev\u0027 in capabilities):"},{"line_number":129,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s \""},{"line_number":130,"context_line":"                      \"with switchdev capability\", portbindings.VNIC_DIRECT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e50626d0_d5119383","line":127,"updated":"2021-03-09 12:12:32.000000000","message":"Does this applies to ACCELERATOR_DIRECT as well?","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5f1e76f72ca06feb57e8ef34736a04f08eecd16f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        capabilities \u003d []"},{"line_number":125,"context_line":"        if profile:"},{"line_number":126,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":127,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":128,"context_line":"                \u0027switchdev\u0027 in capabilities):"},{"line_number":129,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s \""},{"line_number":130,"context_line":"                      \"with switchdev capability\", portbindings.VNIC_DIRECT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cac3b36a_79c0f44b","line":127,"in_reply_to":"506a82ba_b2e2e669","updated":"2021-03-10 08:47:13.000000000","message":"Based on IRC discussion there won\u0027t be ports with VNIC_ACCELERATOR having switchdev in capabilities so it is OK not to add VNIC_ACCELERATOR to this condition","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f40fe5d12c0c45791faa4af7bc67499c9c4e014a","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        capabilities \u003d []"},{"line_number":125,"context_line":"        if profile:"},{"line_number":126,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":127,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":128,"context_line":"                \u0027switchdev\u0027 in capabilities):"},{"line_number":129,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s \""},{"line_number":130,"context_line":"                      \"with switchdev capability\", portbindings.VNIC_DIRECT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"506a82ba_b2e2e669","line":127,"in_reply_to":"c4243573_1da3a2eb","updated":"2021-03-09 14:11:09.000000000","message":"This is for OVS with HW offload [1]. Those ports are VF ports (VNIC_DIRECT) with this capability. Here we are refusing SRIOV mech driver to bind this port.\n\n[1]https://www.kernel.org/doc/Documentation/networking/switchdev.txt","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"4e7ff66b5bf60e7a98aaa70dc8ccc9a48ae9e574","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        capabilities \u003d []"},{"line_number":125,"context_line":"        if profile:"},{"line_number":126,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":127,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":128,"context_line":"                \u0027switchdev\u0027 in capabilities):"},{"line_number":129,"context_line":"            LOG.debug(\"Refusing to bind due to unsupported vnic_type: %s \""},{"line_number":130,"context_line":"                      \"with switchdev capability\", portbindings.VNIC_DIRECT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4243573_1da3a2eb","line":127,"in_reply_to":"e50626d0_d5119383","updated":"2021-03-09 13:49:19.000000000","message":"Seems we do need this, we don\u0027t have \u0027swithdev\u0027 either. thanks gibi","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"efcd3b4d91f67547d7739a5c815375e8c53304bf","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                      vnic_type)"},{"line_number":135,"context_line":"            return"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL:"},{"line_number":138,"context_line":"            # Physical functions don\u0027t support things like QoS properties,"},{"line_number":139,"context_line":"            # spoof checking, etc. so we might as well side-step the agent"},{"line_number":140,"context_line":"            # for now. The agent also doesn\u0027t currently recognize non-VF"}],"source_content_type":"text/x-python","patch_set":2,"id":"5d88fc4e_1927b972","line":137,"updated":"2021-03-09 12:12:32.000000000","message":"Do we need to adapt this to ACCELERATOR_DIRECT_PHYSICAL?","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"4e7ff66b5bf60e7a98aaa70dc8ccc9a48ae9e574","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                      vnic_type)"},{"line_number":135,"context_line":"            return"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL:"},{"line_number":138,"context_line":"            # Physical functions don\u0027t support things like QoS properties,"},{"line_number":139,"context_line":"            # spoof checking, etc. so we might as well side-step the agent"},{"line_number":140,"context_line":"            # for now. The agent also doesn\u0027t currently recognize non-VF"}],"source_content_type":"text/x-python","patch_set":2,"id":"96342a5e_12c5ec10","line":137,"in_reply_to":"5d88fc4e_1927b972","updated":"2021-03-09 13:49:19.000000000","message":"Same as L87.","commit_id":"13b118a6a70f80b655f92d1c3ad3f8a6288475a7"}]}