)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b8e714a5464f67cc6f45e3304e6646e4e78db96e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael D\u0027Silva \u003cmichael.dsilva@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-09 00:31:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sometimes port is type None, which causes a crash as seen in bug https://bugs.launchpad.net/neutron/+bug/1917409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id0fb7c56c078b338c7590e3753712257e188167d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f5fe884f_1507a119","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":112},"updated":"2021-03-09 09:45:13.000000000","message":"Add a short summary line and after keep ~80 chars in a line \nThe bug reference should be:\nCloses-Bug: #1917409","commit_id":"a99d4c0fea1c8992adb22e837b89ed1789603628"},{"author":{"_account_id":33199,"name":"Michael D\u0027Silva","display_name":"madsi1m","email":"michael.dsilva@outlook.com","username":"madsi1m"},"change_message_id":"efff5f3ca462e1f043178d9224caa36a542b651e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael D\u0027Silva \u003cmichael.dsilva@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-09 00:31:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sometimes port is type None, which causes a crash as seen in bug https://bugs.launchpad.net/neutron/+bug/1917409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id0fb7c56c078b338c7590e3753712257e188167d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e89f5f32_b1d25738","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":112},"in_reply_to":"f5fe884f_1507a119","updated":"2021-03-11 00:25:17.000000000","message":"Thankyou, have made changes and git review made https://review.opendev.org/c/openstack/neutron/+/779620","commit_id":"a99d4c0fea1c8992adb22e837b89ed1789603628"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc9763afeb4227e5f41eefbcaaff1a1876684fa7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael D\u0027Silva \u003cmichael.dsilva@aarnet.edu.au\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-10 09:26:24 +1100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sometimes port is type None, which causes a crash"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id0fb7c56c078b338c7590e3753712257e188167d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"28287e70_bd57ffb7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"updated":"2021-03-10 02:57:54.000000000","message":"Please add commit message by following this guide:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"c7b971bb03eb87acaf93d641061cce3a7411c7a4"}],"neutron/db/l3_db.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b8e714a5464f67cc6f45e3304e6646e4e78db96e","unresolved":true,"context_lines":[{"line_number":1742,"context_line":"    def _each_port_having_fixed_ips(ports):"},{"line_number":1743,"context_line":"        for port in ports or []:"},{"line_number":1744,"context_line":"            # Sometimes port is type None, which causes a crash, skip it"},{"line_number":1745,"context_line":"            if port is None:"},{"line_number":1746,"context_line":"                continue"},{"line_number":1747,"context_line":"            fixed_ips \u003d port.get(\u0027fixed_ips\u0027, [])"},{"line_number":1748,"context_line":"            if not fixed_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b1d04b4_64e3a502","line":1745,"range":{"start_line":1745,"start_character":12,"end_line":1745,"end_character":28},"updated":"2021-03-09 09:45:13.000000000","message":"if not port?","commit_id":"a99d4c0fea1c8992adb22e837b89ed1789603628"},{"author":{"_account_id":33199,"name":"Michael D\u0027Silva","display_name":"madsi1m","email":"michael.dsilva@outlook.com","username":"madsi1m"},"change_message_id":"efff5f3ca462e1f043178d9224caa36a542b651e","unresolved":false,"context_lines":[{"line_number":1742,"context_line":"    def _each_port_having_fixed_ips(ports):"},{"line_number":1743,"context_line":"        for port in ports or []:"},{"line_number":1744,"context_line":"            # Sometimes port is type None, which causes a crash, skip it"},{"line_number":1745,"context_line":"            if port is None:"},{"line_number":1746,"context_line":"                continue"},{"line_number":1747,"context_line":"            fixed_ips \u003d port.get(\u0027fixed_ips\u0027, [])"},{"line_number":1748,"context_line":"            if not fixed_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"caf43406_11ffe64d","line":1745,"range":{"start_line":1745,"start_character":12,"end_line":1745,"end_character":28},"in_reply_to":"9b1d04b4_64e3a502","updated":"2021-03-11 00:25:17.000000000","message":"Thank you, Have tested with if not port and it also works. Have made changes and git review made https://review.opendev.org/c/openstack/neutron/+/779620","commit_id":"a99d4c0fea1c8992adb22e837b89ed1789603628"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"046e428439fb12088508f4a00776ff548dbf471c","unresolved":true,"context_lines":[{"line_number":1743,"context_line":"        for port in ports or []:"},{"line_number":1744,"context_line":"            # Sometimes port is type None, which causes a crash, skip it"},{"line_number":1745,"context_line":"            if port is None:"},{"line_number":1746,"context_line":"                continue"},{"line_number":1747,"context_line":"            fixed_ips \u003d port.get(\u0027fixed_ips\u0027, [])"},{"line_number":1748,"context_line":"            if not fixed_ips:"},{"line_number":1749,"context_line":"                # Skip ports without IPs, which can occur if a subnet"}],"source_content_type":"text/x-python","patch_set":3,"id":"08d60658_cd76f3b5","line":1746,"updated":"2021-03-10 14:19:00.000000000","message":"So is the port in this case \u0027\u0027 or something?  It would be good to know what the caller is passing and fix them if it\u0027s bad data.","commit_id":"c7b971bb03eb87acaf93d641061cce3a7411c7a4"}]}