)]}'
{"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4494416b52a32e0e26c85ecc8b746de81a3c5cc4","unresolved":true,"context_lines":[{"line_number":542,"context_line":"            vf_config \u003d {\u0027vf\u0027: VF_NUM, \u0027rate\u0027: {\u0027min_tx_rate\u0027: 0,"},{"line_number":543,"context_line":"                                                \u0027max_tx_rate\u0027: 0}}"},{"line_number":544,"context_line":"            ip_link.set_vf_feature(vf_config)"},{"line_number":545,"context_line":"        except:"},{"line_number":546,"context_line":"            devices_without_support.add(device)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if devices_without_support:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fed66b7_016cbfec","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":15},"updated":"2021-03-11 08:59:27.000000000","message":"why not specific exception?","commit_id":"79bb91cbd46625b4fc15ec62f2a672e31d25fc6d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d7fda806e30f9dbbb0ca6e03ee70bb975d0b6af5","unresolved":true,"context_lines":[{"line_number":542,"context_line":"            vf_config \u003d {\u0027vf\u0027: VF_NUM, \u0027rate\u0027: {\u0027min_tx_rate\u0027: 0,"},{"line_number":543,"context_line":"                                                \u0027max_tx_rate\u0027: 0}}"},{"line_number":544,"context_line":"            ip_link.set_vf_feature(vf_config)"},{"line_number":545,"context_line":"        except:"},{"line_number":546,"context_line":"            devices_without_support.add(device)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if devices_without_support:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6dcb6361_0a2eb282","line":545,"range":{"start_line":545,"start_character":8,"end_line":545,"end_character":15},"in_reply_to":"5fed66b7_016cbfec","updated":"2021-03-11 09:37:22.000000000","message":"yeah, I should use InvalidArgument. That will cover the cases:\n- the vf does not exist\n- the min_tx_rate is not supported","commit_id":"79bb91cbd46625b4fc15ec62f2a672e31d25fc6d"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4494416b52a32e0e26c85ecc8b746de81a3c5cc4","unresolved":true,"context_lines":[{"line_number":291,"context_line":"def check_min_tx_rate_support():"},{"line_number":292,"context_line":"    result \u003d checks.min_tx_rate_support()"},{"line_number":293,"context_line":"    if not result:"},{"line_number":294,"context_line":"        LOG.error(\u0027There are SR-IOV network interfaces that do not support \u0027"},{"line_number":295,"context_line":"                  \u0027setting the minimum TX rate (dataplane enforced minimum \u0027"},{"line_number":296,"context_line":"                  \u0027guaranteed bandwidth) \"ip-link vf min_tx_rate\".\u0027)"},{"line_number":297,"context_line":"    return result"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"07209e2e_327a6d55","line":296,"range":{"start_line":294,"start_character":8,"end_line":296,"end_character":68},"updated":"2021-03-11 08:59:27.000000000","message":"Is it an error if operator/user was not going to use min_tx_rate at all? Will warning suit better?","commit_id":"79bb91cbd46625b4fc15ec62f2a672e31d25fc6d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d7fda806e30f9dbbb0ca6e03ee70bb975d0b6af5","unresolved":true,"context_lines":[{"line_number":291,"context_line":"def check_min_tx_rate_support():"},{"line_number":292,"context_line":"    result \u003d checks.min_tx_rate_support()"},{"line_number":293,"context_line":"    if not result:"},{"line_number":294,"context_line":"        LOG.error(\u0027There are SR-IOV network interfaces that do not support \u0027"},{"line_number":295,"context_line":"                  \u0027setting the minimum TX rate (dataplane enforced minimum \u0027"},{"line_number":296,"context_line":"                  \u0027guaranteed bandwidth) \"ip-link vf min_tx_rate\".\u0027)"},{"line_number":297,"context_line":"    return result"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e1cbd691_061170ad","line":296,"range":{"start_line":294,"start_character":8,"end_line":296,"end_character":68},"in_reply_to":"07209e2e_327a6d55","updated":"2021-03-11 09:37:22.000000000","message":"right, this should be a warning for this reason","commit_id":"79bb91cbd46625b4fc15ec62f2a672e31d25fc6d"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e68570de8e7e22368f0a766c4f4a519b6f895cab","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        except ip_lib.InvalidArgument:"},{"line_number":106,"context_line":"            # NOTE(ralonsoh): some NICs do not support \"min_tx_rate\" parameter."},{"line_number":107,"context_line":"            # https://bugs.launchpad.net/neutron/+bug/1918464"},{"line_number":108,"context_line":"            LOG.error(\u0027Device %(device)s does not support ip-link vf \u0027"},{"line_number":109,"context_line":"                      \u0027\"%(rate_type)s\" parameter.\u0027,"},{"line_number":110,"context_line":"                      {\u0027device\u0027: self.dev_name, \u0027rate_type\u0027: rate_type})"}],"source_content_type":"text/x-python","patch_set":3,"id":"834f1348_e2a6ebe7","line":108,"range":{"start_line":108,"start_character":16,"end_line":108,"end_character":21},"updated":"2021-03-11 14:55:37.000000000","message":"IIUC commit message and this message here, it\u0027s not really an error from our PoV. So maybe Warning would be enough here?","commit_id":"3a9e81bbb8e5a56bd69a1edf1d2922276841157b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a25220b0a18f681fcd7307dac4ddadeb85330c1e","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        except ip_lib.InvalidArgument:"},{"line_number":106,"context_line":"            # NOTE(ralonsoh): some NICs do not support \"min_tx_rate\" parameter."},{"line_number":107,"context_line":"            # https://bugs.launchpad.net/neutron/+bug/1918464"},{"line_number":108,"context_line":"            LOG.error(\u0027Device %(device)s does not support ip-link vf \u0027"},{"line_number":109,"context_line":"                      \u0027\"%(rate_type)s\" parameter.\u0027,"},{"line_number":110,"context_line":"                      {\u0027device\u0027: self.dev_name, \u0027rate_type\u0027: rate_type})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed69e472_c895ca88","line":108,"range":{"start_line":108,"start_character":16,"end_line":108,"end_character":21},"in_reply_to":"834f1348_e2a6ebe7","updated":"2021-03-11 15:41:51.000000000","message":"Because we are providing a sanity check to the user, if he/she persists in using this parameter (min-bw) in a SRIOV port QoS, then I would prefer to log this error. Of course, we\u0027ll exit this method gracefully, but the user must be aware that the QoS policy was not applied (this is indeed an error).","commit_id":"3a9e81bbb8e5a56bd69a1edf1d2922276841157b"}]}