)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"29e66827f09b36787714b5f7b2658e54e1a1ee5f","unresolved":true,"context_lines":[{"line_number":1023,"context_line":"                # so it does not leak the RAs generated for the tenant"},{"line_number":1024,"context_line":"                # networks via the provider network"},{"line_number":1025,"context_line":"                ipv6_ra_configs[\u0027send_periodic\u0027] \u003d ("},{"line_number":1026,"context_line":"                    \u0027false\u0027 if utils.is_provider_network(net) else \u0027true\u0027)"},{"line_number":1027,"context_line":"                ipv6_ra_configs[\u0027mtu\u0027] \u003d str(net[\u0027mtu\u0027])"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        return list(networks), ipv6_ra_configs"}],"source_content_type":"text/x-python","patch_set":2,"id":"aba532e8_6a7d4107","line":1026,"range":{"start_line":1026,"start_character":31,"end_line":1026,"end_character":61},"updated":"2021-03-18 08:35:22.000000000","message":"Shall we instead check that the port is serving as a gateway instead of just connecting a provider network?\n\nThe reason I mention this is because you can add a subnet belonging to a provider network to a router without it being a gateway. And in this case, you may want to send the RAs.\n\nWhat do you think? cc @Numan :)","commit_id":"dfe03d5484dcb2e6c1854683e1e4cbf4a7cd510b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b08b52a6739ecb6b31553fdb7c2988ca2159c278","unresolved":true,"context_lines":[{"line_number":1023,"context_line":"                # so it does not leak the RAs generated for the tenant"},{"line_number":1024,"context_line":"                # networks via the provider network"},{"line_number":1025,"context_line":"                ipv6_ra_configs[\u0027send_periodic\u0027] \u003d ("},{"line_number":1026,"context_line":"                    \u0027false\u0027 if utils.is_provider_network(net) else \u0027true\u0027)"},{"line_number":1027,"context_line":"                ipv6_ra_configs[\u0027mtu\u0027] \u003d str(net[\u0027mtu\u0027])"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        return list(networks), ipv6_ra_configs"}],"source_content_type":"text/x-python","patch_set":2,"id":"cdc44af1_3cc55f1f","line":1026,"range":{"start_line":1026,"start_character":31,"end_line":1026,"end_character":61},"in_reply_to":"aba532e8_6a7d4107","updated":"2021-03-18 09:08:16.000000000","message":"Right I will wait to see what numans think of it.\n\nCode-wise I think it\u0027s quite simple, we just need to see if the device owner of the port is \"network:router_gateway\".","commit_id":"dfe03d5484dcb2e6c1854683e1e4cbf4a7cd510b"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"c89260e1ae6247c8f7658828b14c612f16fd8698","unresolved":true,"context_lines":[{"line_number":1023,"context_line":"                # so it does not leak the RAs generated for the tenant"},{"line_number":1024,"context_line":"                # networks via the provider network"},{"line_number":1025,"context_line":"                ipv6_ra_configs[\u0027send_periodic\u0027] \u003d ("},{"line_number":1026,"context_line":"                    \u0027false\u0027 if utils.is_provider_network(net) else \u0027true\u0027)"},{"line_number":1027,"context_line":"                ipv6_ra_configs[\u0027mtu\u0027] \u003d str(net[\u0027mtu\u0027])"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        return list(networks), ipv6_ra_configs"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6b3b2b6_84beec41","line":1026,"range":{"start_line":1026,"start_character":31,"end_line":1026,"end_character":61},"in_reply_to":"cdc44af1_3cc55f1f","updated":"2021-03-18 09:21:02.000000000","message":"Agree with Daniel.\n\nI think vlan tenant provider networks may want to make use of OVN\u0027s RA functionality.\n\nIn such cases, ovn-controller should not leak the generated RAs out of the provider bridge.\n\nI think there is bugzilla for that.","commit_id":"dfe03d5484dcb2e6c1854683e1e4cbf4a7cd510b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"899d41f900d7b00388ce1cc14f7429bdea22f773","unresolved":true,"context_lines":[{"line_number":1023,"context_line":"                # so it does not leak the RAs generated for the tenant"},{"line_number":1024,"context_line":"                # networks via the provider network"},{"line_number":1025,"context_line":"                ipv6_ra_configs[\u0027send_periodic\u0027] \u003d ("},{"line_number":1026,"context_line":"                    \u0027false\u0027 if utils.is_provider_network(net) else \u0027true\u0027)"},{"line_number":1027,"context_line":"                ipv6_ra_configs[\u0027mtu\u0027] \u003d str(net[\u0027mtu\u0027])"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        return list(networks), ipv6_ra_configs"}],"source_content_type":"text/x-python","patch_set":2,"id":"386c292e_4d41b1cb","line":1026,"range":{"start_line":1026,"start_character":31,"end_line":1026,"end_character":61},"in_reply_to":"e6b3b2b6_84beec41","updated":"2021-03-18 09:48:24.000000000","message":"Thanks folks! I will update the patch","commit_id":"dfe03d5484dcb2e6c1854683e1e4cbf4a7cd510b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"798f921f4abb518c93f39afec9416aaeeb929c67","unresolved":true,"context_lines":[{"line_number":1026,"context_line":"                # leak the RAs generated for the tenant networks via the"},{"line_number":1027,"context_line":"                # provider network"},{"line_number":1028,"context_line":"                ipv6_ra_configs[\u0027send_periodic\u0027] \u003d \u0027true\u0027"},{"line_number":1029,"context_line":"                if is_gw_port and utils.is_provider_network(net):"},{"line_number":1030,"context_line":"                    ipv6_ra_configs[\u0027send_periodic\u0027] \u003d \u0027false\u0027"},{"line_number":1031,"context_line":"                ipv6_ra_configs[\u0027mtu\u0027] \u003d str(net[\u0027mtu\u0027])"},{"line_number":1032,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"68286579_41b1677d","line":1029,"updated":"2021-03-18 14:00:05.000000000","message":"Theoretically it can be that gateway port will belong to non provider network so we should check it like that but practically speaking, I don\u0027t see any real use case for that TBH.","commit_id":"1f68336b79b0432308cdee42ea39ede49707dfa3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"40ac4bfd1f37d6021d703c6df276d3dbe367b342","unresolved":true,"context_lines":[{"line_number":1026,"context_line":"                # leak the RAs generated for the tenant networks via the"},{"line_number":1027,"context_line":"                # provider network"},{"line_number":1028,"context_line":"                ipv6_ra_configs[\u0027send_periodic\u0027] \u003d \u0027true\u0027"},{"line_number":1029,"context_line":"                if is_gw_port and utils.is_provider_network(net):"},{"line_number":1030,"context_line":"                    ipv6_ra_configs[\u0027send_periodic\u0027] \u003d \u0027false\u0027"},{"line_number":1031,"context_line":"                ipv6_ra_configs[\u0027mtu\u0027] \u003d str(net[\u0027mtu\u0027])"},{"line_number":1032,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7432f79d_bc18f624","line":1029,"in_reply_to":"68286579_41b1677d","updated":"2021-03-19 11:27:34.000000000","message":"Yeah true, maybe only checking if it\u0027s a gateway port should be enough, But still, it\u0027s better to be on the safe side here (IMHO)","commit_id":"1f68336b79b0432308cdee42ea39ede49707dfa3"}]}