)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5242b838b13eac4ade244de273e9b101d468289b","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So this patch relax a bit those new policies to make them available also"},{"line_number":19,"context_line":"for PROJECT_ADMIN users to mimic old behaviour, at least for now."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0580bbabd1d9af7a5f2c60b63c42a977d73eeefe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8fd22566_6e2da0f7","line":20,"updated":"2021-03-17 11:57:15.000000000","message":"neutron-meeting discussion link: http://eavesdrop.openstack.org/irclogs/%23openstack-meeting-3/%23openstack-meeting-3.2021-03-16.log.html#t2021-03-16T14:15:09","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"}],"neutron/conf/policies/floatingip.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                \u0027path\u0027: COLLECTION_PATH,"},{"line_number":33,"context_line":"            },"},{"line_number":34,"context_line":"        ],"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"        deprecated_rule\u003dpolicy.DeprecatedRule("},{"line_number":37,"context_line":"            name\u003d\u0027create_floatingip\u0027,"},{"line_number":38,"context_line":"            check_str\u003dbase.RULE_ANY),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5e68f01d_0666153d","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":28},"updated":"2021-03-18 08:27:26.000000000","message":"Why this change? Is this related?","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                \u0027path\u0027: COLLECTION_PATH,"},{"line_number":33,"context_line":"            },"},{"line_number":34,"context_line":"        ],"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":36,"context_line":"        deprecated_rule\u003dpolicy.DeprecatedRule("},{"line_number":37,"context_line":"            name\u003d\u0027create_floatingip\u0027,"},{"line_number":38,"context_line":"            check_str\u003dbase.RULE_ANY),"}],"source_content_type":"text/x-python","patch_set":2,"id":"f225a765_ca5bb053","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":28},"in_reply_to":"5e68f01d_0666153d","updated":"2021-03-18 09:07:56.000000000","message":"yes, otherwise user without scope type \"system\" wouldn\u0027t be able to create fip","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"}],"neutron/conf/policies/logging.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        name\u003d\u0027create_log\u0027,"},{"line_number":47,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":48,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":49,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":50,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":51,"context_line":"        description\u003d\u0027Create a network log\u0027,"},{"line_number":52,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"380dbfa8_92c2f8c0","line":49,"updated":"2021-03-18 08:27:26.000000000","message":"That was a system admin task only. I don\u0027t think a project admin should be able to do this.","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        name\u003d\u0027create_log\u0027,"},{"line_number":47,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":48,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":49,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":50,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":51,"context_line":"        description\u003d\u0027Create a network log\u0027,"},{"line_number":52,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"dfe4147f_8e2c1a24","line":49,"in_reply_to":"380dbfa8_92c2f8c0","updated":"2021-03-18 09:07:56.000000000","message":"It\u0027s the same case here. Log is owned by some project. With old rules, there was only one type of admin users and it always had project_id in context. Now SYSTEM_ADMIN don\u0027t have it so we are adding PROJECT_ADMIN to such calls to kind of mimic old behavior.","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"}],"neutron/conf/policies/network.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":47,"context_line":"        name\u003d\u0027create_network\u0027,"},{"line_number":48,"context_line":"        check_str\u003dbase.PROJECT_MEMBER,"},{"line_number":49,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":50,"context_line":"        description\u003d\u0027Create a network\u0027,"},{"line_number":51,"context_line":"        operations\u003dACTION_POST,"},{"line_number":52,"context_line":"        deprecated_rule\u003dpolicy.DeprecatedRule("}],"source_content_type":"text/x-python","patch_set":2,"id":"746c7f95_92d35a22","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":28},"updated":"2021-03-18 08:27:26.000000000","message":"Why this?","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":47,"context_line":"        name\u003d\u0027create_network\u0027,"},{"line_number":48,"context_line":"        check_str\u003dbase.PROJECT_MEMBER,"},{"line_number":49,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":50,"context_line":"        description\u003d\u0027Create a network\u0027,"},{"line_number":51,"context_line":"        operations\u003dACTION_POST,"},{"line_number":52,"context_line":"        deprecated_rule\u003dpolicy.DeprecatedRule("}],"source_content_type":"text/x-python","patch_set":2,"id":"328d318a_9a003f38","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":28},"in_reply_to":"746c7f95_92d35a22","updated":"2021-03-18 09:07:56.000000000","message":"Same like in FIPs","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":202,"context_line":"        name\u003d\u0027get_network:router:external\u0027,"},{"line_number":203,"context_line":"        check_str\u003dbase.PROJECT_READER,"},{"line_number":204,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":205,"context_line":"        description\u003d\u0027Get ``router:external`` attribute of a network\u0027,"},{"line_number":206,"context_line":"        operations\u003dACTION_GET,"},{"line_number":207,"context_line":"        deprecated_rule\u003dpolicy.DeprecatedRule("}],"source_content_type":"text/x-python","patch_set":2,"id":"684a3655_288b4eba","line":204,"range":{"start_line":204,"start_character":22,"end_line":204,"end_character":28},"updated":"2021-03-18 08:27:26.000000000","message":"ditto","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":202,"context_line":"        name\u003d\u0027get_network:router:external\u0027,"},{"line_number":203,"context_line":"        check_str\u003dbase.PROJECT_READER,"},{"line_number":204,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":205,"context_line":"        description\u003d\u0027Get ``router:external`` attribute of a network\u0027,"},{"line_number":206,"context_line":"        operations\u003dACTION_GET,"},{"line_number":207,"context_line":"        deprecated_rule\u003dpolicy.DeprecatedRule("}],"source_content_type":"text/x-python","patch_set":2,"id":"8e1baf84_882962ac","line":204,"range":{"start_line":204,"start_character":22,"end_line":204,"end_character":28},"in_reply_to":"684a3655_288b4eba","updated":"2021-03-18 09:07:56.000000000","message":"same","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"}],"neutron/conf/policies/network_segment_range.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":33,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":34,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":36,"context_line":"        description\u003d\u0027Create a network segment range\u0027,"},{"line_number":37,"context_line":"        operations\u003d["},{"line_number":38,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"e392bd3f_11f63444","line":35,"updated":"2021-03-18 08:27:26.000000000","message":"If you add the project admin, shouldn\u0027t you need to add the project scope too?","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":33,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":34,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":35,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":36,"context_line":"        description\u003d\u0027Create a network segment range\u0027,"},{"line_number":37,"context_line":"        operations\u003d["},{"line_number":38,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"38e4176a_949b38ee","line":35,"in_reply_to":"e392bd3f_11f63444","updated":"2021-03-18 09:07:56.000000000","message":"Yes, I missed that. Added now.","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":73,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":74,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":75,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":76,"context_line":"        description\u003d\u0027Update a network segment range\u0027,"},{"line_number":77,"context_line":"        operations\u003d["},{"line_number":78,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"d1ec2fb3_2b8dd9bd","line":75,"updated":"2021-03-18 08:27:26.000000000","message":"ditto","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":73,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":74,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":75,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":76,"context_line":"        description\u003d\u0027Update a network segment range\u0027,"},{"line_number":77,"context_line":"        operations\u003d["},{"line_number":78,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"83d08eee_3b9ff5dc","line":75,"in_reply_to":"d1ec2fb3_2b8dd9bd","updated":"2021-03-18 09:07:56.000000000","message":"Done","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c636cb0077f5ca01e7ca61d784b5b9f28da01812","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        name\u003d\u0027delete_network_segment_range\u0027,"},{"line_number":91,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":92,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":93,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":94,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":95,"context_line":"        description\u003d\u0027Delete a network segment range\u0027,"},{"line_number":96,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8ed77f_66808e30","line":93,"updated":"2021-03-18 08:27:26.000000000","message":"ditto","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55dec51c6d0a98a39e7c0dd6253372c510bd1acd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        name\u003d\u0027delete_network_segment_range\u0027,"},{"line_number":91,"context_line":"        check_str\u003dbase.policy_or("},{"line_number":92,"context_line":"            base.SYSTEM_ADMIN,"},{"line_number":93,"context_line":"            base.PROJECT_ADMIN),"},{"line_number":94,"context_line":"        scope_types\u003d[\u0027system\u0027],"},{"line_number":95,"context_line":"        description\u003d\u0027Delete a network segment range\u0027,"},{"line_number":96,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"4164ccec_d23bbe89","line":93,"in_reply_to":"ba8ed77f_66808e30","updated":"2021-03-18 09:07:56.000000000","message":"Done","commit_id":"18491c2dcbf1667e6e61f6ca3a815e02662b6612"}]}