)]}'
{"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a5bec14f8a6e18196ed0e7da6b38a7102bbeac9d","unresolved":true,"context_lines":[{"line_number":196,"context_line":"            self._fanout_message(context, method, payload)"},{"line_number":197,"context_line":"        elif cast_required:"},{"line_number":198,"context_line":"            admin_ctx \u003d (context if context.is_admin else"},{"line_number":199,"context_line":"                         common_utils.get_elevated_context(context))"},{"line_number":200,"context_line":"            network \u003d self.plugin.get_network(admin_ctx, network_id)"},{"line_number":201,"context_line":"            if \u0027subnet\u0027 in payload and payload[\u0027subnet\u0027].get(\u0027segment_id\u0027):"},{"line_number":202,"context_line":"                # if segment_id exists then the segment service plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"94a7e336_5f933dfc","line":199,"updated":"2021-03-19 15:39:34.000000000","message":"I\u0027m not asking you to change things, but this would be cleaner as:\n\nadmin_ctx \u003d common_utils.get_elevated_context(context)\n\nAnd have get_elevated_context() just return \"context if context.is_admin\" early if set.","commit_id":"062336e59bb3d427bf4094779dc8e93d92c078d5"}],"neutron/core_extensions/qos.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a5bec14f8a6e18196ed0e7da6b38a7102bbeac9d","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _update_port_policy(self, context, port, port_changes):"},{"line_number":50,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":51,"context_line":"            common_utils.get_elevated_context(context), port[\u0027id\u0027])"},{"line_number":52,"context_line":"        if old_policy:"},{"line_number":53,"context_line":"            self._check_policy_change_permission(context, old_policy)"},{"line_number":54,"context_line":"            old_policy.detach_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6e7bee2_74530980","line":51,"updated":"2021-03-19 15:39:34.000000000","message":"Although I guess my earlier comment falls apart here :(","commit_id":"062336e59bb3d427bf4094779dc8e93d92c078d5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78aa712747d49e09d5d928fc7510afa936ee2c23","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _update_port_policy(self, context, port, port_changes):"},{"line_number":50,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":51,"context_line":"            common_utils.get_elevated_context(context), port[\u0027id\u0027])"},{"line_number":52,"context_line":"        if old_policy:"},{"line_number":53,"context_line":"            self._check_policy_change_permission(context, old_policy)"},{"line_number":54,"context_line":"            old_policy.detach_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8b6301e_9f828f6b","line":51,"in_reply_to":"a6e7bee2_74530980","updated":"2021-03-19 15:44:06.000000000","message":"yes, and I wanted to make this change as small as possible to be sure that functionally it is the same with old code really, except that system_scope setting added.","commit_id":"062336e59bb3d427bf4094779dc8e93d92c078d5"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a5bec14f8a6e18196ed0e7da6b38a7102bbeac9d","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                    _constants.AUTO_DELETE_PORT_OWNERS))]"},{"line_number":486,"context_line":"        for port_id in auto_delete_port_ids:"},{"line_number":487,"context_line":"            try:"},{"line_number":488,"context_line":"                self.delete_port(utils.get_elevated_context(context), port_id)"},{"line_number":489,"context_line":"            except exc.PortNotFound:"},{"line_number":490,"context_line":"                # Don\u0027t raise if something else concurrently deleted the port"},{"line_number":491,"context_line":"                LOG.debug(\"Ignoring PortNotFound when deleting port \u0027%s\u0027. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"c054997c_9660413a","line":488,"updated":"2021-03-19 15:39:34.000000000","message":"I guess these could also check context.is_admin, but let\u0027s not change in this one.\n\nI know of lot of these were elevated as bugs were found (think DVR) where you had to be admin, but maybe worth fixing completely in Xena.","commit_id":"062336e59bb3d427bf4094779dc8e93d92c078d5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78aa712747d49e09d5d928fc7510afa936ee2c23","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                    _constants.AUTO_DELETE_PORT_OWNERS))]"},{"line_number":486,"context_line":"        for port_id in auto_delete_port_ids:"},{"line_number":487,"context_line":"            try:"},{"line_number":488,"context_line":"                self.delete_port(utils.get_elevated_context(context), port_id)"},{"line_number":489,"context_line":"            except exc.PortNotFound:"},{"line_number":490,"context_line":"                # Don\u0027t raise if something else concurrently deleted the port"},{"line_number":491,"context_line":"                LOG.debug(\"Ignoring PortNotFound when deleting port \u0027%s\u0027. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"701f9ce9_aaf1bd3a","line":488,"in_reply_to":"c054997c_9660413a","updated":"2021-03-19 15:44:06.000000000","message":"+1","commit_id":"062336e59bb3d427bf4094779dc8e93d92c078d5"}]}