)]}'
{"tools/ovn_migration/tripleo_environment/playbooks/roles/prepare-controllers/tasks/main.yml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e94d2ec0fec2948a0e48ddaf92ed84fe03ed5614","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  register: mysql_url"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Change vxlan networks to Geneve"},{"line_number":8,"context_line":"  shell: podman exec -it neutron_api python3 -c $\u0027from sqlalchemy import create_engine\\nengine \u003d create_engine(\"{{ mysql_url.stdout }}\")\\nwith engine.connect() as conn:\\n\\tconn.execute(\"update networksegments set networksegments.network_type\u003d\\\u0027geneve\\\u0027 where networksegments.network_type\u003d\\\u0027vxlan\\\u0027;\")\u0027"},{"line_number":9,"context_line":"  when: ovn_central is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"acc4145f_1d531066","line":8,"range":{"start_line":8,"start_character":50,"end_line":8,"end_character":298},"updated":"2021-03-22 09:15:19.000000000","message":"this isn\u0027t easiest way to read and review python code 😊","commit_id":"d3fce77ff58e90a0ef55536a109c3027aad8f21c"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"9b1472e21376c490f92bf60f949af0c590ef150a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  register: mysql_url"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Change vxlan networks to Geneve"},{"line_number":8,"context_line":"  shell: podman exec -it neutron_api python3 -c $\u0027from sqlalchemy import create_engine\\nengine \u003d create_engine(\"{{ mysql_url.stdout }}\")\\nwith engine.connect() as conn:\\n\\tconn.execute(\"update networksegments set networksegments.network_type\u003d\\\u0027geneve\\\u0027 where networksegments.network_type\u003d\\\u0027vxlan\\\u0027;\")\u0027"},{"line_number":9,"context_line":"  when: ovn_central is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d3c40321_b0995291","line":8,"range":{"start_line":8,"start_character":50,"end_line":8,"end_character":298},"in_reply_to":"acc4145f_1d531066","updated":"2021-03-22 13:11:13.000000000","message":"oh my 😊\nMaybe adding a comment before with indented, readable code would help","commit_id":"d3fce77ff58e90a0ef55536a109c3027aad8f21c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"94bcfb9d74639d7e24525394cb82acca3a076d5d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  register: mysql_url"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Change vxlan networks to Geneve"},{"line_number":8,"context_line":"  shell: podman exec -it neutron_api python3 -c $\u0027from sqlalchemy import create_engine\\nengine \u003d create_engine(\"{{ mysql_url.stdout }}\")\\nwith engine.connect() as conn:\\n\\tconn.execute(\"update networksegments set networksegments.network_type\u003d\\\u0027geneve\\\u0027 where networksegments.network_type\u003d\\\u0027vxlan\\\u0027;\")\u0027"},{"line_number":9,"context_line":"  when: ovn_central is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fec1935f_dd7d288d","line":8,"range":{"start_line":8,"start_character":50,"end_line":8,"end_character":298},"in_reply_to":"d3c40321_b0995291","updated":"2021-03-23 08:57:04.000000000","message":"I missed this comment, thanks, you\u0027re right :) It\u0027s hard to read, I sent a follow up here https://review.opendev.org/c/openstack/neutron/+/782378","commit_id":"d3fce77ff58e90a0ef55536a109c3027aad8f21c"}]}