)]}'
{"neutron/opts.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e4b0df30ff1725e34d83e1026a43b4af457a66f4","unresolved":true,"context_lines":[{"line_number":245,"context_line":"             meta_conf.SHARED_OPTS,"},{"line_number":246,"context_line":"             meta_conf.METADATA_PROXY_HANDLER_OPTS,"},{"line_number":247,"context_line":"             meta_conf.UNIX_DOMAIN_METADATA_PROXY_OPTS,"},{"line_number":248,"context_line":"             neutron.conf.service.RPC_EXTRA_OPTS)"},{"line_number":249,"context_line":"         ),"},{"line_number":250,"context_line":"        (\u0027agent\u0027, neutron.conf.agent.common.AGENT_STATE_OPTS)"},{"line_number":251,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"63d3b052_453cd36a","line":248,"range":{"start_line":248,"start_character":13,"end_line":248,"end_character":48},"updated":"2021-03-23 08:43:08.000000000","message":"It\u0027s included in list_base_agent_opts(). Please see https://review.opendev.org/c/openstack/neutron/+/705779 for l3 agent.\nI believe just need to register opt like done in https://review.opendev.org/c/openstack/neutron/+/731194/5/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py","commit_id":"fa4ef824be8a6eea6d22bfb711fd4c844dfa63b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"404fb6927ff0db0dd35120d3470987be774b94b8","unresolved":true,"context_lines":[{"line_number":245,"context_line":"             meta_conf.SHARED_OPTS,"},{"line_number":246,"context_line":"             meta_conf.METADATA_PROXY_HANDLER_OPTS,"},{"line_number":247,"context_line":"             meta_conf.UNIX_DOMAIN_METADATA_PROXY_OPTS,"},{"line_number":248,"context_line":"             neutron.conf.service.RPC_EXTRA_OPTS)"},{"line_number":249,"context_line":"         ),"},{"line_number":250,"context_line":"        (\u0027agent\u0027, neutron.conf.agent.common.AGENT_STATE_OPTS)"},{"line_number":251,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c826baa_612b08bb","line":248,"range":{"start_line":248,"start_character":13,"end_line":248,"end_character":48},"in_reply_to":"63d3b052_453cd36a","updated":"2021-03-23 09:04:34.000000000","message":"\u003e It\u0027s included in list_base_agent_opts(). Please see https://review.opendev.org/c/openstack/neutron/+/705779 for l3 agent.\n\nWe do need to add this here because we don\u0027t include neutron.base.agent to generate medatata_agent.ini .\n\nhttps://github.com/openstack/neutron/blob/master/etc/oslo-config-generator/metadata_agent.ini#L5-L7\n\n\n\u003e I believe just need to register opt like done in https://review.opendev.org/c/openstack/neutron/+/731194/5/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py\n\nThanks for the catch. Yes that is what we definitely need. I\u0027ll update this patch asap.","commit_id":"fa4ef824be8a6eea6d22bfb711fd4c844dfa63b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ce70c44c69a87302b15e4621b3982fbb73a149c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"             meta_conf.SHARED_OPTS,"},{"line_number":246,"context_line":"             meta_conf.METADATA_PROXY_HANDLER_OPTS,"},{"line_number":247,"context_line":"             meta_conf.UNIX_DOMAIN_METADATA_PROXY_OPTS,"},{"line_number":248,"context_line":"             neutron.conf.service.RPC_EXTRA_OPTS)"},{"line_number":249,"context_line":"         ),"},{"line_number":250,"context_line":"        (\u0027agent\u0027, neutron.conf.agent.common.AGENT_STATE_OPTS)"},{"line_number":251,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"459d0c4a_067bf65f","line":248,"range":{"start_line":248,"start_character":13,"end_line":248,"end_character":48},"in_reply_to":"7c826baa_612b08bb","updated":"2021-03-23 09:11:03.000000000","message":"The second comment was addressed in the patch set 2. I\u0027ll mark this resolved now but please feel free to post additional comment if I have any misunderstanding about the first point.","commit_id":"fa4ef824be8a6eea6d22bfb711fd4c844dfa63b5"}]}