)]}'
{"neutron/services/placement_report/plugin.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a2bca5a80ce12a777abf94006073c68784ca7d59","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                        LOG.info("},{"line_number":170,"context_line":"                            \u0027The \"%s\" log message below may be due to bug:\u0027"},{"line_number":171,"context_line":"                            \u0027 https://launchpad.net/bugs/1921150\u0027,"},{"line_number":172,"context_line":"                            placement_error_str)"},{"line_number":173,"context_line":"                    LOG.exception("},{"line_number":174,"context_line":"                        \u0027placement client call failed: %s\u0027,"},{"line_number":175,"context_line":"                        str(deferred))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b1c2eda_5fc67ac7","line":172,"updated":"2021-03-24 17:09:05.000000000","message":"this now further increase the amount of log we do repeatedly. Would it make sense to do something like\n\n  if reparinting-error:\n      LOG.exception(re-parenting specific error message pointing to the bug)\n  else:\n      LOG.exception(\u0027placement client call failed: %s\u0027, str(deferred))","commit_id":"01a19fa69610a020e89205432721f674c96e7ddf"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"dc59e815afa1284ada72813894f88bc47fade87b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        LOG.info("},{"line_number":170,"context_line":"                            \u0027The \"%s\" log message below may be due to bug:\u0027"},{"line_number":171,"context_line":"                            \u0027 https://launchpad.net/bugs/1921150\u0027,"},{"line_number":172,"context_line":"                            placement_error_str)"},{"line_number":173,"context_line":"                    LOG.exception("},{"line_number":174,"context_line":"                        \u0027placement client call failed: %s\u0027,"},{"line_number":175,"context_line":"                        str(deferred))"}],"source_content_type":"text/x-python","patch_set":3,"id":"0785a7a7_68c485a1","line":172,"in_reply_to":"7b1c2eda_5fc67ac7","updated":"2021-03-25 14:35:59.000000000","message":"Done","commit_id":"01a19fa69610a020e89205432721f674c96e7ddf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"146cccdb3aad5d49985bb45ca87ee989b5487891","unresolved":true,"context_lines":[{"line_number":173,"context_line":"                        )"},{"line_number":174,"context_line":"                    else:"},{"line_number":175,"context_line":"                        msg \u003d \u0027placement client call failed: %s\u0027"},{"line_number":176,"context_line":"                    LOG.exception(msg, str(deferred))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            resources_synced \u003d not errors"},{"line_number":179,"context_line":"            agent_db.resources_synced \u003d resources_synced"}],"source_content_type":"text/x-python","patch_set":4,"id":"95838587_e3143106","line":176,"updated":"2021-03-26 09:33:46.000000000","message":"thanks this is what I was after about the logging.","commit_id":"cd7a5d3bc5b1f245a531d92c1d68916f954f8850"}],"releasenotes/notes/bug-1921150-c02692e548a3750e.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c3ff74ccc2bc0edbee62d3e1e5284a28c89f70bd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    RP).  However Placement does not allow re-parenting an already"},{"line_number":10,"context_line":"    existing resource provider, therefore the following Placement"},{"line_number":11,"context_line":"    DB update may be needed after the fix for bug 1921150 is applied:"},{"line_number":12,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1921150/+attachment/5480873/+files/fix-bug-1921150-re-parent-device-rps.sql"},{"line_number":13,"context_line":"    Until all resource providers have the proper parent, neutron-server"},{"line_number":14,"context_line":"    will retry the re-parenting update, which will be rejected every time,"},{"line_number":15,"context_line":"    therefore expect polluted logs and some wasted load on Placement."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7b3142b9_73e330fe","line":12,"updated":"2021-03-26 08:53:12.000000000","message":"should we maybe include that script in the tools/ directory in neutron repo? If that is official tool to be run to fix that issue. Or maybe it shouldn\u0027t be considered as official tool, so then IMHO we shouldn\u0027t mention it in the release note","commit_id":"cd7a5d3bc5b1f245a531d92c1d68916f954f8850"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ebb74e8549d80162dc621ba55c4734b27577e987","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    RP).  However Placement does not allow re-parenting an already"},{"line_number":10,"context_line":"    existing resource provider, therefore the following Placement"},{"line_number":11,"context_line":"    DB update may be needed after the fix for bug 1921150 is applied:"},{"line_number":12,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1921150/+attachment/5480873/+files/fix-bug-1921150-re-parent-device-rps.sql"},{"line_number":13,"context_line":"    Until all resource providers have the proper parent, neutron-server"},{"line_number":14,"context_line":"    will retry the re-parenting update, which will be rejected every time,"},{"line_number":15,"context_line":"    therefore expect polluted logs and some wasted load on Placement."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9d23b95b_d98eb889","line":12,"in_reply_to":"7b3142b9_73e330fe","updated":"2021-03-26 14:44:32.000000000","message":"If somebody top of me could review / test that script then I\u0027m OK to make that official. :)","commit_id":"cd7a5d3bc5b1f245a531d92c1d68916f954f8850"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f4158c6bcebede952913a9db68a14a3e157c9171","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    RP).  However Placement does not allow re-parenting an already"},{"line_number":10,"context_line":"    existing resource provider, therefore the following Placement"},{"line_number":11,"context_line":"    DB update may be needed after the fix for bug 1921150 is applied:"},{"line_number":12,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1921150/+attachment/5480873/+files/fix-bug-1921150-re-parent-device-rps.sql"},{"line_number":13,"context_line":"    Until all resource providers have the proper parent, neutron-server"},{"line_number":14,"context_line":"    will retry the re-parenting update, which will be rejected every time,"},{"line_number":15,"context_line":"    therefore expect polluted logs and some wasted load on Placement."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"28c6744b_fb55cdec","line":12,"in_reply_to":"7b945827_9558844d","updated":"2021-03-26 15:11:37.000000000","message":"thanks! then the this reno link can be changed to a repo relative path, I think.","commit_id":"cd7a5d3bc5b1f245a531d92c1d68916f954f8850"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"bbbf12ee87f9d8a2bad406b6cf33afb4f7ed6f04","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    RP).  However Placement does not allow re-parenting an already"},{"line_number":10,"context_line":"    existing resource provider, therefore the following Placement"},{"line_number":11,"context_line":"    DB update may be needed after the fix for bug 1921150 is applied:"},{"line_number":12,"context_line":"    https://bugs.launchpad.net/neutron/+bug/1921150/+attachment/5480873/+files/fix-bug-1921150-re-parent-device-rps.sql"},{"line_number":13,"context_line":"    Until all resource providers have the proper parent, neutron-server"},{"line_number":14,"context_line":"    will retry the re-parenting update, which will be rejected every time,"},{"line_number":15,"context_line":"    therefore expect polluted logs and some wasted load on Placement."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7b945827_9558844d","line":12,"in_reply_to":"9d23b95b_d98eb889","updated":"2021-03-26 14:45:45.000000000","message":"I\u0027ll include it in this change, then it can be reviewed here.","commit_id":"cd7a5d3bc5b1f245a531d92c1d68916f954f8850"}],"tools/bug-1921150-re-parent-device-rps.sql":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c0ec0ead2393a3835a7e3f1c44e07bd468a05404","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"    a copy of the License at"}],"source_content_type":"text/x-sql","patch_set":5,"id":"80526d38_dfaca7c4","line":1,"updated":"2021-03-29 09:51:38.000000000","message":"whouldn\u0027t be better if that would be python script which would get sql connection parameters from the neutron\u0027s config file and would then connect to db and execute that queries there?","commit_id":"7f35e4e857f7c6e83c635125ce9b42df6e10a510"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ca0c6a64c80fce2678804e8c41fb5ad799052521","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"    a copy of the License at"}],"source_content_type":"text/x-sql","patch_set":5,"id":"a06444c2_61e9b357","line":1,"in_reply_to":"262d8fb1_9e191789","updated":"2021-04-13 10:23:58.000000000","message":"\u003e Do we want to have a CLI tool in neutron directly modifying the placement DB?\n\nYou are probably right. We shouldn\u0027t have such tool in Neutron.\nBut that makes another question - is neutron really best place to have that script? Maybe it should be in placement repo? (I\u0027m just asking about opinions but not against having it here)\n\n\u003e \n\u003e Please also consider this:\n\u003e https://review.opendev.org/c/openstack/neutron-lib/+/785337","commit_id":"7f35e4e857f7c6e83c635125ce9b42df6e10a510"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"67548a2de4dbe26cae25db75a46f9376ee3faf38","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"    a copy of the License at"}],"source_content_type":"text/x-sql","patch_set":5,"id":"262d8fb1_9e191789","line":1,"in_reply_to":"5b9ae87a_ddb3b5e8","updated":"2021-04-12 10:46:30.000000000","message":"Do we want to have a CLI tool in neutron directly modifying the placement DB?\n\nPlease also consider this:\nhttps://review.opendev.org/c/openstack/neutron-lib/+/785337","commit_id":"7f35e4e857f7c6e83c635125ce9b42df6e10a510"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"397a799c4c10c9de7df2a506700d8844fdb2a49e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"    a copy of the License at"}],"source_content_type":"text/x-sql","patch_set":5,"id":"5b9ae87a_ddb3b5e8","line":1,"in_reply_to":"80526d38_dfaca7c4","updated":"2021-03-29 10:35:21.000000000","message":"Something like a new CLI for neutron like [1]?\n\nPlease note that the placement db access information can only be safely taken from the placement.conf as placement might use a different DB server than neutron.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/cmd/ovs_cleanup.py","commit_id":"7f35e4e857f7c6e83c635125ce9b42df6e10a510"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c2566da537506b6638b39d5020607abd0128f319","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":"    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"    a copy of the License at"}],"source_content_type":"text/x-sql","patch_set":5,"id":"a1a3f9f1_c4916a21","line":1,"in_reply_to":"a06444c2_61e9b357","updated":"2021-04-14 13:44:52.000000000","message":"If we put it in placement then we can assume that the user knows that the placement DB needs to be used for the script. However this script depends on facts that are not placement specific, e.g. that we have a certain networking RP tree, and that we have a networking bug in that tree to be fixed. From placement perspective both the buggy and the good tree are equally valid RP trees.\n\nPersonally I\u0027m OK not to store the script in the repo. It is attached to the bug report so admins can find it.","commit_id":"7f35e4e857f7c6e83c635125ce9b42df6e10a510"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f4158c6bcebede952913a9db68a14a3e157c9171","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Fix wrongly parented physical NIC resource providers due to bug"},{"line_number":17,"context_line":"https://bugs.launchpad.net/neutron/+bug/1921150"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Compatible with MySQL."},{"line_number":20,"context_line":"*/"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"USE placement;"}],"source_content_type":"text/x-sql","patch_set":5,"id":"e68527b3_fd9e83b1","line":19,"updated":"2021-03-26 15:11:37.000000000","message":"thanks. This is correct.","commit_id":"7f35e4e857f7c6e83c635125ce9b42df6e10a510"}]}