)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fbb5ce8b57a848a0adcfa28c200aa249fe756531","unresolved":true,"context_lines":[{"line_number":12,"context_line":"ensures that new vlan id is configured in the physical bridge on both"},{"line_number":13,"context_line":"\"hosts\" and connectivity between VMs still works fine."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test runs only with Openvswitch agents as Linuxbridge don\u0027t supports"},{"line_number":16,"context_line":"live update of the segmentation_id in the network."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I459aac7f4e9afe679d8ece1c27d0be49cec8e4ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"75375720_573b6c96","line":15,"range":{"start_line":15,"start_character":54,"end_line":15,"end_character":59},"updated":"2021-04-22 07:27:32.000000000","message":"nit: doesn\u0027t","commit_id":"e2cfea80caf610fa0e3ad73fdfb8dbd87f934356"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2048cab79e393841f583428d9fcd5fe95aeb6f28","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ensures that new vlan id is configured in the physical bridge on both"},{"line_number":13,"context_line":"\"hosts\" and connectivity between VMs still works fine."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test runs only with Openvswitch agents as Linuxbridge don\u0027t supports"},{"line_number":16,"context_line":"live update of the segmentation_id in the network."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I459aac7f4e9afe679d8ece1c27d0be49cec8e4ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f014d753_b05225b3","line":15,"range":{"start_line":15,"start_character":54,"end_line":15,"end_character":59},"in_reply_to":"75375720_573b6c96","updated":"2021-04-27 07:41:48.000000000","message":"Done","commit_id":"e2cfea80caf610fa0e3ad73fdfb8dbd87f934356"}],"neutron/tests/common/agents/l2_extensions.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"de51d1fcde12df770f83ec086d0f1e0519521b2b","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        for flow in flow_list:"},{"line_number":145,"context_line":"            if \u0027mod_vlan_vid\u0027 in flow:"},{"line_number":146,"context_line":"                actions \u003d flow.partition(\u0027actions\u003d\u0027)[2]"},{"line_number":147,"context_line":"                after_mod \u003d actions.partition(\u0027mod_vlan_vid:\u0027)[2]"},{"line_number":148,"context_line":"                mod_vlan_id \u003d int(after_mod.partition(\u0027,\u0027)[0])"},{"line_number":149,"context_line":"    return mod_vlan_id"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e88e542c_1953f0e9","line":147,"range":{"start_line":147,"start_character":46,"end_line":147,"end_character":61},"updated":"2021-04-15 09:38:58.000000000","message":"This is the internal VLAN ID, not the external VLAN segmentation ID.\n\nYou have this parameter in br-phy, in table 2\n\n cookie\u003d0xdcce85381598d047, duration\u003d41.143s, table\u003d2, n_packets\u003d34, n_bytes\u003d2210, priority\u003d4,in_port\u003d\"phy-br-phy\",dl_vlan\u003d4 actions\u003dmod_vlan_vid:133,NORMAL","commit_id":"527ae55a4f2812e36f2381ee3b78b250544a5397"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a63d2a610f61e91fd4c3ab6858fb3ecfa31dc66f","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        for flow in flow_list:"},{"line_number":145,"context_line":"            if \u0027mod_vlan_vid\u0027 in flow:"},{"line_number":146,"context_line":"                actions \u003d flow.partition(\u0027actions\u003d\u0027)[2]"},{"line_number":147,"context_line":"                after_mod \u003d actions.partition(\u0027mod_vlan_vid:\u0027)[2]"},{"line_number":148,"context_line":"                mod_vlan_id \u003d int(after_mod.partition(\u0027,\u0027)[0])"},{"line_number":149,"context_line":"    return mod_vlan_id"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b7f3b14b_799fdac2","line":147,"range":{"start_line":147,"start_character":46,"end_line":147,"end_character":61},"in_reply_to":"e88e542c_1953f0e9","updated":"2021-04-16 13:10:33.000000000","message":"sorry, I don\u0027t understand Your comment. If You check in https://review.opendev.org/c/openstack/neutron/+/783748/1/neutron/tests/fullstack/test_segmentation_id.py I am passing phys_br object as bridge to the wait_for_mod_vlan_id_applied() function. So it is checking OF rule in the physical bridge. And value in mod_vlan_id is segmentation_id in such case.","commit_id":"527ae55a4f2812e36f2381ee3b78b250544a5397"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"de51d1fcde12df770f83ec086d0f1e0519521b2b","unresolved":true,"context_lines":[{"line_number":145,"context_line":"            if \u0027mod_vlan_vid\u0027 in flow:"},{"line_number":146,"context_line":"                actions \u003d flow.partition(\u0027actions\u003d\u0027)[2]"},{"line_number":147,"context_line":"                after_mod \u003d actions.partition(\u0027mod_vlan_vid:\u0027)[2]"},{"line_number":148,"context_line":"                mod_vlan_id \u003d int(after_mod.partition(\u0027,\u0027)[0])"},{"line_number":149,"context_line":"    return mod_vlan_id"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b82ae6e9_a1f99d24","line":148,"range":{"start_line":148,"start_character":16,"end_line":148,"end_character":27},"updated":"2021-04-15 09:38:58.000000000","message":"Why don\u0027t you return here? To skip the rest of the flow list.","commit_id":"527ae55a4f2812e36f2381ee3b78b250544a5397"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a63d2a610f61e91fd4c3ab6858fb3ecfa31dc66f","unresolved":true,"context_lines":[{"line_number":145,"context_line":"            if \u0027mod_vlan_vid\u0027 in flow:"},{"line_number":146,"context_line":"                actions \u003d flow.partition(\u0027actions\u003d\u0027)[2]"},{"line_number":147,"context_line":"                after_mod \u003d actions.partition(\u0027mod_vlan_vid:\u0027)[2]"},{"line_number":148,"context_line":"                mod_vlan_id \u003d int(after_mod.partition(\u0027,\u0027)[0])"},{"line_number":149,"context_line":"    return mod_vlan_id"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dc68d245_524698d7","line":148,"range":{"start_line":148,"start_character":16,"end_line":148,"end_character":27},"in_reply_to":"b82ae6e9_a1f99d24","updated":"2021-04-16 13:10:33.000000000","message":"I should. Thx :)","commit_id":"527ae55a4f2812e36f2381ee3b78b250544a5397"}],"neutron/tests/fullstack/test_segmentation_id.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"de51d1fcde12df770f83ec086d0f1e0519521b2b","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        for host in self.environment.hosts:"},{"line_number":124,"context_line":"            l2_extensions.wait_for_mod_vlan_id_applied(host.br_phys, vlan_id)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_connectivity_after_segmentation_id_update(self):"},{"line_number":127,"context_line":"        network \u003d self._create_network()"},{"line_number":128,"context_line":"        self.safe_client.create_subnet("},{"line_number":129,"context_line":"            self.project_id, network[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"accb4b05_89bddef0","line":126,"updated":"2021-04-15 09:38:58.000000000","message":"One question about this test: both VMs are in the same host. The E-W traffic do not leave br-int, that means the traffic does egress through the physical bridge (and thus the traffic does not receive the external VLAN ID segmentation). Is still valid?","commit_id":"527ae55a4f2812e36f2381ee3b78b250544a5397"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a63d2a610f61e91fd4c3ab6858fb3ecfa31dc66f","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        for host in self.environment.hosts:"},{"line_number":124,"context_line":"            l2_extensions.wait_for_mod_vlan_id_applied(host.br_phys, vlan_id)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_connectivity_after_segmentation_id_update(self):"},{"line_number":127,"context_line":"        network \u003d self._create_network()"},{"line_number":128,"context_line":"        self.safe_client.create_subnet("},{"line_number":129,"context_line":"            self.project_id, network[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"4a36c37f_f4fd6f3f","line":126,"in_reply_to":"accb4b05_89bddef0","updated":"2021-04-16 13:10:33.000000000","message":"No, each vm is on different \"host\". Please note that num_hosts \u003d 2 in that class and in _prepare_vms_in_net() method in https://review.opendev.org/c/openstack/neutron/+/783748/1/neutron/tests/fullstack/base.py each vm created is on different host always. So traffic between them is going through \"phys net\"","commit_id":"527ae55a4f2812e36f2381ee3b78b250544a5397"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fbb5ce8b57a848a0adcfa28c200aa249fe756531","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    network_type \u003d \"vlan\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        hosts_description \u003d ["},{"line_number":32,"context_line":"            environment.HostDescription("},{"line_number":33,"context_line":"                l2_agent_type\u003dself.l2_agent_type, l3_agent\u003dFalse"},{"line_number":34,"context_line":"            ) for _ in range(self.num_hosts)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"c910aa31_3ca85798","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":25},"updated":"2021-04-22 07:27:32.000000000","message":"nit: host_descriptions?","commit_id":"e2cfea80caf610fa0e3ad73fdfb8dbd87f934356"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5246c7a3671f893ef733fe49a97441f4aeed269a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    network_type \u003d \"vlan\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        hosts_description \u003d ["},{"line_number":32,"context_line":"            environment.HostDescription("},{"line_number":33,"context_line":"                l2_agent_type\u003dself.l2_agent_type, l3_agent\u003dFalse"},{"line_number":34,"context_line":"            ) for _ in range(self.num_hosts)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"2141e370_f15aab45","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":25},"in_reply_to":"c910aa31_3ca85798","updated":"2021-04-27 07:41:16.000000000","message":"Done","commit_id":"e2cfea80caf610fa0e3ad73fdfb8dbd87f934356"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fbb5ce8b57a848a0adcfa28c200aa249fe756531","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        env \u003d environment.Environment("},{"line_number":36,"context_line":"            environment.EnvironmentDescription("},{"line_number":37,"context_line":"                network_type\u003dself.network_type),"},{"line_number":38,"context_line":"            hosts_description)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        super(BaseSegmentationIdTest, self).setUp(env)"},{"line_number":41,"context_line":"        self.project_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":2,"id":"e546b2ce_b5ee5e8e","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":29},"updated":"2021-04-22 07:27:32.000000000","message":"host_description[0]? As I see Environment has no idea of host_desc can be a list (https://opendev.org/openstack/neutron/src/branch/master/neutron/tests/fullstack/resources/environment.py#L361 )","commit_id":"e2cfea80caf610fa0e3ad73fdfb8dbd87f934356"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5246c7a3671f893ef733fe49a97441f4aeed269a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        env \u003d environment.Environment("},{"line_number":36,"context_line":"            environment.EnvironmentDescription("},{"line_number":37,"context_line":"                network_type\u003dself.network_type),"},{"line_number":38,"context_line":"            hosts_description)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        super(BaseSegmentationIdTest, self).setUp(env)"},{"line_number":41,"context_line":"        self.project_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":2,"id":"0433c3e0_844fb812","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":29},"in_reply_to":"e546b2ce_b5ee5e8e","updated":"2021-04-27 07:41:16.000000000","message":"It\u0027s passed as list always. And it\u0027s expected to be a list, see https://opendev.org/openstack/neutron/src/branch/master/neutron/tests/fullstack/resources/environment.py#L356","commit_id":"e2cfea80caf610fa0e3ad73fdfb8dbd87f934356"}]}