)]}'
{"neutron/tests/unit/conf/policies/test_l3_conntrack_helper.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4a94cf4ac850272007eb66566746ea6f21cd8ee5","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.alt_target \u003d {"},{"line_number":38,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"},{"line_number":39,"context_line":"            \u0027router_id\u0027: self.router[\u0027id\u0027],"},{"line_number":40,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dd38f95d_b6358f33","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":45},"updated":"2021-04-09 15:56:33.000000000","message":"At runtime - wouldn\u0027t the project_id from the conntrack helper target match the project_id of the router? Or do we allow them to be different?","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"39d770f0bed81a77b49319e17dfdcedc76581cd1","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.alt_target \u003d {"},{"line_number":38,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"},{"line_number":39,"context_line":"            \u0027router_id\u0027: self.router[\u0027id\u0027],"},{"line_number":40,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"949caf32_2e9f55cf","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":45},"in_reply_to":"35cd75de_84d9d4ee","updated":"2021-04-15 07:10:56.000000000","message":"yes, actually only system administrator can do that as other personas will not be able to see not own resources","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3cf1f004fa3460332c5e970390e178236947dcdc","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.alt_target \u003d {"},{"line_number":38,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"},{"line_number":39,"context_line":"            \u0027router_id\u0027: self.router[\u0027id\u0027],"},{"line_number":40,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"35cd75de_84d9d4ee","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":45},"in_reply_to":"6b638bf1_66c0ed67","updated":"2021-04-12 18:50:20.000000000","message":"Ok - so the conntrack helper is a separate object from the router, and each can belong to separate projects, is that right?\n\nWhat is responsible for associating the two objects? Can only an administrator associate a router from one project with a conntrack helper in another project?","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"54501a687bc6490c7fcaef188a317c71e64fc97a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.alt_target \u003d {"},{"line_number":38,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"},{"line_number":39,"context_line":"            \u0027router_id\u0027: self.router[\u0027id\u0027],"},{"line_number":40,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d9333a87_02960c6a","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":45},"in_reply_to":"949caf32_2e9f55cf","updated":"2021-04-15 13:50:03.000000000","message":"Ack","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb4820ee5fcba388e4fa48995d7ffc1eb4b8706e","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.alt_target \u003d {"},{"line_number":38,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"},{"line_number":39,"context_line":"            \u0027router_id\u0027: self.router[\u0027id\u0027],"},{"line_number":40,"context_line":"            \u0027ext_parent_router_id\u0027: self.router[\u0027id\u0027]}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6b638bf1_66c0ed67","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":45},"in_reply_to":"dd38f95d_b6358f33","updated":"2021-04-12 13:06:14.000000000","message":"they can be different","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4a94cf4ac850272007eb66566746ea6f21cd8ee5","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            policy.enforce,"},{"line_number":86,"context_line":"            self.context, \u0027create_router_conntrack_helper\u0027, self.target)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_get_router_conntrack_helper(self):"},{"line_number":89,"context_line":"        self.assertTrue("},{"line_number":90,"context_line":"            policy.enforce(self.context,"},{"line_number":91,"context_line":"                           \u0027get_router_conntrack_helper\u0027, self.target))"}],"source_content_type":"text/x-python","patch_set":1,"id":"02a4d31c_f62478d7","line":88,"updated":"2021-04-09 15:56:33.000000000","message":"nit: Potential to reduce some duplication if we inherit from SystemAdminTests","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb4820ee5fcba388e4fa48995d7ffc1eb4b8706e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            policy.enforce,"},{"line_number":86,"context_line":"            self.context, \u0027create_router_conntrack_helper\u0027, self.target)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_get_router_conntrack_helper(self):"},{"line_number":89,"context_line":"        self.assertTrue("},{"line_number":90,"context_line":"            policy.enforce(self.context,"},{"line_number":91,"context_line":"                           \u0027get_router_conntrack_helper\u0027, self.target))"}],"source_content_type":"text/x-python","patch_set":1,"id":"331eed65_dece11de","line":88,"in_reply_to":"02a4d31c_f62478d7","updated":"2021-04-12 13:06:14.000000000","message":"Done","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4a94cf4ac850272007eb66566746ea6f21cd8ee5","unresolved":true,"context_lines":[{"line_number":191,"context_line":"            policy.enforce(self.context,"},{"line_number":192,"context_line":"                           \u0027get_router_conntrack_helper\u0027, self.target))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_get_router_conntrack_helper_other_project(self):"},{"line_number":195,"context_line":"        self.assertRaises("},{"line_number":196,"context_line":"            base_policy.PolicyNotAuthorized,"},{"line_number":197,"context_line":"            policy.enforce,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8a60539_60c591a1","line":194,"updated":"2021-04-09 15:56:33.000000000","message":"nit: Potential to reduce some duplication if we inherit from ProjectMemberTests.","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb4820ee5fcba388e4fa48995d7ffc1eb4b8706e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            policy.enforce(self.context,"},{"line_number":192,"context_line":"                           \u0027get_router_conntrack_helper\u0027, self.target))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_get_router_conntrack_helper_other_project(self):"},{"line_number":195,"context_line":"        self.assertRaises("},{"line_number":196,"context_line":"            base_policy.PolicyNotAuthorized,"},{"line_number":197,"context_line":"            policy.enforce,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7867718_9f69f9a7","line":194,"in_reply_to":"c8a60539_60c591a1","updated":"2021-04-12 13:06:14.000000000","message":"Done","commit_id":"cd3ec5d0355808e96b96372aead3a7b97e9aed8b"}]}