)]}'
{"neutron/tests/unit/conf/policies/test_port.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"011a415e07b7245748ce5b23d3044ab09d2462f3","unresolved":true,"context_lines":[{"line_number":489,"context_line":"            self.context, \u0027create_port:allowed_address_pairs:ip_address\u0027,"},{"line_number":490,"context_line":"            self.alt_target)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_get_port(self):"},{"line_number":493,"context_line":"        self.assertTrue("},{"line_number":494,"context_line":"            policy.enforce(self.context, \u0027get_port\u0027, self.target))"},{"line_number":495,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":1,"id":"bb0a7f83_e492ec91","line":492,"updated":"2021-04-09 15:52:32.000000000","message":"nit: Potential to reduce some duplicate tests if we inherit from SystemAdminTests\n\nThe same is true for the following five tests.","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"08c4ab8d7c24a66e7ae2bafed960e30125a6d272","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            self.context, \u0027create_port:allowed_address_pairs:ip_address\u0027,"},{"line_number":490,"context_line":"            self.alt_target)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_get_port(self):"},{"line_number":493,"context_line":"        self.assertTrue("},{"line_number":494,"context_line":"            policy.enforce(self.context, \u0027get_port\u0027, self.target))"},{"line_number":495,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":1,"id":"3d5789e3_86d1d1d4","line":492,"in_reply_to":"bb0a7f83_e492ec91","updated":"2021-04-12 13:10:29.000000000","message":"Done","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"011a415e07b7245748ce5b23d3044ab09d2462f3","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"    def test_create_port_with_fixed_ips_and_subnet_id(self):"},{"line_number":1092,"context_line":"        self.assertRaises("},{"line_number":1093,"context_line":"            base_policy.PolicyNotAuthorized,"},{"line_number":1094,"context_line":"            policy.enforce, self.context, \u0027create_port:fixed_ips:subnet_id\u0027,"},{"line_number":1095,"context_line":"            self.target)"},{"line_number":1096,"context_line":"        self.assertRaises("},{"line_number":1097,"context_line":"            base_policy.PolicyNotAuthorized,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e379dd1d_7c02904e","line":1094,"updated":"2021-04-09 15:52:32.000000000","message":"So this is only exposed to project-admins? I think the old policy allowed network owners to create ports with specific subnet IDs. Should this be relaxed to allow project-members to do that? Or is that technically covered by RULE_NET_OWNER?","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"69c4fb06aec963290bfdf946a8539b7b78207701","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"    def test_create_port_with_fixed_ips_and_subnet_id(self):"},{"line_number":1092,"context_line":"        self.assertRaises("},{"line_number":1093,"context_line":"            base_policy.PolicyNotAuthorized,"},{"line_number":1094,"context_line":"            policy.enforce, self.context, \u0027create_port:fixed_ips:subnet_id\u0027,"},{"line_number":1095,"context_line":"            self.target)"},{"line_number":1096,"context_line":"        self.assertRaises("},{"line_number":1097,"context_line":"            base_policy.PolicyNotAuthorized,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1e026af_b61efaef","line":1094,"in_reply_to":"0fd6d16c_75198676","updated":"2021-04-12 18:44:10.000000000","message":"Ack","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"08c4ab8d7c24a66e7ae2bafed960e30125a6d272","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"    def test_create_port_with_fixed_ips_and_subnet_id(self):"},{"line_number":1092,"context_line":"        self.assertRaises("},{"line_number":1093,"context_line":"            base_policy.PolicyNotAuthorized,"},{"line_number":1094,"context_line":"            policy.enforce, self.context, \u0027create_port:fixed_ips:subnet_id\u0027,"},{"line_number":1095,"context_line":"            self.target)"},{"line_number":1096,"context_line":"        self.assertRaises("},{"line_number":1097,"context_line":"            base_policy.PolicyNotAuthorized,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0fd6d16c_75198676","line":1094,"in_reply_to":"e379dd1d_7c02904e","updated":"2021-04-12 13:10:29.000000000","message":"It should be covered by NET_OWNER rule","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"011a415e07b7245748ce5b23d3044ab09d2462f3","unresolved":true,"context_lines":[{"line_number":1528,"context_line":"            self.context, \u0027create_port:allowed_address_pairs:ip_address\u0027,"},{"line_number":1529,"context_line":"            self.alt_target)"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"    def test_get_port(self):"},{"line_number":1532,"context_line":"        self.assertTrue("},{"line_number":1533,"context_line":"            policy.enforce(self.context, \u0027get_port\u0027, self.target))"},{"line_number":1534,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"51c3d89c_ffbaa504","line":1531,"updated":"2021-04-09 15:52:32.000000000","message":"nit: Potential to reduce duplicate tests from ProjectMemberTests above.","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"08c4ab8d7c24a66e7ae2bafed960e30125a6d272","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"            self.context, \u0027create_port:allowed_address_pairs:ip_address\u0027,"},{"line_number":1529,"context_line":"            self.alt_target)"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"    def test_get_port(self):"},{"line_number":1532,"context_line":"        self.assertTrue("},{"line_number":1533,"context_line":"            policy.enforce(self.context, \u0027get_port\u0027, self.target))"},{"line_number":1534,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"63031297_8db578c7","line":1531,"in_reply_to":"51c3d89c_ffbaa504","updated":"2021-04-12 13:10:29.000000000","message":"Done","commit_id":"d9cfa0d061e53a631f5a1295be87ff405d77f072"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fc0547e35a5269a23fe947a0ed491d9eaf0e21ed","unresolved":true,"context_lines":[{"line_number":985,"context_line":"            policy.enforce, self.context, \u0027delete_port\u0027, self.alt_target)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"class ProjectMemberTests(PortAPITestCase):"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setUp(self):"},{"line_number":991,"context_line":"        super(ProjectMemberTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"0104a66a_cbc0f3ce","line":988,"range":{"start_line":988,"start_character":25,"end_line":988,"end_character":40},"updated":"2021-04-23 14:00:21.000000000","message":"Don\u0027t we save some repeated methods if we inherit from ProjectAdminTests?","commit_id":"99c77efa5429388f9642dd660e9de01b5bc6519b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95217799bcbfb76656af8fd77017c133f630af2f","unresolved":true,"context_lines":[{"line_number":985,"context_line":"            policy.enforce, self.context, \u0027delete_port\u0027, self.alt_target)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"class ProjectMemberTests(PortAPITestCase):"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setUp(self):"},{"line_number":991,"context_line":"        super(ProjectMemberTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"b2231996_26b851a2","line":988,"range":{"start_line":988,"start_character":25,"end_line":988,"end_character":40},"in_reply_to":"0104a66a_cbc0f3ce","updated":"2021-04-28 18:46:19.000000000","message":"++","commit_id":"99c77efa5429388f9642dd660e9de01b5bc6519b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b83e6f091bf1aa86c8d563e4587e7e02bb4f4caa","unresolved":true,"context_lines":[{"line_number":985,"context_line":"            policy.enforce, self.context, \u0027delete_port\u0027, self.alt_target)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"class ProjectMemberTests(PortAPITestCase):"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setUp(self):"},{"line_number":991,"context_line":"        super(ProjectMemberTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"d7baef36_9ef3b2b9","line":988,"range":{"start_line":988,"start_character":25,"end_line":988,"end_character":40},"in_reply_to":"b2231996_26b851a2","updated":"2021-05-25 08:56:10.000000000","message":"Right, we have. I just changed it","commit_id":"99c77efa5429388f9642dd660e9de01b5bc6519b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1aef4894f65b7a2d4fb96ce9d1ea23413f5a7d7c","unresolved":true,"context_lines":[{"line_number":985,"context_line":"            policy.enforce, self.context, \u0027delete_port\u0027, self.alt_target)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"class ProjectMemberTests(ProjectAdminTests):"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setUp(self):"},{"line_number":991,"context_line":"        super(ProjectMemberTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"92431810_03e7d7f0","line":988,"range":{"start_line":988,"start_character":25,"end_line":988,"end_character":42},"updated":"2021-05-25 09:00:20.000000000","message":"+1","commit_id":"f83c77bb12b7c501e2d54367ba9e49bd2a32920a"}]}