)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"799d9af04d0b50e2f0cccf8b3efc9b0c9f344207","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove unused method _ensure_vr_id_and_network()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Method _ensure_vr_id_and_network is not used in l3_hamode_db.py,"},{"line_number":10,"context_line":"hence can be moved to unit test where is used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1715371"},{"line_number":13,"context_line":"Change-Id: I9a64e683f060573195a88b3c4ee34abbd941fa44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"eafea89a_82d1444a","line":10,"updated":"2021-04-12 09:48:57.000000000","message":"sorry for nit picking but now this comment is not valid. Please adjust it to what this patch is actually doing and it will be LGTM for me :)","commit_id":"def0da33f587ff8b2981adda5e2e4d9bc74a9377"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"c8e29faf9c325cec5e0689b14a1df6fb59ee5029","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove unused method _ensure_vr_id_and_network()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Method _ensure_vr_id_and_network is not used in l3_hamode_db.py,"},{"line_number":10,"context_line":"hence can be moved to unit test where is used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1715371"},{"line_number":13,"context_line":"Change-Id: I9a64e683f060573195a88b3c4ee34abbd941fa44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d6ad1f1c_255ee5d1","line":10,"in_reply_to":"eafea89a_82d1444a","updated":"2021-04-12 11:15:35.000000000","message":"Done","commit_id":"def0da33f587ff8b2981adda5e2e4d9bc74a9377"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d27050f3636413e022e9ea85e90ab2b8ef8a07b9","unresolved":true,"context_lines":[{"line_number":353,"context_line":"                     self)._get_device_owner(context, router)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    @n_utils.transaction_guard"},{"line_number":356,"context_line":"    def _ensure_vr_id_and_network(self, context, router_db):"},{"line_number":357,"context_line":"        \"\"\"Attach vr_id to router while tolerating network deletes.\"\"\""},{"line_number":358,"context_line":"        creator \u003d functools.partial(self._ensure_vr_id,"},{"line_number":359,"context_line":"                                    context, router_db)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b072bdd8_348f163d","side":"PARENT","line":356,"range":{"start_line":356,"start_character":4,"end_line":356,"end_character":60},"updated":"2021-04-14 02:25:15.000000000","message":"It was [1] change the function name, and remove the call logic [2] [3]. It should be fine since it has been six years no bug reported on this. 😊\n[1] https://review.opendev.org/c/openstack/neutron/+/417089\n[2] https://review.opendev.org/c/openstack/neutron/+/417089/10/neutron/db/l3_hamode_db.py#416\n[3] https://review.opendev.org/c/openstack/neutron/+/417089/10/neutron/db/l3_hamode_db.py#505","commit_id":"1bc2313dc942aa1b612efa24b9e8b562b6881466"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7469035dd28f89e08337c3974093db7176289419","unresolved":true,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        def jam_in_interface(*args, **kwargs):"},{"line_number":307,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":308,"context_line":"            net \u003d self._ensure_vr_id_and_network("},{"line_number":309,"context_line":"                ctx, self.plugin._get_router(ctx, router[\u0027id\u0027]))"},{"line_number":310,"context_line":"            self.plugin.add_ha_port("},{"line_number":311,"context_line":"                ctx, router[\u0027id\u0027], net.network_id, router[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"24613426_bb066aed","line":308,"updated":"2021-04-07 19:57:16.000000000","message":"this seems to be the only place where this method is really used. Do we really need to keep it here? Maybe You could just create net object here and remove this method and its tests completly?","commit_id":"3f3c3c4fc47f94762182d5712aebfddbfde94a04"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"965e812b714be3c2fa188564c3a0b714b9aa6f1a","unresolved":true,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        def jam_in_interface(*args, **kwargs):"},{"line_number":307,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":308,"context_line":"            net \u003d self._ensure_vr_id_and_network("},{"line_number":309,"context_line":"                ctx, self.plugin._get_router(ctx, router[\u0027id\u0027]))"},{"line_number":310,"context_line":"            self.plugin.add_ha_port("},{"line_number":311,"context_line":"                ctx, router[\u0027id\u0027], net.network_id, router[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"848f7913_153936b3","line":308,"in_reply_to":"24613426_bb066aed","updated":"2021-04-08 12:51:09.000000000","message":"Done.","commit_id":"3f3c3c4fc47f94762182d5712aebfddbfde94a04"}]}