)]}'
{"neutron/tests/functional/agent/test_dhcp_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a41ff72e7dcdc0f2b0bea7654d127760d62024c","unresolved":true,"context_lines":[{"line_number":368,"context_line":"            id\u003dnew_network.ports[0].id,"},{"line_number":369,"context_line":"            mac_address\u003dstr(self._DHCP_PORT_MAC_ADDRESS))"},{"line_number":370,"context_line":"        self.mock_plugin_api.get_dhcp_port.return_value \u003d dhcp_port_mock"},{"line_number":371,"context_line":"        self.mock_plugin_api.update_dhcp_port.return_value \u003d dhcp_port_mock"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        with mock.patch.object(dhcp.DeviceManager, \"_update_dhcp_port\"):"},{"line_number":374,"context_line":"            self.agent.refresh_dhcp_helper(network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ff192f2_4e130f1f","line":371,"updated":"2021-04-06 11:13:31.000000000","message":"I don\u0027t understand the description of this bug. The port returned is always the same (here is the line mocking the method that returns this port). If we execute twice the \"setup\" method, we\u0027ll always have the same port and the \"_update_dhcp_port\" will always succeed.\n\nHow can I reproduce what you describe in the commit message?","commit_id":"e3ec734b6852fb4e8071003fd2dff30f260915f4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db447bc984ebb81a347a686c7628d0e639e32926","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            id\u003dnew_network.ports[0].id,"},{"line_number":369,"context_line":"            mac_address\u003dstr(self._DHCP_PORT_MAC_ADDRESS))"},{"line_number":370,"context_line":"        self.mock_plugin_api.get_dhcp_port.return_value \u003d dhcp_port_mock"},{"line_number":371,"context_line":"        self.mock_plugin_api.update_dhcp_port.return_value \u003d dhcp_port_mock"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        with mock.patch.object(dhcp.DeviceManager, \"_update_dhcp_port\"):"},{"line_number":374,"context_line":"            self.agent.refresh_dhcp_helper(network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"85a670ba_db3a671e","line":371,"in_reply_to":"429fb2fe_d353c4ec","updated":"2021-04-08 09:50:19.000000000","message":"Done","commit_id":"e3ec734b6852fb4e8071003fd2dff30f260915f4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba88143090ba72c6d6613b5c9467ed86aea561ab","unresolved":true,"context_lines":[{"line_number":368,"context_line":"            id\u003dnew_network.ports[0].id,"},{"line_number":369,"context_line":"            mac_address\u003dstr(self._DHCP_PORT_MAC_ADDRESS))"},{"line_number":370,"context_line":"        self.mock_plugin_api.get_dhcp_port.return_value \u003d dhcp_port_mock"},{"line_number":371,"context_line":"        self.mock_plugin_api.update_dhcp_port.return_value \u003d dhcp_port_mock"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        with mock.patch.object(dhcp.DeviceManager, \"_update_dhcp_port\"):"},{"line_number":374,"context_line":"            self.agent.refresh_dhcp_helper(network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"429fb2fe_d353c4ec","line":371,"in_reply_to":"4ff192f2_4e130f1f","updated":"2021-04-06 17:25:05.000000000","message":"Ok, you know how stubborn am I.\n\nI tested adding a random exception in the iptables method. The problem here is how we are defining the variables.\n\nWe should:\n- Create proper port dictionaries (dhcp.DictModel).\n- Delete the network and new_network ports before using them. \"network_dict_for_dhcp\" creates, be default, a port with the defined \"ip_version\". But in this case those networks should not have a port, particularly in the subnet were we are enabling the dhcp. This port should be created during the DHCP enablement.\n\nThis is the code we should push: http://paste.openstack.org/show/804212/","commit_id":"e3ec734b6852fb4e8071003fd2dff30f260915f4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"078d6f62fc780435d8a8e94bc9b11967dcb608e9","unresolved":true,"context_lines":[{"line_number":358,"context_line":"        new_network.subnets.append(dhcp_enabled_ipv4_subnet)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        self.mock_plugin_api.get_network_info.return_value \u003d new_network"},{"line_number":361,"context_line":"        dhcp_port_mock \u003d self.create_port_dict("},{"line_number":362,"context_line":"            network.id, dhcp_enabled_ipv4_subnet.id,"},{"line_number":363,"context_line":"            mac_address\u003dstr(self._DHCP_PORT_MAC_ADDRESS))"},{"line_number":364,"context_line":"        self.mock_plugin_api.create_dhcp_port.return_value \u003d dhcp_port_mock"}],"source_content_type":"text/x-python","patch_set":2,"id":"f71aa5bf_e37b7f68","line":361,"updated":"2021-04-09 17:19:10.000000000","message":"+1","commit_id":"6533337716e5776567e0c9e9a8a20e2ad704e258"}]}