)]}'
{"neutron/tests/unit/conf/policies/test_router.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bd2d52c3591b216e435311b615d4002e13d8fc25","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create_router(self):"},{"line_number":37,"context_line":"        self.assertTrue("},{"line_number":38,"context_line":"            policy.enforce(self.context, \u0027create_router\u0027, self.target))"},{"line_number":39,"context_line":"        self.assertTrue("},{"line_number":40,"context_line":"            policy.enforce(self.context, \u0027create_router\u0027, self.alt_target))"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5c50b054_b6139fbe","line":38,"updated":"2021-04-09 15:29:39.000000000","message":"How is this not failing because of https://github.com/openstack/neutron/blob/master/neutron/conf/policies/router.py#L43 ?","commit_id":"7b93c0ea7786fbe81643836cfe7a88165aa25956"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6c6f25c7337c733fbd84989e0c5370c45d236bd5","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create_router(self):"},{"line_number":37,"context_line":"        self.assertTrue("},{"line_number":38,"context_line":"            policy.enforce(self.context, \u0027create_router\u0027, self.target))"},{"line_number":39,"context_line":"        self.assertTrue("},{"line_number":40,"context_line":"            policy.enforce(self.context, \u0027create_router\u0027, self.alt_target))"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"908cff6f_71d531a3","line":38,"in_reply_to":"1152c8ec_62f8c810","updated":"2021-04-12 18:57:28.000000000","message":"No - I think the context you\u0027ve modeled for the test looks accurate. What I\u0027m confused about is why oslo.policy didn\u0027t raise an InvalidScope exception because \u0027system\u0027 wasn\u0027t in the list of scope_types.","commit_id":"7b93c0ea7786fbe81643836cfe7a88165aa25956"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0c5d177b9f45b41539a193fdb66d66107c346aee","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create_router(self):"},{"line_number":37,"context_line":"        self.assertTrue("},{"line_number":38,"context_line":"            policy.enforce(self.context, \u0027create_router\u0027, self.target))"},{"line_number":39,"context_line":"        self.assertTrue("},{"line_number":40,"context_line":"            policy.enforce(self.context, \u0027create_router\u0027, self.alt_target))"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1152c8ec_62f8c810","line":38,"in_reply_to":"5c50b054_b6139fbe","updated":"2021-04-12 13:18:44.000000000","message":"It\u0027s because we created admin_context with system_scope\u003d\u0027all\u0027 in those tests. Should we change it?\n\nI also proposed https://review.opendev.org/c/openstack/neutron/+/785872 to fix that rule.","commit_id":"7b93c0ea7786fbe81643836cfe7a88165aa25956"}]}