)]}'
{"neutron/debug/commands.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ef571884fc1ea7ff457ad9b1383ab4368ebc07c4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--device-owner\u0027,"},{"line_number":49,"context_line":"            default\u003d\u0027neutron:network\u0027, choices\u003d[\u0027neutron:network\u0027,"},{"line_number":50,"context_line":"                                                \u0027neutron:compute\u0027],"},{"line_number":51,"context_line":"            help\u003d_(\u0027Owner type of the device: network/compute\u0027))"},{"line_number":52,"context_line":"        return parser"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FIVo%3D","line":50,"updated":"2014-03-08 16:16:56.000000000","message":"If I remember correctly, iptables based security group is not applied to a port whose device_owner is \"network:*\". Thus I think it is better to keep network:* prefix.","commit_id":"0b128d9528e5cba67ca4a64ff84b48ae6d0fa794"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"251cbf2abdc4152ad38bb365edd1a1219904e2b0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--device-owner\u0027,"},{"line_number":49,"context_line":"            default\u003d\u0027neutron:network\u0027, choices\u003d[\u0027neutron:network\u0027,"},{"line_number":50,"context_line":"                                                \u0027neutron:compute\u0027],"},{"line_number":51,"context_line":"            help\u003d_(\u0027Owner type of the device: network/compute\u0027))"},{"line_number":52,"context_line":"        return parser"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FEtA%3D","line":50,"in_reply_to":"AAAAVn%2F%2FIVo%3D","updated":"2014-03-10 06:54:23.000000000","message":"Done","commit_id":"0b128d9528e5cba67ca4a64ff84b48ae6d0fa794"}],"neutron/debug/debug_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"661d6b563ae7b6a090ca3e6f07033d01eed75d9f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DEVICE_OWNER_NETWORK_PROBE \u003d \u0027network:probe\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DEVICE_OWNER_COMPUTE_PROBE \u003d \u0027neutron:compute:probe\u0027"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FYHw%3D","line":33,"updated":"2014-03-06 14:32:58.000000000","message":"Maybe you should change the other one as well...","commit_id":"57abf52c05113e3f6fc3032e650ec3f6a828b0a5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"284c0e5d6f1051a639cce51749b2d004a8f377ba","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DEVICE_OWNER_NETWORK_PROBE \u003d \u0027neutron:network:probe\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DEVICE_OWNER_COMPUTE_PROBE \u003d \u0027neutron:compute:probe\u0027"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FqHU%3D","line":33,"updated":"2014-03-14 17:14:34.000000000","message":"neutron:network seems pretty redundant to be honest. I\u0027d just leave things as they are","commit_id":"0b128d9528e5cba67ca4a64ff84b48ae6d0fa794"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a569219a03be1e14f647ca5a5fb0ad795bdeb88c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def _get_namespace(self, port):"},{"line_number":54,"context_line":"        return \"qprobe-%s\" % port.id"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def create_probe(self, network_id, device_owner\u003d\u0027neutron:network\u0027):"},{"line_number":57,"context_line":"        network \u003d self._get_network(network_id)"},{"line_number":58,"context_line":"        bridge \u003d None"},{"line_number":59,"context_line":"        if network.external:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Fp2o%3D","line":56,"updated":"2014-03-14 18:07:13.000000000","message":"How about not changing the arguments, and instead add a line here:\n\n  device_owner \u003d \"debug:\" + device_owner\n\n(and change the constants at lines 33,35 to start with \u0027debug:\u0027)","commit_id":"0b128d9528e5cba67ca4a64ff84b48ae6d0fa794"}],"neutron/notifiers/nova.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ec2421497495ecdc4a5f3c755a9b5447b1ef29d1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        event_sender \u003d loopingcall.FixedIntervalLoopingCall(self.send_events)"},{"line_number":56,"context_line":"        event_sender.start(interval\u003dcfg.CONF.send_events_interval)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _is_compute_port(self, port):"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if (port[\u0027device_id\u0027] and uuidutils.is_uuid_like(port[\u0027device_id\u0027])"},{"line_number":61,"context_line":"                    and port[\u0027device_owner\u0027].startswith(\u0027compute:\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9%2FTI%3D","line":58,"updated":"2014-03-31 18:19:04.000000000","message":"rename to is_nova_compute_port ?\n\nAlso, there are other plugins/drivers that check this condition, so I think it would make sense to move this to a function in common/utils. This can be done in a follow-up patch.","commit_id":"6b4fecb9de0aa80e66b31555001dca95d14c789f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"159bbc535c1b1926daf4082c1e3b49321af33b97","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        event_sender \u003d loopingcall.FixedIntervalLoopingCall(self.send_events)"},{"line_number":56,"context_line":"        event_sender.start(interval\u003dcfg.CONF.send_events_interval)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _is_compute_port(self, port):"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if (port[\u0027device_id\u0027] and uuidutils.is_uuid_like(port[\u0027device_id\u0027])"},{"line_number":61,"context_line":"                    and port[\u0027device_owner\u0027].startswith(\u0027compute:\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9%2BV0%3D","line":58,"in_reply_to":"AAAAWH%2F9%2Bjo%3D","updated":"2014-03-31 20:22:02.000000000","message":"Agree, let\u0027s defer the name change to when the function is moved to common/utils. Sorry for the comment noise.","commit_id":"6b4fecb9de0aa80e66b31555001dca95d14c789f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6976b12251bab96b24831445bd3f61ae9faa98e6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        event_sender \u003d loopingcall.FixedIntervalLoopingCall(self.send_events)"},{"line_number":56,"context_line":"        event_sender.start(interval\u003dcfg.CONF.send_events_interval)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _is_compute_port(self, port):"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if (port[\u0027device_id\u0027] and uuidutils.is_uuid_like(port[\u0027device_id\u0027])"},{"line_number":61,"context_line":"                    and port[\u0027device_owner\u0027].startswith(\u0027compute:\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9%2Bjo%3D","line":58,"in_reply_to":"AAAAWH%2F9%2FTI%3D","updated":"2014-03-31 19:52:38.000000000","message":"this is already in the nova.py file so  i\u0027m not sure if it\u0027s worth really changing. If i have to push another patch i\u0027ll change it though.","commit_id":"6b4fecb9de0aa80e66b31555001dca95d14c789f"}]}
