)]}'
{"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e675d2bdfedfe26f4529ccdcc2697bcd4e893dc7","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                          network_id)"},{"line_number":228,"context_line":"                return"},{"line_number":229,"context_line":"            enabled_agents \u003d self._get_enabled_agents("},{"line_number":230,"context_line":"                context, network_id, agents, method, payload)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            if method \u003d\u003d \u0027port_create_end\u0027 and enabled_agents:"},{"line_number":233,"context_line":"                high_agent \u003d enabled_agents.pop("}],"source_content_type":"text/x-python","patch_set":2,"id":"f9bc4a59_b8efd8cc","line":230,"range":{"start_line":230,"start_character":25,"end_line":230,"end_character":35},"updated":"2021-04-09 09:35:17.000000000","message":"You can have network as an input parameter or from L222. Why don\u0027t you pass it too?","commit_id":"4cd42b28ecdc64cced8e1323041ba6c5f4c651aa"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e046c6865594617c9b11848d833088034b71c3cc","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                          network_id)"},{"line_number":228,"context_line":"                return"},{"line_number":229,"context_line":"            enabled_agents \u003d self._get_enabled_agents("},{"line_number":230,"context_line":"                context, network_id, agents, method, payload)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            if method \u003d\u003d \u0027port_create_end\u0027 and enabled_agents:"},{"line_number":233,"context_line":"                high_agent \u003d enabled_agents.pop("}],"source_content_type":"text/x-python","patch_set":2,"id":"4b920e80_a00c89e7","line":230,"range":{"start_line":230,"start_character":25,"end_line":230,"end_character":35},"in_reply_to":"82e7baac_df42eb3b","updated":"2021-04-09 10:30:52.000000000","message":"Agree","commit_id":"4cd42b28ecdc64cced8e1323041ba6c5f4c651aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74ce804aa81a5c2b5d64dc2cdcb4d9008e10444f","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                          network_id)"},{"line_number":228,"context_line":"                return"},{"line_number":229,"context_line":"            enabled_agents \u003d self._get_enabled_agents("},{"line_number":230,"context_line":"                context, network_id, agents, method, payload)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            if method \u003d\u003d \u0027port_create_end\u0027 and enabled_agents:"},{"line_number":233,"context_line":"                high_agent \u003d enabled_agents.pop("}],"source_content_type":"text/x-python","patch_set":2,"id":"82e7baac_df42eb3b","line":230,"range":{"start_line":230,"start_character":25,"end_line":230,"end_character":35},"in_reply_to":"dcf7dbce_a97f4186","updated":"2021-04-09 10:06:54.000000000","message":"That\u0027s ok if you pass both network_id and network. If network object exists, then you don\u0027t need to retrieve it.","commit_id":"4cd42b28ecdc64cced8e1323041ba6c5f4c651aa"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b55410d8cd89f2504ca1be60df7bf590b38eb7ee","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                          network_id)"},{"line_number":228,"context_line":"                return"},{"line_number":229,"context_line":"            enabled_agents \u003d self._get_enabled_agents("},{"line_number":230,"context_line":"                context, network_id, agents, method, payload)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            if method \u003d\u003d \u0027port_create_end\u0027 and enabled_agents:"},{"line_number":233,"context_line":"                high_agent \u003d enabled_agents.pop("}],"source_content_type":"text/x-python","patch_set":2,"id":"dcf7dbce_a97f4186","line":230,"range":{"start_line":230,"start_character":25,"end_line":230,"end_character":35},"in_reply_to":"f9bc4a59_b8efd8cc","updated":"2021-04-09 09:41:34.000000000","message":"For example subnet_delete_end case does not have network as an input parameter, and schedule is not required - so network is None here. Same for subnet_update_end, port_update_end, etc.","commit_id":"4cd42b28ecdc64cced8e1323041ba6c5f4c651aa"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d3e32897eb5a964abca0ec244b62eedfb9d5408a","unresolved":true,"context_lines":[{"line_number":1295,"context_line":"                LOG.error(\"mechanism_manager.create_subnet_postcommit \""},{"line_number":1296,"context_line":"                          \"failed, deleting subnet \u0027%s\u0027\", result[\u0027id\u0027])"},{"line_number":1297,"context_line":"                self.delete_subnet(context, result[\u0027id\u0027])"},{"line_number":1298,"context_line":"        return result"},{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":"    @utils.transaction_guard"},{"line_number":1301,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":4,"id":"411badd5_f03da41f","line":1298,"range":{"start_line":1298,"start_character":8,"end_line":1298,"end_character":21},"updated":"2021-04-16 06:29:26.000000000","message":"Should pop the network out after the notification here?","commit_id":"130655cdb98f493d0ceda72e2c3a0649c3d9024d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"01c37b2e311fb14ba2217092ac9da54a2708d0fd","unresolved":true,"context_lines":[{"line_number":1295,"context_line":"                LOG.error(\"mechanism_manager.create_subnet_postcommit \""},{"line_number":1296,"context_line":"                          \"failed, deleting subnet \u0027%s\u0027\", result[\u0027id\u0027])"},{"line_number":1297,"context_line":"                self.delete_subnet(context, result[\u0027id\u0027])"},{"line_number":1298,"context_line":"        return result"},{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":"    @utils.transaction_guard"},{"line_number":1301,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a961240_eaa4b7d3","line":1298,"range":{"start_line":1298,"start_character":8,"end_line":1298,"end_character":21},"in_reply_to":"411badd5_f03da41f","updated":"2021-04-16 08:50:56.000000000","message":"Not sure, probably it won\u0027t hurt anything","commit_id":"130655cdb98f493d0ceda72e2c3a0649c3d9024d"}]}