)]}'
{"neutron/services/l3_router/service_providers/driver_controller.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e67c9564e3270cf1dedf6534c7d190948a91eb08","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        distributed \u003d _is_distributed("},{"line_number":225,"context_line":"            router.get(\u0027distributed\u0027, lib_const.ATTR_NOT_SPECIFIED))"},{"line_number":226,"context_line":"        ha \u003d _is_ha(router.get(\u0027ha\u0027, lib_const.ATTR_NOT_SPECIFIED))"},{"line_number":227,"context_line":"        drivers \u003d list(self.drivers.values())"},{"line_number":228,"context_line":"        # make sure default is tried before the rest if defined"},{"line_number":229,"context_line":"        if self.default_provider:"},{"line_number":230,"context_line":"            drivers.insert(0, self.drivers[self.default_provider])"}],"source_content_type":"text/x-python","patch_set":1,"id":"90de4806_fc4ea146","line":227,"range":{"start_line":227,"start_character":18,"end_line":227,"end_character":45},"updated":"2021-04-12 08:57:10.000000000","message":"how was that working before?","commit_id":"109faeac7e2e37da3bb7d5014a37ef18ed8cb80a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"90af2d3bbfc342256e35a83267657d9128ef1b15","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        distributed \u003d _is_distributed("},{"line_number":225,"context_line":"            router.get(\u0027distributed\u0027, lib_const.ATTR_NOT_SPECIFIED))"},{"line_number":226,"context_line":"        ha \u003d _is_ha(router.get(\u0027ha\u0027, lib_const.ATTR_NOT_SPECIFIED))"},{"line_number":227,"context_line":"        drivers \u003d list(self.drivers.values())"},{"line_number":228,"context_line":"        # make sure default is tried before the rest if defined"},{"line_number":229,"context_line":"        if self.default_provider:"},{"line_number":230,"context_line":"            drivers.insert(0, self.drivers[self.default_provider])"}],"source_content_type":"text/x-python","patch_set":1,"id":"b793144a_23fa4917","line":227,"range":{"start_line":227,"start_character":18,"end_line":227,"end_character":45},"in_reply_to":"90de4806_fc4ea146","updated":"2021-04-12 13:54:46.000000000","message":"I guess nobody used it with self.default_provider\u003d\u003dTrue.\n\nAnd the unit tests mocked it away.","commit_id":"109faeac7e2e37da3bb7d5014a37ef18ed8cb80a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f02753ae675961cbbd39ec02fe1ea0fb34d482f7","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        distributed \u003d _is_distributed("},{"line_number":225,"context_line":"            router.get(\u0027distributed\u0027, lib_const.ATTR_NOT_SPECIFIED))"},{"line_number":226,"context_line":"        ha \u003d _is_ha(router.get(\u0027ha\u0027, lib_const.ATTR_NOT_SPECIFIED))"},{"line_number":227,"context_line":"        drivers \u003d list(self.drivers.values())"},{"line_number":228,"context_line":"        # make sure default is tried before the rest if defined"},{"line_number":229,"context_line":"        if self.default_provider:"},{"line_number":230,"context_line":"            drivers.insert(0, self.drivers[self.default_provider])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b90e0a8_efa78bd1","line":227,"range":{"start_line":227,"start_character":18,"end_line":227,"end_character":45},"in_reply_to":"b793144a_23fa4917","updated":"2021-04-14 12:12:50.000000000","message":"My first though about it was exactly the same as Rodolfo\u0027s :)","commit_id":"109faeac7e2e37da3bb7d5014a37ef18ed8cb80a"}]}