)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20185a4bcb3e10e96f29f6d9948b2c62d02989df","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the exact reason of failure i.e. ExternalDNSOverQuota instead of"},{"line_number":12,"context_line":"HttpException."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch is dependent on:"},{"line_number":15,"context_line":"https://review.opendev.org/c/openstack/neutron-lib/+/786174"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1923700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c9b832d3_ffa79dca","line":14,"updated":"2021-04-14 09:04:47.000000000","message":"To use the referred patch on this one, you should use the pragma:\n\nDepends-On: https://review.opendev.org/c/openstack/neutron-lib/+/786174\n\nThat will install this patch when testing in the CI.","commit_id":"7396c8833b2cf0c02f79bba4e9ea0228ddc41341"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"62cd54a0d3554d43b1b73751165e17635959fd07","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the exact reason of failure i.e. ExternalDNSOverQuota instead of"},{"line_number":12,"context_line":"HttpException."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch is dependent on:"},{"line_number":15,"context_line":"https://review.opendev.org/c/openstack/neutron-lib/+/786174"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1923700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"551c5ea2_3c6e52c1","line":14,"in_reply_to":"c9b832d3_ffa79dca","updated":"2021-04-14 11:58:05.000000000","message":"Done","commit_id":"7396c8833b2cf0c02f79bba4e9ea0228ddc41341"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dcded321f162ba8654b0e29a1eead427b82a5339","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Report ExternalDNSOverQuota exception for recordset quota error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When floating IP is created and the overquota limit of the external"},{"line_number":10,"context_line":"dns service (e.g. designate) exceeds, recordset creation fails. Report"},{"line_number":11,"context_line":"the exact reason of failure i.e. ExternalDNSOverQuota instead of"},{"line_number":12,"context_line":"HttpException."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"22071763_e95e821d","line":9,"updated":"2021-04-20 13:03:16.000000000","message":"This should not only affect FIP creation but also ports with DNS records.","commit_id":"aa0f9031f8db314a99cca7de92cb0c556c87ef75"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ede5b7fe907f48a68bd858cd43f1d9f131edacea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Report ExternalDNSOverQuota exception for recordset quota error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When floating IP is created and the overquota limit of the external"},{"line_number":10,"context_line":"dns service (e.g. designate) exceeds, recordset creation fails. Report"},{"line_number":11,"context_line":"the exact reason of failure i.e. ExternalDNSOverQuota instead of"},{"line_number":12,"context_line":"HttpException."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e2b66646_b3beb1b8","line":9,"in_reply_to":"22071763_e95e821d","updated":"2021-04-23 05:06:33.000000000","message":"Done","commit_id":"aa0f9031f8db314a99cca7de92cb0c556c87ef75"}],"neutron/services/externaldns/drivers/designate/driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db4cc9fc40e49d2a229cb1337297df9b9b843be8","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        except d_exc.Conflict:"},{"line_number":104,"context_line":"            raise dns_exc.DuplicateRecordSet(dns_name\u003ddns_name)"},{"line_number":105,"context_line":"        except d_exc.OverQuota:"},{"line_number":106,"context_line":"            raise dns_exc.ExternalDNSOverQuota(resource\u003d\"recordset\")"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if not CONF.designate.allow_reverse_dns_lookup:"},{"line_number":109,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8dfdccd_eb99c38c","line":106,"updated":"2021-04-16 07:38:55.000000000","message":"This should fails in some test for now as You will need new neutron-lib to be released to have this new exception class available.\nAs it didn\u0027t fail anywhere I think we are lacking some test case. Maybe You could add some test to cover such case?","commit_id":"aa0f9031f8db314a99cca7de92cb0c556c87ef75"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6fa64e89607eead8d4ff148371949d9e59b24fcb","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        except d_exc.Conflict:"},{"line_number":104,"context_line":"            raise dns_exc.DuplicateRecordSet(dns_name\u003ddns_name)"},{"line_number":105,"context_line":"        except d_exc.OverQuota:"},{"line_number":106,"context_line":"            raise dns_exc.ExternalDNSOverQuota(resource\u003d\"recordset\")"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if not CONF.designate.allow_reverse_dns_lookup:"},{"line_number":109,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"061fb2b9_2742bbfe","line":106,"in_reply_to":"e8dfdccd_eb99c38c","updated":"2021-04-16 09:10:56.000000000","message":"The dependent change of neutron-lib is merged and recent zuul failures seems to be false positive. Zuul earlier did not execute because depends on change was not merged.\nAlso regarding tests, it was earlier suggested by Oleg Bondarev as well. However, I did not find any tests for earlier exceptions of externalDNS and hence not added.","commit_id":"aa0f9031f8db314a99cca7de92cb0c556c87ef75"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d2f070b6f2481ad1b96978b94c50ef5cb3d5946","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8b7c572f_067f106f","updated":"2021-05-25 08:58:58.000000000","message":"I am a little surprised that there\u0027s no unit tests for the externaldns service plugin.","commit_id":"c16f88d1481f59e8547c406ac24b670723a3b1da"}],"releasenotes/notes/add-ExternalDNSOverQuota-exception-8728f055d4f1d43c.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1e7028ba262becfec4c6afa6cf869a60daf8446e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When floating IP or port with DNS records are created and the recordset"},{"line_number":5,"context_line":"    quota value of the external dns service (e.g. designate) exceeds limit,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"516b2e1b_54be0b27","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2021-04-27 07:30:07.000000000","message":"only \"fixes\" section is enough","commit_id":"2c118d7718ea293207d444fc994b5daf63c24e15"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e8944b4d498464d5e796c599927b585d1fd9d023","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When floating IP or port with DNS records are created and the recordset"},{"line_number":5,"context_line":"    quota value of the external dns service (e.g. designate) exceeds limit,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b42d0a00_04ae7567","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"in_reply_to":"516b2e1b_54be0b27","updated":"2021-04-27 07:52:54.000000000","message":"Done","commit_id":"2c118d7718ea293207d444fc994b5daf63c24e15"}]}